Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-29 Thread Herbert Xu
On Tue, Apr 28, 2015 at 09:52:32PM +0200, Boris Brezillon wrote: > > In particular, I'd like to discuss the threaded-irq approach taken in > this driver (other drivers are using tasklets). > The main reason behind this choice is the fact that crypto engines > are quite fast, and I'm worried about

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-28 Thread Boris Brezillon
Herbert, David, Any comment on the crypto driver implementation ? I've had several reviews focused on: 1/ splitting the patch series into smaller subsets 2/ allowing for smoother transition from the old driver to the new one I'll address (or have addressed) all of these comments, but I'd like to

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-17 Thread Gregory CLEMENT
On 17/04/2015 17:49, Maxime Ripard wrote: > On Fri, Apr 17, 2015 at 05:01:55PM +0200, Gregory CLEMENT wrote: >> On 17/04/2015 16:50, Maxime Ripard wrote: >>> On Fri, Apr 17, 2015 at 04:40:43PM +0200, Gregory CLEMENT wrote: Hi Maxime, On 17/04/2015 16:32, Maxime Ripard wrote: > On

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-17 Thread Maxime Ripard
On Fri, Apr 17, 2015 at 05:01:55PM +0200, Gregory CLEMENT wrote: > On 17/04/2015 16:50, Maxime Ripard wrote: > > On Fri, Apr 17, 2015 at 04:40:43PM +0200, Gregory CLEMENT wrote: > >> Hi Maxime, > >> > >> On 17/04/2015 16:32, Maxime Ripard wrote: > >>> On Fri, Apr 17, 2015 at 04:19:22PM +0200, Boris

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-17 Thread Gregory CLEMENT
On 17/04/2015 16:50, Maxime Ripard wrote: > On Fri, Apr 17, 2015 at 04:40:43PM +0200, Gregory CLEMENT wrote: >> Hi Maxime, >> >> On 17/04/2015 16:32, Maxime Ripard wrote: >>> On Fri, Apr 17, 2015 at 04:19:22PM +0200, Boris Brezillon wrote: Hi Gregory, On Fri, 17 Apr 2015 15:01:01 +02

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-17 Thread Maxime Ripard
On Fri, Apr 17, 2015 at 04:40:43PM +0200, Gregory CLEMENT wrote: > Hi Maxime, > > On 17/04/2015 16:32, Maxime Ripard wrote: > > On Fri, Apr 17, 2015 at 04:19:22PM +0200, Boris Brezillon wrote: > >> Hi Gregory, > >> > >> On Fri, 17 Apr 2015 15:01:01 +0200 > >> Gregory CLEMENT wrote: > >> > >>> Hi

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-17 Thread Gregory CLEMENT
Hi Maxime, On 17/04/2015 16:32, Maxime Ripard wrote: > On Fri, Apr 17, 2015 at 04:19:22PM +0200, Boris Brezillon wrote: >> Hi Gregory, >> >> On Fri, 17 Apr 2015 15:01:01 +0200 >> Gregory CLEMENT wrote: >> >>> Hi Boris, >>> >>> On 17/04/2015 10:39, Boris Brezillon wrote: On Fri, 17 Apr 2015 1

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-17 Thread Maxime Ripard
On Fri, Apr 17, 2015 at 04:19:22PM +0200, Boris Brezillon wrote: > Hi Gregory, > > On Fri, 17 Apr 2015 15:01:01 +0200 > Gregory CLEMENT wrote: > > > Hi Boris, > > > > On 17/04/2015 10:39, Boris Brezillon wrote: > > > On Fri, 17 Apr 2015 10:33:56 +0200 > > > Boris Brezillon wrote: > > > > > >>

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-17 Thread Boris Brezillon
Hi Gregory, On Fri, 17 Apr 2015 15:01:01 +0200 Gregory CLEMENT wrote: > Hi Boris, > > On 17/04/2015 10:39, Boris Brezillon wrote: > > On Fri, 17 Apr 2015 10:33:56 +0200 > > Boris Brezillon wrote: > > > >> Hi Jason, > >> > >> On Mon, 13 Apr 2015 20:11:46 + > >> Jason Cooper wrote: > >> >

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-17 Thread Gregory CLEMENT
Hi Boris, On 17/04/2015 10:39, Boris Brezillon wrote: > On Fri, 17 Apr 2015 10:33:56 +0200 > Boris Brezillon wrote: > >> Hi Jason, >> >> On Mon, 13 Apr 2015 20:11:46 + >> Jason Cooper wrote: >> > I'd appreciate if we'd look into it. I understand from on-list and > off-list dis

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-17 Thread Jason Cooper
Hey Boris, On Fri, Apr 17, 2015 at 10:39:46AM +0200, Boris Brezillon wrote: > On Fri, 17 Apr 2015 10:33:56 +0200 Boris Brezillon > wrote: > > On Mon, 13 Apr 2015 20:11:46 + Jason Cooper > > wrote: > > > > > > > > > I'd appreciate if we'd look into it. I understand from on-list and > > >

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-17 Thread Boris Brezillon
On Fri, 17 Apr 2015 10:33:56 +0200 Boris Brezillon wrote: > Hi Jason, > > On Mon, 13 Apr 2015 20:11:46 + > Jason Cooper wrote: > > > > > > > > I'd appreciate if we'd look into it. I understand from on-list and > > > > off-list discussion that the rewrite was unavoidable. So I'm willing

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-17 Thread Boris Brezillon
Hi Jason, On Mon, 13 Apr 2015 20:11:46 + Jason Cooper wrote: > > > > > I'd appreciate if we'd look into it. I understand from on-list and > > > off-list discussion that the rewrite was unavoidable. So I'm willing to > > > concede that. Giving people time to migrate from old to new while

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-13 Thread Jason Cooper
Hey Arnaud, On Mon, Apr 13, 2015 at 06:06:49PM +0200, Arnaud Ebalard wrote: > Jason Cooper writes: ... > >> >> I really tried to adapt the existing driver to add the missing > >> >> features (especially the support for TDMA), but all my attempts > >> >> ended up introducing hackish code (not even

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-13 Thread Arnaud Ebalard
Hi Jason, Jason Cooper writes: > It's not about the crypto, it's about trust. imho, one of the most > important security advances in the past 20 years is the default use of > git (or other SCMs) by open source projects. Now, no one is forced to > trust the authors and maintainers tarball dumps

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-13 Thread Jason Cooper
Hey Gregory, On Mon, Apr 13, 2015 at 11:39:16AM +0200, Gregory CLEMENT wrote: > Hi Jason, Boris, > > On 11/04/2015 00:30, Jason Cooper wrote: > > Hey Boris, > > > > On Fri, Apr 10, 2015 at 05:11:48PM +0200, Boris Brezillon wrote: > >> On Fri, 10 Apr 2015 13:50:56 + Jason Cooper > >> wrote:

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-13 Thread Gregory CLEMENT
Hi Jason, Boris, On 11/04/2015 00:30, Jason Cooper wrote: > Hey Boris, > > On Fri, Apr 10, 2015 at 05:11:48PM +0200, Boris Brezillon wrote: >> On Fri, 10 Apr 2015 13:50:56 + Jason Cooper wrote: >>> On Thu, Apr 09, 2015 at 04:58:41PM +0200, Boris Brezillon wrote: I know we usually try to

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-10 Thread Jason Cooper
Hey Boris, On Fri, Apr 10, 2015 at 05:11:48PM +0200, Boris Brezillon wrote: > On Fri, 10 Apr 2015 13:50:56 + Jason Cooper wrote: > > On Thu, Apr 09, 2015 at 04:58:41PM +0200, Boris Brezillon wrote: > > > I know we usually try to adapt existing drivers instead of replacing them > > > by new on

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-09 Thread Boris Brezillon
Hi Sebastian, On Thu, 09 Apr 2015 17:34:29 +0200 Sebastian Hesselbarth wrote: > > if you include a bunch of performance measurements, I guess it will help > you to get an agreement of replacing the driver instead of reworking it. Yep, I made some measurements using tcrypt a while ago, I'll pro

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-09 Thread Stephan Mueller
Am Donnerstag, 9. April 2015, 16:58:41 schrieb Boris Brezillon: Hi Boris, >Hello, > >This is an attempt to replace the mv_cesa driver by a new one to address >some limitations of the existing driver. >From a performance and CPU load point of view the most important >limitation is the lack of DMA

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-09 Thread Sebastian Hesselbarth
On 09.04.2015 16:58, Boris Brezillon wrote: This is an attempt to replace the mv_cesa driver by a new one to address some limitations of the existing driver. From a performance and CPU load point of view the most important limitation is the lack of DMA support, thus preventing us from chaining c

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-09 Thread Andrew Lunn
On Thu, Apr 09, 2015 at 04:58:41PM +0200, Boris Brezillon wrote: > Hello, > > This is an attempt to replace the mv_cesa driver by a new one to address > some limitations of the existing driver. > >From a performance and CPU load point of view the most important > limitation is the lack of DMA supp

[PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-09 Thread Boris Brezillon
Hello, This is an attempt to replace the mv_cesa driver by a new one to address some limitations of the existing driver. >From a performance and CPU load point of view the most important limitation is the lack of DMA support, thus preventing us from chaining crypto operations. I know we usually t