Re: [PATCH 1/3] crypto: Fix the pointer voodoo in unaligned ahash

2014-03-02 Thread Marek Vasut
On Sunday, February 09, 2014 at 02:18:56 AM, Herbert Xu wrote: > On Tue, Jan 14, 2014 at 01:35:50PM -0600, Tom Lendacky wrote: > > On Tuesday, January 14, 2014 06:33:47 PM Marek Vasut wrote: > > > Add documentation for the pointer voodoo that is happening in > > > crypto/ahash.c in ahash_op_unalign

Re: [PATCH 1/3] crypto: Fix the pointer voodoo in unaligned ahash

2014-02-08 Thread Marek Vasut
On Sunday, February 09, 2014 at 02:18:56 AM, Herbert Xu wrote: > On Tue, Jan 14, 2014 at 01:35:50PM -0600, Tom Lendacky wrote: > > On Tuesday, January 14, 2014 06:33:47 PM Marek Vasut wrote: > > > Add documentation for the pointer voodoo that is happening in > > > crypto/ahash.c in ahash_op_unalign

Re: [PATCH 1/3] crypto: Fix the pointer voodoo in unaligned ahash

2014-02-08 Thread Herbert Xu
On Tue, Jan 14, 2014 at 01:35:50PM -0600, Tom Lendacky wrote: > > On Tuesday, January 14, 2014 06:33:47 PM Marek Vasut wrote: > > Add documentation for the pointer voodoo that is happening in crypto/ahash.c > > in ahash_op_unaligned(). This code is quite confusing, so add a beefy chunk > > of docu

Re: [PATCH 1/3] crypto: Fix the pointer voodoo in unaligned ahash

2014-01-14 Thread Tom Lendacky
On Tuesday, January 14, 2014 06:33:47 PM Marek Vasut wrote: > Add documentation for the pointer voodoo that is happening in crypto/ahash.c > in ahash_op_unaligned(). This code is quite confusing, so add a beefy chunk > of documentation. > > Moreover, make sure the mangled request is completely re

[PATCH 1/3] crypto: Fix the pointer voodoo in unaligned ahash

2014-01-14 Thread Marek Vasut
Add documentation for the pointer voodoo that is happening in crypto/ahash.c in ahash_op_unaligned(). This code is quite confusing, so add a beefy chunk of documentation. Moreover, make sure the mangled request is completely restored after finishing this unaligned operation. This means restoring a