Re: [PATCH 1/5] crypto: Fully restore ahash request before completing

2014-01-14 Thread Marek Vasut
On Monday, January 06, 2014 at 12:29:27 AM, Herbert Xu wrote: > On Sun, Jan 05, 2014 at 04:33:21PM +0100, Marek Vasut wrote: > > On Sunday, January 05, 2014 at 02:05:29 PM, Herbert Xu wrote: > > > On Tue, Dec 10, 2013 at 08:26:19PM +0100, Marek Vasut wrote: > > > > When finishing the ahash request,

Re: [PATCH 1/5] crypto: Fully restore ahash request before completing

2014-01-05 Thread Herbert Xu
On Sun, Jan 05, 2014 at 04:33:21PM +0100, Marek Vasut wrote: > On Sunday, January 05, 2014 at 02:05:29 PM, Herbert Xu wrote: > > On Tue, Dec 10, 2013 at 08:26:19PM +0100, Marek Vasut wrote: > > > When finishing the ahash request, the ahash_op_unaligned_done() will > > > call complete() on the reque

Re: [PATCH 1/5] crypto: Fully restore ahash request before completing

2014-01-05 Thread Marek Vasut
On Sunday, January 05, 2014 at 02:05:29 PM, Herbert Xu wrote: > On Tue, Dec 10, 2013 at 08:26:19PM +0100, Marek Vasut wrote: > > When finishing the ahash request, the ahash_op_unaligned_done() will > > call complete() on the request. Yet, this will not call the correct > > complete callback. The co

Re: [PATCH 1/5] crypto: Fully restore ahash request before completing

2014-01-05 Thread Herbert Xu
On Tue, Dec 10, 2013 at 08:26:19PM +0100, Marek Vasut wrote: > When finishing the ahash request, the ahash_op_unaligned_done() will > call complete() on the request. Yet, this will not call the correct > complete callback. The correct complete callback was previously stored > in the requests' priva

Re: [PATCH 1/5] crypto: Fully restore ahash request before completing

2014-01-04 Thread Marek Vasut
On Friday, January 03, 2014 at 11:33:44 PM, Herbert Xu wrote: > On Fri, Jan 03, 2014 at 09:10:30AM -0600, Tom Lendacky wrote: > > On Monday, December 30, 2013 05:01:13 PM Herbert Xu wrote: > > > On Fri, Dec 27, 2013 at 01:21:36AM +0100, Marek Vasut wrote: > > > > > > - complete(data, err); > > >

Re: [PATCH 1/5] crypto: Fully restore ahash request before completing

2014-01-03 Thread Herbert Xu
On Fri, Jan 03, 2014 at 09:10:30AM -0600, Tom Lendacky wrote: > On Monday, December 30, 2013 05:01:13 PM Herbert Xu wrote: > > On Fri, Dec 27, 2013 at 01:21:36AM +0100, Marek Vasut wrote: > > > > > > > > - complete(data, err); > > > > > + areq->base.complete = complete; > > > > > + areq

Re: [PATCH 1/5] crypto: Fully restore ahash request before completing

2014-01-03 Thread Tom Lendacky
On Monday, December 30, 2013 05:01:13 PM Herbert Xu wrote: > On Fri, Dec 27, 2013 at 01:21:36AM +0100, Marek Vasut wrote: > > > > > > - complete(data, err); > > > > + areq->base.complete = complete; > > > > + areq->base.data = data; > > > > + > > > > + complete(&areq->base,

Re: [PATCH 1/5] crypto: Fully restore ahash request before completing

2013-12-30 Thread Herbert Xu
On Fri, Dec 27, 2013 at 01:21:36AM +0100, Marek Vasut wrote: > > > > - complete(data, err); > > > + areq->base.complete = complete; > > > + areq->base.data = data; > > > + > > > + complete(&areq->base, err); > > > > This looks completely bogus. While restoring areq isn't wrong per > > se, calling

Re: [PATCH 1/5] crypto: Fully restore ahash request before completing

2013-12-26 Thread Marek Vasut
On Friday, December 20, 2013 at 01:04:08 PM, Herbert Xu wrote: > On Tue, Dec 10, 2013 at 08:26:19PM +0100, Marek Vasut wrote: > > When finishing the ahash request, the ahash_op_unaligned_done() will > > call complete() on the request. Yet, this will not call the correct > > complete callback. The c

Re: [PATCH 1/5] crypto: Fully restore ahash request before completing

2013-12-20 Thread Herbert Xu
On Tue, Dec 10, 2013 at 08:26:19PM +0100, Marek Vasut wrote: > When finishing the ahash request, the ahash_op_unaligned_done() will > call complete() on the request. Yet, this will not call the correct > complete callback. The correct complete callback was previously stored > in the requests' priva

[PATCH 1/5] crypto: Fully restore ahash request before completing

2013-12-10 Thread Marek Vasut
When finishing the ahash request, the ahash_op_unaligned_done() will call complete() on the request. Yet, this will not call the correct complete callback. The correct complete callback was previously stored in the requests' private data, as seen in ahash_op_unaligned(). This patch restores the cor

[PATCH 1/5] crypto: Fully restore ahash request before completing

2013-12-01 Thread Marek Vasut
When finishing the ahash request, the ahash_op_unaligned_done() will call complete() on the request. Yet, this will not call the correct complete callback. The correct complete callback was previously stored in the requests' private data, as seen in ahash_op_unaligned(). This patch restores the cor