Re: [PATCH 2/2] crypto: authenc - move saved IV in front of the ablkcipher request

2010-03-03 Thread Herbert Xu
On Wed, Mar 03, 2010 at 07:58:40AM +0100, Steffen Klassert wrote: > On Tue, Mar 02, 2010 at 10:10:49PM +0800, Herbert Xu wrote: > > > > Hmm, I just noticed that both before and after the patch we're > > only including the hash request size for the encrypt case, and > > not the givencrypt case. Is

Re: [PATCH 2/2] crypto: authenc - move saved IV in front of the ablkcipher request

2010-03-02 Thread Steffen Klassert
On Tue, Mar 02, 2010 at 10:10:49PM +0800, Herbert Xu wrote: > > Hmm, I just noticed that both before and after the patch we're > only including the hash request size for the encrypt case, and > not the givencrypt case. Is there a reason for this? > Hm, for the moment I don't see what's missing.

Re: [PATCH 2/2] crypto: authenc - move saved IV in front of the ablkcipher request

2010-03-02 Thread Herbert Xu
On Tue, Feb 23, 2010 at 07:22:37AM +0100, Steffen Klassert wrote: > > @@ -558,13 +556,18 @@ static int crypto_authenc_init_tfm(struct crypto_tfm > *tfm) > ctx->auth = auth; > ctx->enc = enc; > > - tfm->crt_aead.reqsize = max_t(unsigned int, > - crypto_

[PATCH 2/2] crypto: authenc - move saved IV in front of the ablkcipher request

2010-02-22 Thread Steffen Klassert
In crypto_authenc_encrypt() we save the IV behind the ablkcipher request. To save space on the request, we overwrite the ablkcipher request with a ahash request after encryption. So the IV may be overwritten by the ahash request. This patch fixes this by placing the IV in front of the ablkcipher/ah