Re: [PATCH 3/7] crypto: testmgr: fix warning

2009-11-11 Thread Herbert Xu
On Thu, Nov 12, 2009 at 02:32:10AM +0200, Felipe Contreras wrote: > On Mon, Oct 19, 2009 at 4:03 PM, Jarod Wilson wrote: > > So yeah, I rescind my claim that initializing err to 0 is incorrect, I think > > that's just fine. > > So is this acked? Who will merge it? It's already in cryptodev-2.6:

Re: [PATCH 3/7] crypto: testmgr: fix warning

2009-11-11 Thread Felipe Contreras
On Mon, Oct 19, 2009 at 4:03 PM, Jarod Wilson wrote: > So yeah, I rescind my claim that initializing err to 0 is incorrect, I think > that's just fine. So is this acked? Who will merge it? -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body

Re: [PATCH 3/7] crypto: testmgr: fix warning

2009-10-19 Thread Jarod Wilson
On 10/19/09 9:58 AM, Jarod Wilson wrote: On 10/19/09 9:52 AM, Jiri Kosina wrote: On Mon, 19 Oct 2009, Felipe Contreras wrote: crypto/testmgr.c: In function ?test_cprng?: crypto/testmgr.c:1204: warning: ?err? may be used uninitialized in this function Signed-off-by: Felipe Contreras --- crypto

Re: [PATCH 3/7] crypto: testmgr: fix warning

2009-10-19 Thread Jarod Wilson
On 10/19/09 9:52 AM, Jiri Kosina wrote: On Mon, 19 Oct 2009, Felipe Contreras wrote: crypto/testmgr.c: In function ?test_cprng?: crypto/testmgr.c:1204: warning: ?err? may be used uninitialized in this function Signed-off-by: Felipe Contreras --- crypto/testmgr.c |2 +- 1 files changed,

Re: [PATCH 3/7] crypto: testmgr: fix warning

2009-10-19 Thread Jiri Kosina
On Mon, 19 Oct 2009, Felipe Contreras wrote: > crypto/testmgr.c: In function ?test_cprng?: > crypto/testmgr.c:1204: warning: ?err? may be used uninitialized in this > function > > Signed-off-by: Felipe Contreras > --- > crypto/testmgr.c |2 +- > 1 files changed, 1 insertions(+), 1 deletion

[PATCH 3/7] crypto: testmgr: fix warning

2009-10-18 Thread Felipe Contreras
crypto/testmgr.c: In function ‘test_cprng’: crypto/testmgr.c:1204: warning: ‘err’ may be used uninitialized in this function Signed-off-by: Felipe Contreras --- crypto/testmgr.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/crypto/testmgr.c b/crypto/testmgr.c index 6d