Re: [PATCH 5/7] crypto: marvell: Adding a complete operation for async requests

2016-06-16 Thread Romain Perier
Hello, Le 15/06/2016 22:55, Boris Brezillon a écrit : + Nit: not sure you should mix this cosmetic change with the other changes. Ok You already have ivsize initialized. + memcpy_fromio(ablkreq->info, basereq->chain.last->data, ivsize); Use memcpy() here. good catch, f

Re: [PATCH 5/7] crypto: marvell: Adding a complete operation for async requests

2016-06-15 Thread Boris Brezillon
On Wed, 15 Jun 2016 21:15:32 +0200 Romain Perier wrote: > So far, the 'process' operation was used to check if the current request > was correctly handled by the engine, if it was the case it copied > information from the SRAM to the main memory. Now, we split this > operation. We keep the 'proce

[PATCH 5/7] crypto: marvell: Adding a complete operation for async requests

2016-06-15 Thread Romain Perier
So far, the 'process' operation was used to check if the current request was correctly handled by the engine, if it was the case it copied information from the SRAM to the main memory. Now, we split this operation. We keep the 'process' operation, which still checks if the request was correctly han