Re: [PATCH net-next v5 20/20] net: WireGuard secure network tunnel

2018-09-19 Thread Andrew Lunn
On Wed, Sep 19, 2018 at 04:04:01AM +0200, Jason A. Donenfeld wrote: > Hi Andrew, > > On Wed, Sep 19, 2018 at 1:34 AM Andrew Lunn wrote: > > I see this BUG_ON() is still here. It really needs to be removed. It > > does not look like you need to crash the kernel here. Can you add in a > > test of l

Re: [PATCH net-next v5 20/20] net: WireGuard secure network tunnel

2018-09-18 Thread Jason A. Donenfeld
Hi Andrew, On Wed, Sep 19, 2018 at 1:34 AM Andrew Lunn wrote: > I see this BUG_ON() is still here. It really needs to be removed. It > does not look like you need to crash the kernel here. Can you add in a > test of len >= 128, do a WARN and then return. I think you then leak > some memory, but i

Re: [PATCH net-next v5 20/20] net: WireGuard secure network tunnel

2018-09-18 Thread Andrew Lunn
> +#define push_rcu(stack, p, len) ({ > \ > + if (rcu_access_pointer(p)) { \ > + BUG_ON(len >= 128);\ > + stack[len++] = rcu_derefer