Re: [PATCH v2] crypto: AF_ALG - remove locking in async callback

2017-11-10 Thread Herbert Xu
On Tue, Nov 07, 2017 at 10:05:48AM +0100, Stephan Müller wrote: > > if (msg->msg_iocb && !is_sync_kiocb(msg->msg_iocb)) { > /* AIO operation */ > + sock_hold(sk); > areq->iocb = msg->msg_iocb; > aead_request_set_callback(&areq->cra_u.aea

[PATCH v2] crypto: AF_ALG - remove locking in async callback

2017-11-07 Thread Stephan Müller
The code paths protected by the socket-lock do not use or modify the socket in a non-atomic fashion. The actions pertaining the socket do not even need to be handled as an atomic operation. Thus, the socket-lock can be safely ignored. This fixes a bug regarding scheduling in atomic as the callback