On 01/07/2018 11:05 PM, Herbert Xu wrote:
On Fri, Jan 05, 2018 at 11:28:23AM -0600, Gary R Hook wrote:
It may not have been obvious from the title but this fixes a bug
which will impact the use of any HW RNG that is the only RNG
registered. The breakage of rmmod/modprobe -r that this fix obviat
On Fri, Jan 05, 2018 at 11:28:23AM -0600, Gary R Hook wrote:
>
> It may not have been obvious from the title but this fixes a bug
> which will impact the use of any HW RNG that is the only RNG
> registered. The breakage of rmmod/modprobe -r that this fix obviates
> suggests that it needs to make t
On 12/15/2017 01:55 PM, Gary R Hook wrote:
Commit 142a27f0a731 added support for a "best" RNG, and in doing so
introduced a hang from rmmod/modprobe -r when the last RNG on the list
was unloaded.
When the hwrng list is depleted, return the global variables to their
original state and decrement a
On Fri, Dec 15, 2017 at 01:55:59PM -0600, Gary R Hook wrote:
> Commit 142a27f0a731 added support for a "best" RNG, and in doing so
> introduced a hang from rmmod/modprobe -r when the last RNG on the list
> was unloaded.
>
> When the hwrng list is depleted, return the global variables to their
> or
On 12/17/2017 03:49 AM, PrasannaKumar Muralidharan wrote:
On 17 December 2017 at 14:53, PrasannaKumar Muralidharan
wrote:
Hi Gary,
Some minor comments below.
On 16 December 2017 at 01:25, Gary R Hook wrote:
Commit 142a27f0a731 added support for a "best" RNG, and in doing so
introduced a ha
On 17 December 2017 at 14:53, PrasannaKumar Muralidharan
wrote:
> Hi Gary,
>
> Some minor comments below.
>
> On 16 December 2017 at 01:25, Gary R Hook wrote:
>>
>> Commit 142a27f0a731 added support for a "best" RNG, and in doing so
>> introduced a hang from rmmod/modprobe -r when the last RNG on
Hi Gary,
Some minor comments below.
On 16 December 2017 at 01:25, Gary R Hook wrote:
>
> Commit 142a27f0a731 added support for a "best" RNG, and in doing so
> introduced a hang from rmmod/modprobe -r when the last RNG on the list
> was unloaded.
Nice catch. Thanks for fixing this.
> When the h
Commit 142a27f0a731 added support for a "best" RNG, and in doing so
introduced a hang from rmmod/modprobe -r when the last RNG on the list
was unloaded.
When the hwrng list is depleted, return the global variables to their
original state and decrement all references to the object.
Fixes: 142a27f0