Re: [PATCH v2 1/4] Crypto: Crypto driver support aes/des/des3 for rk3288

2015-11-08 Thread Zain
Hi Heiko, Thanks for your serious comments always. On 2015年11月08日 07:19, Heiko Stuebner wrote: > Hi Zain, > > looks like my comment on v1 came later than your v2 submission, > so here it is again :-) > > Am Freitag, 6. November 2015, 09:17:21 schrieb Zain Wang: >> The names registered are: >>

Re: [PATCH v2 1/4] Crypto: Crypto driver support aes/des/des3 for rk3288

2015-11-08 Thread Zain
On 2015年11月07日 12:40, Sandy Harris wrote: > On Thu, Nov 5, 2015 at 8:17 PM, Zain Wang wrote: >> The names registered are: >> ecb(aes) cbc(aes) ecb(des) cbc(des) ecb(des3_ede) cbc(des3_ede) >> You can alloc tags above in your case. > Why on Earth are you allowing

Re: [PATCH v2 1/4] Crypto: Crypto driver support aes/des/des3 for rk3288

2015-11-07 Thread Heiko Stuebner
Hi Zain, looks like my comment on v1 came later than your v2 submission, so here it is again :-) Am Freitag, 6. November 2015, 09:17:21 schrieb Zain Wang: > The names registered are: > ecb(aes) cbc(aes) ecb(des) cbc(des) ecb(des3_ede) cbc(des3_ede) > You can alloc tags above in your case. >

Re: [PATCH v2 1/4] Crypto: Crypto driver support aes/des/des3 for rk3288

2015-11-06 Thread Sandy Harris
On Thu, Nov 5, 2015 at 8:17 PM, Zain Wang wrote: > The names registered are: > ecb(aes) cbc(aes) ecb(des) cbc(des) ecb(des3_ede) cbc(des3_ede) > You can alloc tags above in your case. Why on Earth are you allowing DES? Here's a reference from around the turn of the

Re: [PATCH v2 1/4] Crypto: Crypto driver support aes/des/des3 for rk3288

2015-11-06 Thread Zain
Hi On 2015年11月06日 09:54, Caesar Wang wrote: > I guess the subject: > "crypto: rockchip: " > > Maybe better. ok! done! > > 在 2015年11月06日 09:17, Zain Wang 写道: >> The names registered are: >> ecb(aes) cbc(aes) ecb(des) cbc(des) ecb(des3_ede) cbc(des3_ede) >> You can alloc tags above in your

Re: [PATCH v2 1/4] Crypto: Crypto driver support aes/des/des3 for rk3288

2015-11-05 Thread Caesar Wang
I guess the subject: "crypto: rockchip: " Maybe better. 在 2015年11月06日 09:17, Zain Wang 写道: The names registered are: ecb(aes) cbc(aes) ecb(des) cbc(des) ecb(des3_ede) cbc(des3_ede) You can alloc tags above in your case. And other algorithms and platforms will be added later on.

[PATCH v2 1/4] Crypto: Crypto driver support aes/des/des3 for rk3288

2015-11-05 Thread Zain Wang
The names registered are: ecb(aes) cbc(aes) ecb(des) cbc(des) ecb(des3_ede) cbc(des3_ede) You can alloc tags above in your case. And other algorithms and platforms will be added later on. Signed-off-by: Zain Wang --- Changed in v2: - remove some part about hash -