Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files (part 1)

2011-10-17 Thread Kasatkin, Dmitry
From Kernel Docbook Similar to functionEXPORT_SYMBOL()/function except that the symbols exported by functionEXPORT_SYMBOL_GPL()/function can only be seen by modules with a functionMODULE_LICENSE()/function that specifies a GPL compatible license. It implies that the function

Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files (part 1)

2011-10-17 Thread Kasatkin, Dmitry
On Mon, Oct 17, 2011 at 12:11 PM, Kasatkin, Dmitry dmitry.kasat...@intel.com wrote: From Kernel Docbook    Similar to functionEXPORT_SYMBOL()/function except that the    symbols exported by functionEXPORT_SYMBOL_GPL()/function can    only be seen by modules with a    

Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files (part 1)

2011-10-17 Thread David Howells
James Morris jmor...@namei.org wrote: +MPI mpi_alloc(unsigned nlimbs) +{ + MPI a; + + a = (MPI) kmalloc(sizeof *a, GFP_KERNEL); Generally, typedef structs are frowned upon in the kernel. I'd prefer to see this (and any others) changed to a normal type. In this case, however,

Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files (part 1)

2011-10-17 Thread Greg KH
On Mon, Oct 17, 2011 at 12:11:37PM +0300, Kasatkin, Dmitry wrote: From Kernel Docbook Similar to functionEXPORT_SYMBOL()/function except that the symbols exported by functionEXPORT_SYMBOL_GPL()/function can only be seen by modules with a functionMODULE_LICENSE()/function