Re: [PATCH v3 6/7] ppp: mppe: switch to RC4 library interface

2019-06-11 Thread Eric Biggers
On Tue, Jun 11, 2019 at 03:47:49PM +0200, Ard Biesheuvel wrote: > @@ -728,8 +660,7 @@ static struct compressor ppp_mppe = { > static int __init ppp_mppe_init(void) > { > int answer; > - if (!(crypto_has_skcipher("ecb(arc4)", 0, CRYPTO_ALG_ASYNC) && > - crypto_has_ahash("sha1",

[PATCH v3 6/7] ppp: mppe: switch to RC4 library interface

2019-06-11 Thread Ard Biesheuvel
The MPPE code uses the sync skcipher to invoke the ecb(arc4) skcipher, of which only a single generic C code implementation exists. This means that going through all the trouble of using scatterlists etc buys us very little, and we're better off just invoking the arc4 library directly. Note that t