Re: [PATCH v4 4/4] crypto: RSA padding algorithm

2015-11-26 Thread Herbert Xu
Andrew Zaborowski wrote: > > +struct crypto_template rsa_pkcs1pad_tmpl = { > + .name = "pkcs1pad", > + .create = pkcs1pad_create, > + .free = pkcs1pad_free, Please use inst->free instead (crypto/gcm.c is a good example). BTW the first two patches

[PATCH v4 4/4] crypto: RSA padding algorithm

2015-11-25 Thread Andrew Zaborowski
This patch adds PKCS#1 v1.5 standard RSA padding as a separate template. This way an RSA cipher with padding can be obtained by instantiating "pkcs1pad(rsa)". The reason for adding this is that RSA is almost never used without this padding (or OAEP) so it will be needed for either certificate