Re: [PATCH v7 4/9] crypto: acomp - add support for lzo via scomp

2016-09-26 Thread Herbert Xu
On Mon, Sep 26, 2016 at 06:27:04PM +0100, Giovanni Cabiddu wrote: > > I think the definition of the acomp interface already allows for this. > If the destination scatterlist inside the request is NULL, the > algorithm/driver can allocate pages of memory for the output buffers as > well as the scatt

Re: [PATCH v7 4/9] crypto: acomp - add support for lzo via scomp

2016-09-26 Thread Giovanni Cabiddu
On Fri, Sep 23, 2016 at 11:05:18PM +0800, Herbert Xu wrote: > When I said acomp layer I'm referring specifically to the algorithm > or driver. As to your last question it would be the caller's > responsibility to free that memory. > > The use-case is our oldest user, IPcomp. Most packets are 1500

Re: [PATCH v7 4/9] crypto: acomp - add support for lzo via scomp

2016-09-23 Thread Herbert Xu
On Thu, Sep 22, 2016 at 11:54:25PM +0100, Giovanni Cabiddu wrote: > > I think you may have misread my earlier message from June. What > > I'd like to see is for the acomp layer to allocate the output > > memory, rather than have it provided by the user as is the case > > with the current interface

Re: [PATCH v7 4/9] crypto: acomp - add support for lzo via scomp

2016-09-22 Thread Giovanni Cabiddu
On Thu, Sep 22, 2016 at 05:22:44PM +0800, Herbert Xu wrote: > I'm suggesting that we have just one set of buffers for all scomp > algorithms. After all, a CPU can only process one request at a > time. Makes sense. Implemented in v8. > Yes scomp should just be flat. A sync algorithm capable of pr

Re: [PATCH v7 4/9] crypto: acomp - add support for lzo via scomp

2016-09-22 Thread Herbert Xu
On Tue, Sep 20, 2016 at 12:51:40PM +0100, Giovanni Cabiddu wrote: > Hi Herbert, > > On Tue, Sep 20, 2016 at 05:26:18PM +0800, Herbert Xu wrote: > > Rather than duplicating the scratch buffer handling in every scomp > > algorithm, let's centralize this and put it into scomp.c. > Are you suggesting

Re: [PATCH v7 4/9] crypto: acomp - add support for lzo via scomp

2016-09-20 Thread Giovanni Cabiddu
Hi Herbert, apologies for the duplicate. The previous email didn't get delivered to the ML. On Tue, Sep 20, 2016 at 05:26:18PM +0800, Herbert Xu wrote: > Rather than duplicating the scratch buffer handling in every scomp > algorithm, let's centralize this and put it into scomp.c. Are you suggesti

Re: [PATCH v7 4/9] crypto: acomp - add support for lzo via scomp

2016-09-20 Thread Herbert Xu
On Tue, Sep 13, 2016 at 01:49:36PM +0100, Giovanni Cabiddu wrote: > > + lzo_src_scratches = crypto_scomp_alloc_scratches(LZO_SCRATCH_SIZE); > + if (!lzo_src_scratches) > + return -ENOMEM; Rather than duplicating the scratch buffer handling in every scomp algorithm, let's centra

[PATCH v7 4/9] crypto: acomp - add support for lzo via scomp

2016-09-13 Thread Giovanni Cabiddu
Add scomp backend for lzo compression algorithm Signed-off-by: Giovanni Cabiddu --- crypto/Kconfig |1 + crypto/lzo.c | 146 +++- 2 files changed, 134 insertions(+), 13 deletions(-) diff --git a/crypto/Kconfig b/crypto/Kconfig index f55