On Mon, Aug 31, 2009 at 03:58:16PM +1000, Herbert Xu wrote:
>
> In fact it was being instantiated, it was just getting killed
> immediately after completing its self-test :)
>
> Please let me know if this fixes it for you.
>
Yes, it fixes it. Thanks a lot!
So pcrypt would be ready to use from
On Wed, Aug 19, 2009 at 09:15:49AM +0200, Steffen Klassert wrote:
>
> Any ideas why it's not possible to instantiate pcrypt?
Sorry for the late response.
In fact it was being instantiated, it was just getting killed
immediately after completing its self-test :)
Please let me know if this fixes
On Mon, Jun 29, 2009 at 03:52:57PM +0200, Steffen Klassert wrote:
> On Mon, Jun 29, 2009 at 07:59:50PM +0800, Herbert Xu wrote:
> >
> > OK. Can you send me the patches you used against the current
> > cryptodev tree (I only just pushed so give it an hour or so)?
> > I'll see if I can reproduce it
On Mon, Jun 29, 2009 at 07:59:50PM +0800, Herbert Xu wrote:
>
> OK. Can you send me the patches you used against the current
> cryptodev tree (I only just pushed so give it an hour or so)?
> I'll see if I can reproduce it here.
>
I'll send the remaining two patches in reply to this mail.
The st
On Mon, Jun 29, 2009 at 01:04:10PM +0200, Steffen Klassert wrote:
>
> I applied your patch on top of the last pcrypt patchset, but
> unfortunately it does not change anything here.
>
> If I do
> modprobe tcrypt alg='pcrypt(authenc(hmac(sha1-generic),cbc(aes-generic)))'
> type=3
>
> it instantiat
On Thu, Jun 25, 2009 at 02:51:12PM +0800, Herbert Xu wrote:
>
> OK, the patch I just posted to the list should fix the problem.
>
> I was able to test it suing
>
> modprobe tcrypt alg='pcrypt(authenc(hmac(sha1-generic),cbc(aes-generic)))'
> type=3
>
I applied your patch on top of the last pcr
On Mon, Jun 08, 2009 at 08:45:18AM +0200, Steffen Klassert wrote:
>
> Yes, I will send the full patchset including the tcrypt changes to
> instantiate pcrypt.
OK, the patch I just posted to the list should fix the problem.
I was able to test it suing
modprobe tcrypt alg='pcrypt(authenc(hmac(sha1
On Mon, Jun 08, 2009 at 03:28:08PM +1000, Herbert Xu wrote:
> On Fri, Jun 05, 2009 at 11:34:30AM +0200, Steffen Klassert wrote:
> >
> > In pcrypt_alloc_instance() I do
> > inst->alg.cra_priority = alg->cra_priority + 100;
> >
> > So, in my case authenc has priority 2000 and pcrypt has priority 210
On Fri, Jun 05, 2009 at 11:34:30AM +0200, Steffen Klassert wrote:
>
> In pcrypt_alloc_instance() I do
> inst->alg.cra_priority = alg->cra_priority + 100;
>
> So, in my case authenc has priority 2000 and pcrypt has priority 2100.
> In this case pcrypt is not instantiated if I use %s for pcrypt as
>
On Fri, Jun 05, 2009 at 07:20:21PM +1000, Herbert Xu wrote:
> On Fri, Jun 05, 2009 at 11:20:30AM +0200, Steffen Klassert wrote:
> >
> > As it is, I can instantiate pcrypt if the priority of pcrypt is lower
> > than the priority of the underlying algorithm. If I do the priority
> > check in crypto_
On Wed, Jun 03, 2009 at 09:59:31PM +1000, Herbert Xu wrote:
>
> When pcrypt instantiates an algorithm, it should set cra_name to
> %s and cra_driver_name to pcrypt(%s). So as long as the pcrypt
> priority is higher than the underlying algorithm, it should all
> work.
>
As it is, I can instantia
On Fri, Jun 05, 2009 at 11:20:30AM +0200, Steffen Klassert wrote:
>
> As it is, I can instantiate pcrypt if the priority of pcrypt is lower
> than the priority of the underlying algorithm. If I do the priority
> check in crypto_alg_tested() the other way arround, I get it to work if
> pcrypt has a
On Wed, Jun 03, 2009 at 02:14:35PM +0200, Steffen Klassert wrote:
>
> Aha, ok I see. So I will see whether I can instantiate pcrypt
> with tcrypt as you suggested and drop the wrapper from the next
> patchset.
It should be straightforward as you just need to call crypto_has_alg.
Thanks,
--
Visit
On Wed, Jun 03, 2009 at 09:59:31PM +1000, Herbert Xu wrote:
>
> When pcrypt instantiates an algorithm, it should set cra_name to
> %s and cra_driver_name to pcrypt(%s). So as long as the pcrypt
> priority is higher than the underlying algorithm, it should all
> work.
>
> See for instance how cry
On Wed, Jun 03, 2009 at 01:23:53PM +0200, Steffen Klassert wrote:
> On Wed, Jun 03, 2009 at 07:40:50PM +1000, Herbert Xu wrote:
> >
> > I see. How about if we let tcrypt test algorithms by name, e.g.,
> > something like
> >
> > modprobe tcrypt alg='pcrypt(authenc(hmac(sha1),cbc(aes))'
> >
>
On Wed, Jun 03, 2009 at 07:40:50PM +1000, Herbert Xu wrote:
>
> I see. How about if we let tcrypt test algorithms by name, e.g.,
> something like
>
> modprobe tcrypt alg='pcrypt(authenc(hmac(sha1),cbc(aes))'
>
I'm not that sure whether this does what I want.
If pcrypt has cra_name = pcr
On Wed, Jun 03, 2009 at 11:32:16AM +0200, Steffen Klassert wrote:
>
> > So what I suggest is that you make pcrypt take a higher priority
> > for now, so that it always is the default once instantiated.
> > After all if you instantiate it then you probably want to use it
> > as the default.
>
> Yes
On Tue, Jun 02, 2009 at 07:28:15PM +1000, Herbert Xu wrote:
> On Tue, Jun 02, 2009 at 11:21:51AM +0200, Steffen Klassert wrote:
> >
> > The reason for the wrap work is to have a possibility to choose a
> > certain version of an algorithm as the system default. The advantage
> > e.g. for pcrypt is
On Tue, Jun 02, 2009 at 11:21:51AM +0200, Steffen Klassert wrote:
>
> The reason for the wrap work is to have a possibility to choose a
> certain version of an algorithm as the system default. The advantage
> e.g. for pcrypt is that we can turn over the whole system to pcrypt,
> or we can choose f
On Tue, Jun 02, 2009 at 01:50:41PM +1000, Herbert Xu wrote:
>
> Hmm, it seems that this patch is completely intertwined into the
> rest of the patches so we can't just kill it. Can you elaborate
> on the rationale behind this wrap work? I'm curious to find out
> what we gain by this over the much
On Wed, May 13, 2009 at 03:08:18PM +0200, Steffen Klassert wrote:
> This patch adds an interface to wrap aead algorithms with an
> arbitrary crypto template. This is useful to make a certain
> version of an aead algorithm the system default of that algorithm.
>
> Signed-off-by: Steffen Klassert
On Wed, May 13, 2009 at 03:08:18PM +0200, Steffen Klassert wrote:
> This patch adds an interface to wrap aead algorithms with an
> arbitrary crypto template. This is useful to make a certain
> version of an aead algorithm the system default of that algorithm.
>
> Signed-off-by: Steffen Klassert
This patch adds an interface to wrap aead algorithms with an
arbitrary crypto template. This is useful to make a certain
version of an aead algorithm the system default of that algorithm.
Signed-off-by: Steffen Klassert
---
crypto/aead.c | 286 ++
23 matches
Mail list logo
