Re: [RFC 1/7] crypto: Add GHASH digest algorithm for GCM

2009-06-18 Thread Huang Ying
On Thu, 2009-06-18 at 15:27 +0800, Sebastian Andrzej Siewior wrote: > * Huang Ying | 2009-06-18 10:08:27 [+0800]: > > >On Thu, 2009-06-18 at 04:04 +0800, Sebastian Andrzej Siewior wrote: > >> >+#include > >> >+#include > >> >+#include > >> >+#include > >> >+#include > >> >+#include > >> >+#i

Re: [RFC 1/7] crypto: Add GHASH digest algorithm for GCM

2009-06-18 Thread Sebastian Andrzej Siewior
* Huang Ying | 2009-06-18 10:08:27 [+0800]: >On Thu, 2009-06-18 at 04:04 +0800, Sebastian Andrzej Siewior wrote: >> >+#include >> >+#include >> >+#include >> >+#include >> >+#include >> >+#include >> >+#include >> Do you mind to sort them? > >Sorry, can you tell me what is the better order?

Re: [RFC 1/7] crypto: Add GHASH digest algorithm for GCM

2009-06-17 Thread Herbert Xu
On Thu, Jun 18, 2009 at 10:08:27AM +0800, Huang Ying wrote: > > > Unless I'm mistaken, this is called once on allocation and this ctx is > > allocated via kzalloc(). > > Yes. it is alloced via kzalloc. Can we just rely on this? Should we add > that assumption to somewhere such as document of comme

Re: [RFC 1/7] crypto: Add GHASH digest algorithm for GCM

2009-06-17 Thread Huang Ying
On Thu, 2009-06-18 at 04:04 +0800, Sebastian Andrzej Siewior wrote: > * Huang Ying | 2009-06-11 15:10:26 [+0800]: > > >GHASH is implemented as a shash algorithm. The actual implementation > >is copied from gcm.c. This makes it possible to add > >architecture/hardware accelerated GHASH implementati

Re: [RFC 1/7] crypto: Add GHASH digest algorithm for GCM

2009-06-17 Thread Sebastian Andrzej Siewior
* Huang Ying | 2009-06-11 15:10:26 [+0800]: >GHASH is implemented as a shash algorithm. The actual implementation >is copied from gcm.c. This makes it possible to add >architecture/hardware accelerated GHASH implementation. > >Signed-off-by: Huang Ying > >--- > crypto/Kconfig |7 + > c

[RFC 1/7] crypto: Add GHASH digest algorithm for GCM

2009-06-11 Thread Huang Ying
GHASH is implemented as a shash algorithm. The actual implementation is copied from gcm.c. This makes it possible to add architecture/hardware accelerated GHASH implementation. Signed-off-by: Huang Ying --- crypto/Kconfig |7 + crypto/Makefile|2 crypto/ghash-generic.c