Re: [RFC 7/7] crypto: Add PCLMULQDQ accelerated GHASH implementation

2009-07-06 Thread Steffen Klassert
On Tue, Jul 07, 2009 at 02:00:03PM +0800, Herbert Xu wrote: > > Sure, maybe I could take some of your code as is. My plan for > hmac is to first convert it to shash, then convert the users to > ahash, and finally convert hmac itself to ahash. > > This way we don't have to convert all the users a

Re: [RFC 7/7] crypto: Add PCLMULQDQ accelerated GHASH implementation

2009-07-06 Thread Herbert Xu
On Tue, Jul 07, 2009 at 08:00:15AM +0200, Steffen Klassert wrote: > > Just FYI, I have a ahash version of hmac. Actually I'm about to convert > the hmac users. I have not posted it so far because not all hmac users > are converted, but I can do so if you are interested. Sure, maybe I could take so

Re: [RFC 7/7] crypto: Add PCLMULQDQ accelerated GHASH implementation

2009-07-06 Thread Steffen Klassert
On Tue, Jul 07, 2009 at 12:03:41PM +0800, Herbert Xu wrote: > On Tue, Jul 07, 2009 at 12:02:32PM +0800, Herbert Xu wrote: > > > > Actually I'll do the remaining DIGEST algorithms right now because > > without them hmac can't be converted. > > Nevermind, there aren't any remaining DIGEST algorithms

Re: [RFC 7/7] crypto: Add PCLMULQDQ accelerated GHASH implementation

2009-07-06 Thread Huang Ying
On Tue, 2009-07-07 at 12:03 +0800, Herbert Xu wrote: > On Tue, Jul 07, 2009 at 12:02:32PM +0800, Herbert Xu wrote: > > > > Actually I'll do the remaining DIGEST algorithms right now because > > without them hmac can't be converted. > > Nevermind, there aren't any remaining DIGEST algorithms :) >

Re: [RFC 7/7] crypto: Add PCLMULQDQ accelerated GHASH implementation

2009-07-06 Thread Herbert Xu
On Tue, Jul 07, 2009 at 12:02:32PM +0800, Herbert Xu wrote: > > Actually I'll do the remaining DIGEST algorithms right now because > without them hmac can't be converted. Nevermind, there aren't any remaining DIGEST algorithms :) I'll get onto hmac. Cheers, -- Visit Openswan at http://www.opens

Re: [RFC 7/7] crypto: Add PCLMULQDQ accelerated GHASH implementation

2009-07-06 Thread Herbert Xu
On Tue, Jul 07, 2009 at 11:45:48AM +0800, Herbert Xu wrote: > > I'll try to get onto hmac today or tomorrow. But if you could > spend some time on the remaining DIGEST algorithms that would > very much be appreciated. Actually I'll do the remaining DIGEST algorithms right now because without the

Re: [RFC 7/7] crypto: Add PCLMULQDQ accelerated GHASH implementation

2009-07-06 Thread Herbert Xu
On Tue, Jul 07, 2009 at 11:31:52AM +0800, Huang Ying wrote: > > What's your plan to convert everything to shash? For 2.6.32? How about > the progress? What can I do to help? I've been busy with networking :) I'll try to get onto hmac today or tomorrow. But if you could spend some time on the rem

Re: [RFC 7/7] crypto: Add PCLMULQDQ accelerated GHASH implementation

2009-07-06 Thread Huang Ying
Hi, Herbert, On Sun, 2009-06-21 at 21:51 +0800, Herbert Xu wrote: > Huang Ying wrote: > > PCLMULQDQ is used to accelerate the most time-consuming part of GHASH, > > carry-less multiplication. More information about PCLMULQDQ can be > > found at: > > > > http://software.intel.com/en-us/articles/c

Re: [RFC 7/7] crypto: Add PCLMULQDQ accelerated GHASH implementation

2009-06-21 Thread Herbert Xu
Huang Ying wrote: > PCLMULQDQ is used to accelerate the most time-consuming part of GHASH, > carry-less multiplication. More information about PCLMULQDQ can be > found at: > > http://software.intel.com/en-us/articles/carry-less-multiplication-and-its-usage-for-computing-the-gcm-mode/ > > Because

[RFC 7/7] crypto: Add PCLMULQDQ accelerated GHASH implementation

2009-06-11 Thread Huang Ying
PCLMULQDQ is used to accelerate the most time-consuming part of GHASH, carry-less multiplication. More information about PCLMULQDQ can be found at: http://software.intel.com/en-us/articles/carry-less-multiplication-and-its-usage-for-computing-the-gcm-mode/ Because PCLMULQDQ changes XMM state, its