RE: [cryptodev:master 79/79] (.text+0x330de0): multiple definition of `ecdh_shared_secret'

2016-06-24 Thread Benedetto, Salvatore
inux-blueto...@vger.kernel.org > Subject: Re: [cryptodev:master 79/79] (.text+0x330de0): multiple definition > of `ecdh_shared_secret' > > On Fri, Jun 24, 2016 at 07:36:44AM +0100, Salvatore Benedetto wrote: > > > > > > The patch was based on the current tree. I just pulle

Re: [cryptodev:master 79/79] (.text+0x330de0): multiple definition of `ecdh_shared_secret'

2016-06-24 Thread Herbert Xu
On Fri, Jun 24, 2016 at 07:36:44AM +0100, Salvatore Benedetto wrote: > > > The patch was based on the current tree. I just pulled. > There is not point in moving to lib because bluetooth is > about to be converted to kpp. > That patch I believe will go up the bluetooth tree, so > my suggestion

Re: [cryptodev:master 79/79] (.text+0x330de0): multiple definition of `ecdh_shared_secret'

2016-06-24 Thread Salvatore Benedetto
On Fri, Jun 24, 2016 at 07:23:16AM +0100, Herbert Xu wrote: > On Fri, Jun 24, 2016 at 02:10:12PM +0800, Herbert Xu wrote: > > On Fri, Jun 24, 2016 at 07:06:49AM +0100, Salvatore Benedetto wrote: > > > > > > can you squash the following patch? > > > > No, please prune anything that we don't use

Re: [cryptodev:master 79/79] (.text+0x330de0): multiple definition of `ecdh_shared_secret'

2016-06-24 Thread Herbert Xu
On Fri, Jun 24, 2016 at 07:23:42AM +0100, Salvatore Benedetto wrote: > > We do use the symbol in question, and I'm pretty sure we use > all of crypto/ecc.c. I was going to send a patch where > I remove the net/bluetooth/ecc.c I see. In that case either rename the symbols in net/bluetooth/ecc.c

Re: [cryptodev:master 79/79] (.text+0x330de0): multiple definition of `ecdh_shared_secret'

2016-06-24 Thread Salvatore Benedetto
On Fri, Jun 24, 2016 at 02:10:12PM +0800, Herbert Xu wrote: > On Fri, Jun 24, 2016 at 07:06:49AM +0100, Salvatore Benedetto wrote: > > > > can you squash the following patch? > > No, please prune anything that we don't use from ecc.c. We do use the symbol in question, and I'm pretty sure we use

Re: [cryptodev:master 79/79] (.text+0x330de0): multiple definition of `ecdh_shared_secret'

2016-06-24 Thread Herbert Xu
On Fri, Jun 24, 2016 at 02:10:12PM +0800, Herbert Xu wrote: > On Fri, Jun 24, 2016 at 07:06:49AM +0100, Salvatore Benedetto wrote: > > > > can you squash the following patch? > > No, please prune anything that we don't use from ecc.c. I take that back. I see it's actually coming from bluetooth.

Re: [cryptodev:master 79/79] (.text+0x330de0): multiple definition of `ecdh_shared_secret'

2016-06-24 Thread Herbert Xu
On Fri, Jun 24, 2016 at 07:06:49AM +0100, Salvatore Benedetto wrote: > > can you squash the following patch? No, please prune anything that we don't use from ecc.c. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key:

Re: [cryptodev:master 79/79] (.text+0x330de0): multiple definition of `ecdh_shared_secret'

2016-06-24 Thread Salvatore Benedetto
On Fri, Jun 24, 2016 at 03:47:04AM +0800, kbuild test robot wrote: > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git > master > head: 3c4b23901a0c766879dff680cd6bdab47bcdbbd2 > commit: 3c4b23901a0c766879dff680cd6bdab47bcdbbd2 [79/79] crypto: ecdh - Add >

[cryptodev:master 79/79] (.text+0x330de0): multiple definition of `ecdh_shared_secret'

2016-06-23 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 3c4b23901a0c766879dff680cd6bdab47bcdbbd2 commit: 3c4b23901a0c766879dff680cd6bdab47bcdbbd2 [79/79] crypto: ecdh - Add ECDH software support config: i386-allyesconfig (attached as .config) compiler: