Re: [v2 PATCH 6/8] crypto: caam - Convert GCM to new AEAD interface

2015-06-18 Thread Herbert Xu
On Thu, Jun 18, 2015 at 02:18:21PM +0300, Horia Geantă wrote: > > To make sure, I've tried this case on HW (with modified tcrypt tests): > > caam_jr ffe301000.jr: 4000101c: DECO: desc idx 16: DECO Watchdog timer > timeout error > alg: aead: encryption failed on test 1 for rfc4106-gcm-aes-caam: > r

Re: [v2 PATCH 6/8] crypto: caam - Convert GCM to new AEAD interface

2015-06-18 Thread Horia Geantă
On 6/18/2015 9:17 AM, Herbert Xu wrote: >>> +static void init_gcm_job(struct aead_request *req, >>> +struct aead_edesc *edesc, >>> +bool all_contig, bool encrypt) >>> +{ >>> + struct crypto_aead *aead = crypto_aead_reqtfm(req); >>> + struct caam_ctx *ctx

Re: [v2 PATCH 6/8] crypto: caam - Convert GCM to new AEAD interface

2015-06-17 Thread Herbert Xu
On Wed, Jun 17, 2015 at 08:02:30PM +0300, Horia Geantă wrote: > > > > -#define DESC_MAX_USED_BYTES(DESC_RFC4543_GIVENC_LEN + \ > > -CAAM_MAX_KEY_SIZE) > > -#define DESC_MAX_USED_LEN (DESC_MAX_USED_BYTES / CAAM_CMD_SZ) > > +#define DESC_

Re: [v2 PATCH 6/8] crypto: caam - Convert GCM to new AEAD interface

2015-06-17 Thread Horia Geantă
On 6/16/2015 8:54 AM, Herbert Xu wrote: > This patch converts the caam GCM implementations to the new AEAD > interface. This is compile-tested only. > > Note that all IV generation for GCM algorithms have been removed. > The reason is that the current generation uses purely random IVs > which is

[v2 PATCH 6/8] crypto: caam - Convert GCM to new AEAD interface

2015-06-15 Thread Herbert Xu
This patch converts the caam GCM implementations to the new AEAD interface. This is compile-tested only. Note that all IV generation for GCM algorithms have been removed. The reason is that the current generation uses purely random IVs which is not appropriate for counter-based algorithms where w