Re: [v3 PATCH] crypto: aesni - Convert rfc4106 to new AEAD interface

2015-06-01 Thread Herbert Xu
On Mon, Jun 01, 2015 at 11:04:39AM +0200, Stephan Mueller wrote: Just FYI: when testing rfc4106(gcm(aes-aesni)) with the old givcipher API, I got a crash in my code invoking the cipher which used to work in older kernels and which works with the C implementations. So, there must be some

Re: [v3 PATCH] crypto: aesni - Convert rfc4106 to new AEAD interface

2015-06-01 Thread Herbert Xu
On Mon, Jun 01, 2015 at 11:44:22AM +0200, Stephan Mueller wrote: That code crashes with the following stacktrace: [ 2000.433502] BUG: unable to handle kernel NULL pointer dereference at (null) This crash is totally different from the previous crash you sent. This one is

Re: [v3 PATCH] crypto: aesni - Convert rfc4106 to new AEAD interface

2015-06-01 Thread Stephan Mueller
Am Montag, 1. Juni 2015, 15:53:06 schrieb Herbert Xu: Hi Herbert, On Mon, Jun 01, 2015 at 03:50:22PM +0800, Herbert Xu wrote: This patch converts the low-level __gcm-aes-aesni algorithm to the new AEAD interface. Oops, I missed two more spots. That patch fixes the crash. Thanks Just FYI:

Re: [v3 PATCH] crypto: aesni - Convert rfc4106 to new AEAD interface

2015-06-01 Thread Stephan Mueller
Am Montag, 1. Juni 2015, 17:09:51 schrieb Herbert Xu: Hi Herbert, On Mon, Jun 01, 2015 at 11:04:39AM +0200, Stephan Mueller wrote: Just FYI: when testing rfc4106(gcm(aes-aesni)) with the old givcipher API, I got a crash in my code invoking the cipher which used to work in older kernels

[v3 PATCH] crypto: aesni - Convert rfc4106 to new AEAD interface

2015-06-01 Thread Herbert Xu
On Mon, Jun 01, 2015 at 03:50:22PM +0800, Herbert Xu wrote: This patch converts the low-level __gcm-aes-aesni algorithm to the new AEAD interface. Oops, I missed two more spots. ---8--- This patch converts the low-level __gcm-aes-aesni algorithm to the new AEAD interface. Signed-off-by:

Re: [v3 PATCH] crypto: aesni - Convert rfc4106 to new AEAD interface

2015-06-01 Thread Stephan Mueller
Am Montag, 1. Juni 2015, 17:52:45 schrieb Herbert Xu: Hi Herbert, On Mon, Jun 01, 2015 at 11:44:22AM +0200, Stephan Mueller wrote: That code crashes with the following stacktrace: [ 2000.433502] BUG: unable to handle kernel NULL pointer dereference at (null) This crash is totally