On Thu, Nov 12, 2009 at 01:18:53PM +0300, Sergey Mironov wrote:
>
> Here is similar patch for aes_s390:
It doesn't apply either:
$ git apply ~/p
patch: malformed patch at line 75: *tfm, const u8 *in_key,
$
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~}
On Thu, Nov 12, 2009 at 08:36:42AM +, Sergey Mironov wrote:
>
> Hi. Ok, here is geode-patch
Your patch is corrupted:
$ git apply ~/p
patch: malformed patch at line 51: *tfm, const u8 *key,
$
Please resend.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>
>From 335b39e0c55a1dba13cda3e8222947f2cb4120ed Mon Sep 17 00:00:00 2001
>From: Sergey Mironov
>Date: Thu, 12 Nov 2009 13:10:05 +0300
>Subject: [PATCH 2/2] aes_s390: access fallback.cip cipher fallback mode
>
>|The fallback code in cipher mode touch the union fallback.blk instead
>|of fallback.cip.
2009/11/12 Sebastian Andrzej Siewior :
> >From 0a61b446585324a3041ef0a138515ef936a14eb7 Mon Sep 17 00:00:00 2001
>>From: Sergey Mironov
>>Date: Thu, 12 Nov 2009 11:30:02 +0300
>>Subject: [PATCH] Fixed typo bugs in geod-aes.c
>
> On a second look could you please add something like:
>
> crypto/geod
>From 0a61b446585324a3041ef0a138515ef936a14eb7 Mon Sep 17 00:00:00 2001
>From: Sergey Mironov
>Date: Thu, 12 Nov 2009 11:30:02 +0300
>Subject: [PATCH] Fixed typo bugs in geod-aes.c
On a second look could you please add something like:
crypto/geode: access fallback.cip cipher fallback mode
|The
* Sergey Mironov | 2009-11-12 11:43:20 [+0300]:
>I can't find any "s390" reference in my tree. Probably, i have not got
>this branch in my local copy.
If you want to fix this please look at arch/s390/crypto/aes_s390.c. That
is broken and I mixed it up in fallback_init_cip() as well :)
Sebastian
* Sergey Mironov | 2009-11-12 11:36:42 [+0300]:
>From 0a61b446585324a3041ef0a138515ef936a14eb7 Mon Sep 17 00:00:00 2001
>From: Sergey Mironov
>Date: Thu, 12 Nov 2009 11:30:02 +0300
>Subject: [PATCH] Fixed typo bugs in geod-aes.c
>
>
>Signed-off-by: Sergey Mironov
Acked-by: Sebastian Andrzej Siew
2009/11/12 Sergey Mironov :
> 2009/11/12 Sebastian Andrzej Siewior :
>> * Sergey Mironov | 2009-11-10 17:00:31 [+0300]:
>>
>>> 116 static int geode_setkey_cip(struct crypto_tfm *tfm, const u8 *key,
>>> 117 unsigned int len)
>>> 118 {
>>>...
>>>
>>>/** BUG? Should it be 'op->fallback
2009/11/12 Sebastian Andrzej Siewior :
> * Sergey Mironov | 2009-11-10 17:00:31 [+0300]:
>
>> 116 static int geode_setkey_cip(struct crypto_tfm *tfm, const u8 *key,
>> 117 unsigned int len)
>> 118 {
>>...
>>
>>/** BUG? Should it be 'op->fallback.cip' instead of 'op->fallback.blk' ?
* Sergey Mironov | 2009-11-10 17:00:31 [+0300]:
> 116 static int geode_setkey_cip(struct crypto_tfm *tfm, const u8 *key,
> 117 unsigned int len)
> 118 {
>...
>
>/** BUG? Should it be 'op->fallback.cip' instead of 'op->fallback.blk' ? **/
>
> 138 op->fallback.blk->base.crt_
Hello. I noticed strange thing in drivers/crypto/geode-aes.c (
function geode_setkey_cip() )
This code still the same in git://linux-arm.org/linux-2.6-stable.git
(tag v2.6.28-arm2)
Please, check.
116 static int geode_setkey_cip(struct crypto_tfm *tfm, const u8 *key,
117 unsign
11 matches
Mail list logo
