On Fri, Aug 6, 2010 at 1:06 AM, Olivier Galibert wrote:
>
> Maybe Linus would be happier if the self-tests were limited (by
> default) to the hardware accelerators? Having a software backup and
> the risk of data loss indeed makes things different.
No. I'd be happier if it was an OPTION.
And it
On Fri, Aug 06, 2010 at 04:39:00PM +0800, Herbert Xu
(herb...@gondor.apana.org.au) wrote:
> So you'd rather have a box that doesn't boot rather than one
> that automatically falls back to software crypto allowing you
> to diagnose and report the problem.
What about kernel boot parameter to test h
Olivier Galibert wrote:
>
> Of course in practice without the tests your boot would probably just
> have failed. Badly-decrypted root partitions tend to be noticed as
> such long before trying to write to them. Then you would have bitched
> on the list and the driver would have been fixed or rem
On Fri, Aug 06, 2010 at 12:50:04AM -0400, Kyle Moffett wrote:
> You should also realize that crypto drivers are very much *NOT* in the
> same situation as most other drivers. Without this test, adding a new
> crypto hardware driver to the kernel is a completely unsafe operation,
> because it could
On Fri, Aug 6, 2010 at 00:20, Linus Torvalds
wrote:
> On Thu, Aug 5, 2010 at 7:35 PM, Herbert Xu
> wrote:
>> Because it can save data. Each cryptographic algorithm (such as
>> AES) may have multiple impelmentations, some of which are hardware-
>> based.
>
> Umm. The _developer_ had better test
On Thu, Aug 5, 2010 at 7:35 PM, Herbert Xu wrote:
>
> Because it can save data. Each cryptographic algorithm (such as
> AES) may have multiple impelmentations, some of which are hardware-
> based.
Umm. The _developer_ had better test the thing. That is absolutely
_zero_ excuse for then forcing e
On Thu, Aug 05, 2010 at 07:01:21PM -0700, Linus Torvalds wrote:
> On Thu, Aug 5, 2010 at 6:40 PM, Herbert Xu
> wrote:
> >
> > -config CRYPTO_MANAGER_TESTS
> > - bool "Run algolithms' self-tests"
> > - default y
> > - depends on CRYPTO_MANAGER2
> > +config CRYPTO_MANAGER_DISABLE_
On Thu, Aug 5, 2010 at 7:23 PM, David Howells wrote:
>
> I wonder if tty_init() should be moved up, perhaps to immediately after
> chrdev_init().
I do think that sounds sane. The tty layer is kind of special.
I wouldn't call it _after_ chrdev_init(), though, I'd call it _from_
chrdev_init(). Doe
Herbert Xu wrote:
> This patch should do the trick:
>
> commit 326a6346ffb5b19eb593530d9d3096d409e46f62
> Author: Herbert Xu
> Date: Fri Aug 6 09:40:28 2010 +0800
>
> crypto: testmgr - Fix test disabling option
It does work.
David
--
To unsubscribe from this list: send the line "unsubs
Linus Torvalds wrote:
> People always think that their magical code is so important. I tell
> you up-front that is absolutely is not. Just remove the crap entirely,
> please.
Even if he does remove it, that still leaves the problem that modprobe can be
invoked and fail before tty_init() gets cal
On Thu, Aug 5, 2010 at 6:40 PM, Herbert Xu wrote:
>
> -config CRYPTO_MANAGER_TESTS
> - bool "Run algolithms' self-tests"
> - default y
> - depends on CRYPTO_MANAGER2
> +config CRYPTO_MANAGER_DISABLE_TESTS
> + bool "Disable run-time self tests"
> + depends on CRYPTO_MA
On Fri, Aug 06, 2010 at 09:17:06AM +0800, Herbert Xu wrote:
> On Fri, Aug 06, 2010 at 02:01:03AM +0100, David Howells wrote:
> >
> > but it's not being found by the crypto routines. By GIT bisection, I note
> > that this problem is introduced in the following commit:
> >
> > commit 0b767f961
On Fri, Aug 06, 2010 at 02:01:03AM +0100, David Howells wrote:
>
> but it's not being found by the crypto routines. By GIT bisection, I note
> that this problem is introduced in the following commit:
>
> commit 0b767f96164b2b27488e3daa722ff16e89d49314
> Author: Alexander Shishkin
>
13 matches
Mail list logo
