RE: Key endianness?

2019-10-21 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Monday, October 21, 2019 9:47 PM > To: Pascal Van Leeuwen > Cc: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.au > Subject: Re: Key endianness? > > On Mon, 21 Oct 2019 at 21:14, Pas

Re: Key endianness?

2019-10-21 Thread Ard Biesheuvel
On Mon, 21 Oct 2019 at 21:14, Pascal Van Leeuwen wrote: > > > -Original Message- > > From: Ard Biesheuvel > > Sent: Monday, October 21, 2019 6:15 PM > > To: Pascal Van Leeuwen > > Cc: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.au > >

RE: Key endianness?

2019-10-21 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Monday, October 21, 2019 6:15 PM > To: Pascal Van Leeuwen > Cc: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.au > Subject: Re: Key endianness? > > On Mon, 21 Oct 2019 at 17:55, Pas

Re: Key endianness?

2019-10-21 Thread Ard Biesheuvel
On Mon, 21 Oct 2019 at 17:55, Pascal Van Leeuwen wrote: > > > -Original Message- > > From: Ard Biesheuvel > > Sent: Monday, October 21, 2019 5:32 PM > > To: Pascal Van Leeuwen > > Cc: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.au > >

RE: Key endianness?

2019-10-21 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Monday, October 21, 2019 5:32 PM > To: Pascal Van Leeuwen > Cc: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.au > Subject: Re: Key endianness? > > p[ > > On Mon, 21 Oct 2019 at 17:2

Re: Key endianness?

2019-10-21 Thread Ard Biesheuvel
p[ On Mon, 21 Oct 2019 at 17:23, Pascal Van Leeuwen wrote: > > > -Original Message- > > From: Ard Biesheuvel > > Sent: Monday, October 21, 2019 2:54 PM > > To: Pascal Van Leeuwen > > Cc: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.a

RE: Key endianness?

2019-10-21 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Monday, October 21, 2019 2:54 PM > To: Pascal Van Leeuwen > Cc: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.au > Subject: Re: Key endianness? > > On Mon, 21 Oct 2019 at 14:40, Pas

Re: Key endianness?

2019-10-21 Thread Ard Biesheuvel
On Mon, 21 Oct 2019 at 14:40, Pascal Van Leeuwen wrote: > > > -Original Message- > > From: Ard Biesheuvel > > Sent: Monday, October 21, 2019 1:59 PM > > To: Pascal Van Leeuwen > > Cc: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.au > >

RE: Key endianness?

2019-10-21 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Monday, October 21, 2019 1:59 PM > To: Pascal Van Leeuwen > Cc: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.au > Subject: Re: Key endianness? > > On Mon, 21 Oct 2019 at 12:56, Pascal Van Leeuwen &

RE: Key endianness?

2019-10-21 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Monday, October 21, 2019 2:12 PM > To: Pascal Van Leeuwen > Cc: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.au > Subject: Re: Key endianness? > > On Mon, 21 Oct 2019 at 14:08, Pascal Van Leeuwen &

Re: Key endianness?

2019-10-21 Thread Ard Biesheuvel
Regards, > Pascal van Leeuwen > Silicon IP Architect, Multi-Protocol Engines @ Verimatrix > www.insidesecure.com > > > -Original Message- > > From: linux-crypto-ow...@vger.kernel.org > > On Behalf Of > > Pascal Van Leeuwen > > Sent: Monday, Octobe

RE: Key endianness?

2019-10-21 Thread Pascal Van Leeuwen
licon IP Architect, Multi-Protocol Engines @ Verimatrix www.insidesecure.com > -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf Of > Pascal Van Leeuwen > Sent: Monday, October 21, 2019 12:56 PM > To: linux-crypto@vger.kernel.org; herb...@g

Re: Key endianness?

2019-10-21 Thread Ard Biesheuvel
; Regards, > Pascal van Leeuwen > Silicon IP Architect, Multi-Protocol Engines @ Verimatrix > www.insidesecure.com > > > -Original Message- > > From: Pascal Van Leeuwen > > Sent: Monday, October 21, 2019 11:04 AM > > To: linux-crypto@vger.kernel.org; herb

RE: Key endianness?

2019-10-21 Thread Pascal Van Leeuwen
uwen Silicon IP Architect, Multi-Protocol Engines @ Verimatrix www.insidesecure.com > -Original Message- > From: Pascal Van Leeuwen > Sent: Monday, October 21, 2019 11:04 AM > To: linux-crypto@vger.kernel.org; herb...@gondor.apana.org.au > Subject: Key endianness? > >

Key endianness?

2019-10-21 Thread Pascal Van Leeuwen
Herbert, I'm currently busy fixing some endianness related sparse errors reported by this kbuild test robot and this triggered my to rethink some endian conversion being done in the inside-secure driver. I actually wonder what the endianness is of the input key data, e.g. the "u8 *key" parameter

[PATCH resend 08/18] crypto: arm64/aes-ce-cipher - match round key endianness with generic code

2017-07-24 Thread Ard Biesheuvel
In order to be able to reuse the generic AES code as a fallback for situations where the NEON may not be used, update the key handling to match the byte order of the generic code: it stores round keys as sequences of 32-bit quantities rather than streams of bytes, and so our code needs to be update

[PATCH 07/12] crypto: arm64/aes-ce-cipher - match round key endianness with generic code

2017-06-10 Thread Ard Biesheuvel
In order to be able to reuse the generic AES code as a fallback for situations where the NEON may not be used, update the key handling to match the byte order of the generic code: it stores round keys as sequences of 32-bit quantities rather than streams of bytes, and so our code needs to be update