Re: virtio:rng: Virtio RNG devices need to be re-registered after suspend/resume

2017-11-06 Thread Herbert Xu
On Tue, Nov 07, 2017 at 08:44:17AM +0530, PrasannaKumar Muralidharan wrote: > Hi Herbert, > > On 6 November 2017 at 12:39, Herbert Xu wrote: > > On Fri, Nov 03, 2017 at 09:57:21AM +, Jim Quigley wrote: > >> moved the call to hwrng_register() out of the probe routine into the scan > >> routine

Re: virtio:rng: Virtio RNG devices need to be re-registered after suspend/resume

2017-11-06 Thread PrasannaKumar Muralidharan
Hi Herbert, On 6 November 2017 at 12:39, Herbert Xu wrote: > On Fri, Nov 03, 2017 at 09:57:21AM +, Jim Quigley wrote: >> moved the call to hwrng_register() out of the probe routine into the scan >> routine. We need to call hwrng_register() after a suspend/restore cycle >> to re-register the d

Re: virtio:rng: Virtio RNG devices need to be re-registered after suspend/resume

2017-11-05 Thread Herbert Xu
On Fri, Nov 03, 2017 at 09:57:21AM +, Jim Quigley wrote: > The patch for > > commit: 5c06273401f2eb7b290cadbae18ee00f8f65e893 > Author: Amit Shah > Date: Sun Jul 27 07:34:01 2014 +0930 > > virtio: rng: delay hwrng_register() till driver is ready > > moved the call to hwrng_register()

Re: virtio:rng: Virtio RNG devices need to be re-registered after suspend/resume

2017-11-03 Thread PrasannaKumar Muralidharan
Jim, Minor comment below. On 3 November 2017 at 15:27, Jim Quigley wrote: > The patch for > > commit: 5c06273401f2eb7b290cadbae18ee00f8f65e893 > Author: Amit Shah > Date: Sun Jul 27 07:34:01 2014 +0930 > > virtio: rng: delay hwrng_register() till driver is ready > > moved the call to hwrn

Re: virtio:rng: Virtio RNG devices need to be re-registered after suspend/resume

2017-11-03 Thread PrasannaKumar Muralidharan
Hi Jim, Have second thoughts on this. On 3 November 2017 at 20:55, PrasannaKumar Muralidharan wrote: >> >> It would be cleaner to just get rid of probe_common() altogether in that >> case, and do whatever >> needs to be done in virtrng_probe()/virtrng_restore() respectively, but > > That

Re: virtio:rng: Virtio RNG devices need to be re-registered after suspend/resume

2017-11-03 Thread Jim Quigley
On 03/11/2017 13:06, PrasannaKumar Muralidharan wrote: Hi Jim, On 3 November 2017 at 15:27, Jim Quigley wrote: The patch for commit: 5c06273401f2eb7b290cadbae18ee00f8f65e893 Author: Amit Shah Date: Sun Jul 27 07:34:01 2014 +0930 virtio: rng: delay hwrng_register() till driver is re

Re: virtio:rng: Virtio RNG devices need to be re-registered after suspend/resume

2017-11-03 Thread PrasannaKumar Muralidharan
Hi Jim, On 3 November 2017 at 15:27, Jim Quigley wrote: > The patch for > > commit: 5c06273401f2eb7b290cadbae18ee00f8f65e893 > Author: Amit Shah > Date: Sun Jul 27 07:34:01 2014 +0930 > > virtio: rng: delay hwrng_register() till driver is ready > > moved the call to hwrng_register() out of