Re: crypto: run initcalls for generic implementations earlier

2019-05-21 Thread Eric Biggers
Refname:refs/heads/master > > Web: > > https://git.kernel.org/torvalds/c/c4741b23059794bd99beef0f700103b0d983b3fd > > Author: Eric Biggers > > AuthorDate: Thu Apr 11 21:57:42 2019 -0700 > > Committer: Herbert Xu > > CommitDate: Thu Apr 18

Re: crypto: run initcalls for generic implementations earlier

2019-05-21 Thread Geert Uytterhoeven
.org/torvalds/c/c4741b23059794bd99beef0f700103b0d983b3fd > Author: Eric Biggers > AuthorDate: Thu Apr 11 21:57:42 2019 -0700 > Committer: Herbert Xu > CommitDate: Thu Apr 18 22:15:03 2019 +0800 > > crypto: run initcalls for generic implementations earlier > > Use subsys_initcall for re

[PATCH v2 7/7] crypto: run initcalls for generic implementations earlier

2019-04-11 Thread Eric Biggers
From: Eric Biggers Use subsys_initcall for registration of all templates and generic algorithm implementations, rather than module_init. Then change cryptomgr to use arch_initcall, to place it before the subsys_initcalls. This is needed so that when both a generic and optimized implementation o

Re: [RFC/RFT PATCH 18/18] crypto: run initcalls for generic implementations earlier

2019-04-10 Thread Herbert Xu
On Tue, Apr 09, 2019 at 11:16:09AM -0700, Eric Biggers wrote: > > All modules are already loaded, but there's no "adiantum(xchacha12,aes)" > algorithm directly available so it has be instantiated using the template. > > Then with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y, the self-tests for the > accele

Re: [RFC/RFT PATCH 18/18] crypto: run initcalls for generic implementations earlier

2019-04-09 Thread Eric Biggers
Hi Herbert, On Tue, Apr 09, 2019 at 02:24:09PM +0800, Herbert Xu wrote: > > > BTW, I found another problem caused by allocating the generic implementation > > during the self-tests, which is that the generic implementation will > > fulfill any > > outstanding allocation requests before the other

Re: [RFC/RFT PATCH 18/18] crypto: run initcalls for generic implementations earlier

2019-04-08 Thread Herbert Xu
On Mon, Apr 08, 2019 at 10:44:02AM -0700, Eric Biggers wrote: > > My patch also moved cryptomgr earlier in the Makefile, so it's linked first. > Do > you think that's too fragile? Otherwise, I'll probably change > cryptomgr_init() > to arch_initcall(). I don't think we should rely on link-tim

Re: [RFC/RFT PATCH 18/18] crypto: run initcalls for generic implementations earlier

2019-04-08 Thread Eric Biggers
On Mon, Apr 08, 2019 at 01:53:22PM +0800, Herbert Xu wrote: > Hi Eric: > > Eric Biggers wrote: > > From: Eric Biggers > > > > Use subsys_initcall for registration of all templates and generic > > algorithm implementations, rather than module_init. > > I think this is fine except that algboss a

Re: [RFC/RFT PATCH 18/18] crypto: run initcalls for generic implementations earlier

2019-04-07 Thread Herbert Xu
Hi Eric: Eric Biggers wrote: > From: Eric Biggers > > Use subsys_initcall for registration of all templates and generic > algorithm implementations, rather than module_init. I think this is fine except that algboss already hooks in at subsys_initcall and either it needs to move further up or w

[RFC/RFT PATCH 18/18] crypto: run initcalls for generic implementations earlier

2019-03-31 Thread Eric Biggers
From: Eric Biggers Use subsys_initcall for registration of all templates and generic algorithm implementations, rather than module_init. This is needed so that when both a generic and optimized implementation of an algorithm are built into the kernel (not loadable modules), the generic implement