Re: tcrypt: hmac test with keys > blocksize fail

2008-05-14 Thread Sebastian Siewior
* Herbert Xu | 2008-05-06 18:28:15 [+0800]: >Actually this just exposed an ancient bug in hmac. It relied >on the key to be in identity-mapped memory which has never been >guaranteed. huh. Thanks Herbert. I haven't seen this on 32bit machine. >Thanks, Sebastian -- To unsubscribe from this list

Re: tcrypt: hmac test with keys > blocksize fail

2008-05-06 Thread Adrian-Ken Rüegsegger
Herbert Xu wrote: > Actually this just exposed an ancient bug in hmac. It relied on the key to be in identity-mapped memory which has never been guaranteed. This patch fixes the problem for me. I have tested the patch and it resolves the issue indeed. It also let's the same RIPEMD hmac test

Re: tcrypt: hmac test with keys > blocksize fail

2008-05-06 Thread Herbert Xu
Adrian-Ken R??egsegger <[EMAIL PROTECTED]> wrote: > > using the cryptodev-2.6 tree I noticed that the hmac tests that have > keys larger than blocksize for md5 and the various sha algorithms all > fail (tcrypt mode=10[0-5]). The other tests seem to pass just fine. > > The issue seems to have come

Re: tcrypt: hmac test with keys > blocksize fail

2008-05-04 Thread Sebastian Siewior
* Adrian-Ken R?egsegger | 2008-05-03 13:44:41 [+0200]: >Sebastian Siewior wrote: >Hello Sebastian, Hello, >Additionaly I just saw, that ecb(des) encryption test nr 5 passes but it >seems that the setkey operation fails with: > >setkey() failed flags=100100 That is okey, that one has to fail. The

Re: tcrypt: hmac test with keys > blocksize fail

2008-05-03 Thread Adrian-Ken Rüegsegger
Sebastian Siewior wrote: > * Adrian-Ken R?egsegger | 2008-05-03 02:10:34 [+0200]: > >> Hi, > Hi Adrian-Ken, Hello Sebastian, >> using the cryptodev-2.6 tree I noticed that the hmac tests that have >> keys larger than blocksize for md5 and the various sha algorithms all >> fail (tcrypt mode=10[0

Re: tcrypt: hmac test with keys > blocksize fail

2008-05-02 Thread Sebastian Siewior
* Adrian-Ken R?egsegger | 2008-05-03 02:10:34 [+0200]: >Hi, Hi Adrian-Ken, >using the cryptodev-2.6 tree I noticed that the hmac tests that have >keys larger than blocksize for md5 and the various sha algorithms all >fail (tcrypt mode=10[0-5]). The other tests seem to pass just fine. > >The issue

tcrypt: hmac test with keys > blocksize fail

2008-05-02 Thread Adrian-Ken Rüegsegger
Hi, using the cryptodev-2.6 tree I noticed that the hmac tests that have keys larger than blocksize for md5 and the various sha algorithms all fail (tcrypt mode=10[0-5]). The other tests seem to pass just fine. The issue seems to have come from commit de224c309b5631bdaae3fcd6880cfb93b52f5a53. I