Re: un4i-ss-cipher.c warning

2015-08-20 Thread Herbert Xu
On Thu, Aug 20, 2015 at 03:56:39PM +0200, Corentin LABBE wrote: > > Thanks for the report, strange that I do not have that warning. > todo is always initialized, since oleft and ileft are always > 0 at start. > But setting todo to 0 is a simple fix. > The following patch will suppress the warning.

Re: un4i-ss-cipher.c warning

2015-08-20 Thread Corentin LABBE
On 19/08/2015 16:35, Michal Suchanek wrote: Hello, when building a kernel with sunxi crypto driver as merged into the sinxi-wip branch I get a compiler warning. I am not sure this is the latest version of the driver. It does not seem to be in mainline yet. Thanks Michal In file included from

Re: un4i-ss-cipher.c warning

2015-08-19 Thread Herbert Xu
On Thu, Aug 20, 2015 at 08:39:00AM +0200, Maxime Ripard wrote: > > Not in the dev_dbg call line 258. If ileft was negative or null, todo > isn't assigned to anything. If ileft starts out being <= 0, then oleft == ileft will also be <= 0, in which case the loop never executes. Cheers, -- Email: H

Re: un4i-ss-cipher.c warning

2015-08-19 Thread Maxime Ripard
On Thu, Aug 20, 2015 at 01:29:03PM +0800, Herbert Xu wrote: > On Wed, Aug 19, 2015 at 04:35:36PM +0200, Michal Suchanek wrote: > > Hello, > > > > when building a kernel with sunxi crypto driver as merged into the > > sinxi-wip branch I get a compiler warning. > > > > I am not sure this is the lat

Re: un4i-ss-cipher.c warning

2015-08-19 Thread Herbert Xu
On Wed, Aug 19, 2015 at 04:35:36PM +0200, Michal Suchanek wrote: > Hello, > > when building a kernel with sunxi crypto driver as merged into the > sinxi-wip branch I get a compiler warning. > > I am not sure this is the latest version of the driver. It does not > seem to be in mainline yet. The

un4i-ss-cipher.c warning

2015-08-19 Thread Michal Suchanek
Hello, when building a kernel with sunxi crypto driver as merged into the sinxi-wip branch I get a compiler warning. I am not sure this is the latest version of the driver. It does not seem to be in mainline yet. Thanks Michal In file included from /scratch/build/linux/include/linux/printk.h:2