Hi,

>> Thu, 25 Oct 2007 12:45:04 +0100
>> [Subject: [PATCH 1/5] camellia: cleanup]
>> Denys Vlasenko <[EMAIL PROTECTED]> wrote...

> On Thursday 25 October 2007 12:43, Denys Vlasenko wrote:
> > Hi Hervert,
> > 
> > Please review and maybe propagate upstream following patches.
> > 
> > camellia1.diff:
> >     Move code blocks around so that related pieces are closer together:
> >     e.g. CAMELLIA_ROUNDSM macro does not need to be separated
> >     from the rest of the code by huge array of constants.
> > 
> >     Remove unused macros (COPY4WORD, SWAP4WORD, XOR4WORD[2])
> > 
> >     Drop SUBL(), SUBR() macros which only obscure things.
> >     Same for CAMELLIA_SP1110() macro and KEY_TABLE_TYPE typedef.
> > 
> >     Remove useless comments:
> >     /* encryption */ -- well it's obvious enough already!
> >     void camellia_encrypt128(...)
> > 
> >     Combine swap with copying at the beginning/end of encrypt/decrypt.
> 
> Signed-off-by: Denys Vlasenko <[EMAIL PROTECTED]>

Acked-by: Noriaki TAKAMIYA <[EMAIL PROTECTED]>

--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to