Re: [PATCH 3/3] thermal: max77620: Add thermal driver for reporting junction temp

2016-03-08 Thread Eduardo Valentin
Hello Laxman, Thanks for working on this. Impressed how simplified these drivers are becoming. I really liked you added the so waited devm_ helpers. Very minor comments as follows (now that you will send a new version anyway). On Fri, Mar 04, 2016 at 07:10:10PM +0530, Laxman Dewangan wrote: >

Re: [PATCH v2] sparc64: Add support for Application Data Integrity (ADI)

2016-03-08 Thread Khalid Aziz
On 03/08/2016 01:27 PM, David Miller wrote: From: Khalid Aziz Date: Tue, 8 Mar 2016 13:16:11 -0700 On 03/08/2016 12:57 PM, David Miller wrote: From: Khalid Aziz Date: Mon, 7 Mar 2016 14:06:43 -0700 Good questions. Isn't set of valid VAs

Re: [PATCH v2] sparc64: Add support for Application Data Integrity (ADI)

2016-03-08 Thread David Miller
From: Khalid Aziz Date: Tue, 8 Mar 2016 13:16:11 -0700 > On 03/08/2016 12:57 PM, David Miller wrote: >> From: Khalid Aziz >> Date: Mon, 7 Mar 2016 14:06:43 -0700 >> >>> Good questions. Isn't set of valid VAs already constrained by VA_BITS >>> (set

Re: [PATCH v2] sparc64: Add support for Application Data Integrity (ADI)

2016-03-08 Thread Khalid Aziz
On 03/08/2016 12:57 PM, David Miller wrote: From: Khalid Aziz Date: Mon, 7 Mar 2016 14:06:43 -0700 Good questions. Isn't set of valid VAs already constrained by VA_BITS (set to 44 in arch/sparc/include/asm/processor_64.h)? As I see it we are already not using the top 4

Re: [PATCHv2] fat: add config option to set UTF-8 mount option by default

2016-03-08 Thread OGAWA Hirofumi
"Maciej S. Szmigiero" writes: > FAT has long supported its own default file name encoding > config setting, separate from CONFIG_NLS_DEFAULT. > > However, if UTF-8 encoded file names are desired FAT > character set should not be set to utf8 since this would > make

Re: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-08 Thread Oliver Hartkopp
On 03/08/2016 01:48 PM, Ramesh Shanmugasundaram wrote: >> In fact you provided a CAN driver which is "CAN-FD-only". > > Yes. That's the status of current submission. > >> We did not had that before but there's a solution for this kind of setup. >> >> There is a similar case with

Re: [PATCHv2 11/11] ARM: dts: Add Altera Arria10 L2 Cache EDAC devicetree entry

2016-03-08 Thread Thor Thayer
Hi Dinh, On 03/08/2016 08:50 AM, Dinh Nguyen wrote: On 03/07/2016 01:43 PM, ttha...@opensource.altera.com wrote: From: Thor Thayer Add the device tree entries needed to support the Altera L2 cache EDAC on the Arria10 chip. Signed-off-by: Thor Thayer

Re: [PATCHv2 07/11] EDAC, altera: Add status offset & masks

2016-03-08 Thread Thor Thayer
Hi Boris, On 03/07/2016 01:43 PM, ttha...@opensource.altera.com wrote: From: Thor Thayer In preparation for the Arria10 peripheral ECCs, the IRQ status needs to be determined because the IRQs are shared. The IRQ status register is read to determine if the IRQ

Re: Kernel docs: muddying the waters a bit

2016-03-08 Thread Mauro Carvalho Chehab
Em Tue, 8 Mar 2016 10:39:22 -0300 Mauro Carvalho Chehab escreveu: > Em Tue, 08 Mar 2016 05:13:13 -0700 > Dan Allen escreveu: > > > On Tue, Mar 8, 2016 at 4:29 AM, Mauro Carvalho Chehab < > > mche...@osg.samsung.com> wrote: > > > > > pandoc

Re: [PATCHv2 10/11] ARM: socfpga: Enable Arria10 L2 cache ECC on startup

2016-03-08 Thread Dinh Nguyen
On 03/07/2016 01:43 PM, ttha...@opensource.altera.com wrote: > From: Thor Thayer > > Enable ECC for Arria10 L2 cache on machine startup. The ECC has to be > enabled before data is stored in memory otherwise the ECC will fail > on reads. > Use DT_MACHINE to select

Re: Kernel docs: muddying the waters a bit

2016-03-08 Thread Jani Nikula
On Tue, 08 Mar 2016, Dan Allen wrote: > That's not entirely true. First, you can pre-split at the source level > using includes and generate output for each of the masters. That's what I > tend to do and it works really well since these are logical split points. I need to

[PATCHv2] fat: add config option to set UTF-8 mount option by default

2016-03-08 Thread Maciej S. Szmigiero
FAT has long supported its own default file name encoding config setting, separate from CONFIG_NLS_DEFAULT. However, if UTF-8 encoded file names are desired FAT character set should not be set to utf8 since this would make file names case sensitive even if case insensitive matching is requested.

Re: Kernel docs: muddying the waters a bit

2016-03-08 Thread Mauro Carvalho Chehab
Em Tue, 08 Mar 2016 05:13:13 -0700 Dan Allen escreveu: > On Tue, Mar 8, 2016 at 4:29 AM, Mauro Carvalho Chehab < > mche...@osg.samsung.com> wrote: > > > pandoc did a really crap job on the conversion. To convert this > > into something useful, we'll need to spend a lot of

Re: Kernel docs: muddying the waters a bit

2016-03-08 Thread Mauro Carvalho Chehab
Em Tue, 08 Mar 2016 05:09:40 -0700 Dan Allen escreveu: > Jani wrote: > > > there was no support for chunked, or split > > to chapters, HTML, and the single page result was simply way too big. > > > > That's not entirely true. First, you can pre-split at the source level >

RE: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-08 Thread Ramesh Shanmugasundaram
Hi Oliver, Thanks for the comments. > On 08.03.2016 09:57, Ramesh Shanmugasundaram wrote: > > > > > As you mentioned further down, when a user does this > > > > "ip link set can0 up type can bitrate 100" > > > > the intention is to put the controller in CAN 2.0 mode. Even if we use a >

Re: Kernel docs: muddying the waters a bit

2016-03-08 Thread Mauro Carvalho Chehab
Em Tue, 08 Mar 2016 11:49:35 +0200 Jani Nikula escreveu: > On Tue, 08 Mar 2016, Dan Allen wrote: > > One of the key goals of the Asciidoctor project is to be able to directly > > produce a wide variety of outputs from the same source (without DocBook).

Re: Kernel docs: muddying the waters a bit

2016-03-08 Thread Jani Nikula
On Tue, 08 Mar 2016, Dan Allen wrote: > One of the key goals of the Asciidoctor project is to be able to directly > produce a wide variety of outputs from the same source (without DocBook). > We've added flexibility and best practices into the syntax and matured the >

Re: [PATCH v2] sparc64: Add support for Application Data Integrity (ADI)

2016-03-08 Thread James Morris
On 03/08/2016 10:48 AM, James Morris wrote: On 03/08/2016 06:54 AM, Andy Lutomirski wrote: This makes sense, but I still think the design is poor. If the hacker gets code execution, then they can trivially brute force the ADI bits. ADI in this scenario is intended to prevent the attacker

RE: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-08 Thread Ramesh Shanmugasundaram
Hi Oliver, Thanks for the comments. > On 03/07/2016 09:32 AM, Ramesh Shanmugasundaram wrote: > > > + /* Ensure channel starts in FD mode */ > > + if (!(priv->can.ctrlmode & CAN_CTRLMODE_FD)) { > > + netdev_err(ndev, "enable can fd mode for channel %d\n", >