Re: [PATCH 2/3] leds: add debugfs to device trigger

2016-03-22 Thread Pavel Machek
On Mon 2015-09-28 22:43:04, Maciek Borzecki wrote: > Add debugfs entries for device activity trigger. Three entries are > created under /sys/kernel/debug/ledtrig-dev when the driver gets > loaded. These are: > > devices - cat'ing will produce a list of currently registered devices >

Re: [v8,09/10] tpm: Initialize TPM and get durations and timeouts

2016-03-22 Thread Stefan Berger
On 03/22/2016 02:34 AM, Jarkko Sakkinen wrote: On Sun, Mar 13, 2016 at 06:54:39PM -0400, Stefan Berger wrote: Add the retrieval of TPM 1.2 durations and timeouts. Since this requires the startup of the TPM, do this for TPM 1.2 and TPM 2. Signed-off-by: Stefan Berger CC: linux-ker...@vger.kerne

[PATCH] Syntactic and factual errors in the API document

2016-03-22 Thread Andy Champ
There are several places where the English in the document is syntactically invalid, or unclear. There are also one or two factual errors. --- Documentation/thermal/sysfs-api.txt | 44 ++--- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/Documentat

RE: [PATCH] Syntactic and factual errors in the API document

2016-03-22 Thread R, Durgadoss
>-Original Message- >From: Andy Champ [mailto:andyc...@amazon.com] >Sent: Tuesday, March 22, 2016 6:07 PM >To: edubez...@gmail.com >Cc: cor...@lwn.net; javi.mer...@arm.com; R, Durgadoss ; >leo@linaro.org; kapileshwar.si...@arm.com; w...@nvidia.com; >linux-doc@vger.kernel.org; linux- >k

Re: [PATCH] Syntactic and factual errors in the API document

2016-03-22 Thread Javi Merino
Hi Andy, Thanks for improving the documentation! One minor nit below. Other than that, you can add my reviewed-by. On Tue, Mar 22, 2016 at 12:37:25PM +, Andy Champ wrote: > There are several places where the English in the document is syntactically > invalid, or unclear. There are also one

RE: [PATCH] Syntactic and factual errors in the API document

2016-03-22 Thread Champ, Andy
>> Not sure about this one. It's good that it uses the same language as >> set_cur_state. What's the problem with "Current throttle state"? It's a cooling device, typically a fan. If I set it to 5000RPM, but it's stuck and not going round at all, the API only allows me to ask what I set it to

Re: [PATCH] Syntactic and factual errors in the API document

2016-03-22 Thread Eduardo Valentin
Hello Andy, On Tue, Mar 22, 2016 at 12:37:25PM +, Andy Champ wrote: > There are several places where the English in the document is syntactically > invalid, or unclear. There are also one or two factual errors. > > --- > Documentation/thermal/sysfs-api.txt | 44 > ++-

Re: module: preserve Elf information for livepatch modules

2016-03-22 Thread Jessica Yu
+++ Josh Poimboeuf [21/03/16 09:06 -0500]: On Wed, Mar 16, 2016 at 03:47:04PM -0400, Jessica Yu wrote: For livepatch modules, copy Elf section, symbol, and string information from the load_info struct in the module loader. Persist copies of the original symbol table and string table. Livepatch

Re: module: preserve Elf information for livepatch modules

2016-03-22 Thread Josh Poimboeuf
On Tue, Mar 22, 2016 at 01:57:01PM -0400, Jessica Yu wrote: > +++ Josh Poimboeuf [21/03/16 09:06 -0500]: > >On Wed, Mar 16, 2016 at 03:47:04PM -0400, Jessica Yu wrote: > >>For livepatch modules, copy Elf section, symbol, and string information > >>from the load_info struct in the module loader. Per

Re: livepatch: reuse module loader code to write relocations

2016-03-22 Thread Jessica Yu
+++ Jiri Kosina [21/03/16 23:02 +0100]: On Mon, 21 Mar 2016, Josh Poimboeuf wrote: According to my test that still results in the literal value of "(64 - 8)". Alright. But we should be able to special-case it with a two #if checks on the __SIZEOF_LONG__ value and BUILD_BUG_ON() when __SIZEOF_

[PATCH v6 0/5] (mostly) Arch-independent livepatch

2016-03-22 Thread Jessica Yu
This patchset removes livepatch's need for architecture-specific relocation code by leveraging existing code in the module loader to perform arch-dependent work. Specifically, instead of duplicating code and re-implementing what the apply_relocate_add() function in the module loader already does in

[PATCH v6 1/5] Elf: add livepatch-specific Elf constants

2016-03-22 Thread Jessica Yu
Livepatch manages its own relocation sections and symbols in order to be able to reuse module loader code to write relocations. This removes livepatch's dependence on separate "dynrela" sections to write relocations and also allows livepatch to patch modules that are not yet loaded. The livepatch

[PATCH v6 4/5] livepatch: reuse module loader code to write relocations

2016-03-22 Thread Jessica Yu
Reuse module loader code to write relocations, thereby eliminating the need for architecture specific relocation code in livepatch. Specifically, reuse the apply_relocate_add() function in the module loader to write relocations instead of duplicating functionality in livepatch's arch-dependent klp_

[PATCH v6 3/5] module: s390: keep mod_arch_specific for livepatch modules

2016-03-22 Thread Jessica Yu
Livepatch needs to utilize the symbol information contained in the mod_arch_specific struct in order to be able to call the s390 apply_relocate_add() function to apply relocations. Keep a reference to syminfo if the module is a livepatch module. Remove the redundant vfree() in module_finalize() sin

[PATCH v6 2/5] module: preserve Elf information for livepatch modules

2016-03-22 Thread Jessica Yu
For livepatch modules, copy Elf section, symbol, and string information from the load_info struct in the module loader. Persist copies of the original symbol table and string table. Livepatch manages its own relocation sections in order to reuse module loader code to write relocations. Livepatch m

[PATCH v6 5/5] Documentation: livepatch: outline Elf format and requirements for patch modules

2016-03-22 Thread Jessica Yu
Document livepatch module requirements and the special Elf constants patch modules use. Signed-off-by: Jessica Yu Acked-by: Miroslav Benes --- Documentation/livepatch/module-elf-format.txt | 311 ++ 1 file changed, 311 insertions(+) create mode 100644 Documentation/live