Re: Clarification for source code formatting around jump labels

2016-09-04 Thread Daniel Borkmann
On 09/04/2016 03:50 PM, SF Markus Elfring wrote: I am just curious on how much further software development "fun" the recent update by a topic like "CodingStyle: Clarify and complete chapter 7" will trigger. I don't want to drag this thread onwards for (way) too long, but clearly "it is

Re: Clarification for source code formatting around jump labels

2016-09-04 Thread SF Markus Elfring
>> I am just curious on how much further software development "fun" the recent >> update >> by a topic like "CodingStyle: Clarify and complete chapter 7" will trigger. > > I don't want to drag this thread onwards for (way) too long, but clearly "it > is > advised to indent labels with a single

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

2016-09-04 Thread Daniel Borkmann
On 09/04/2016 09:20 AM, SF Markus Elfring wrote: https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?id=865a1caa4b6b886babdd9d67e7c3608be4567a51 [ + Jonathan for above commit in linux-next ] You seem to lack understanding of the difference

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

2016-09-04 Thread SF Markus Elfring
> It's not because I find improvements "uncomfortable", but rather it's > because your changes are not seen as improvements in the first place. What is your software development opinion for the update step "[1/4] sparc: bpf_jit: Use kmalloc_array() in bpf_jit_compile()" from this small patch

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

2016-09-04 Thread SF Markus Elfring
>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?id=865a1caa4b6b886babdd9d67e7c3608be4567a51 > > You seem to lack understanding of the difference between absolute > requirements and "advice". > > As Sparc maintainer I can choose to not take

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

2016-09-04 Thread David Miller
From: SF Markus Elfring Date: Sun, 4 Sep 2016 09:20:55 +0200 > I guess that I will stumble on more software improvement opportunities > you find harder to become comfortable with. Improvement is a matter of opinion. So your statement assumes that your changes are

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

2016-09-04 Thread David Miller
From: SF Markus Elfring Date: Sun, 4 Sep 2016 08:50:20 +0200 >>> NAK, just noise. >> >> And frankly I hate that leading space. > > Would you like to comment the recent update of the document "CodingStyle" any > more? >

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

2016-09-04 Thread SF Markus Elfring
>> NAK, just noise. > > And frankly I hate that leading space. Would you like to comment the recent update of the document "CodingStyle" any more? https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?id=865a1caa4b6b886babdd9d67e7c3608be4567a51