Re: [PATCH v2 2/2] devicetree: Document the max31760 device binding.

2017-04-19 Thread Rob Herring
On Tue, Apr 11, 2017 at 02:32:18PM -0700, John Muir wrote: > v2: > - Fixup based on comments. While you should have a commit msg here, the patch versioning goes below the '---'. This history is not too useful either. You should describe what you changed so reviewers don't have to go find the

Re: [PATCH v13 03/10] mux: minimal mux subsystem and gpio-based mux controller

2017-04-19 Thread Peter Rosin
On 2017-04-19 15:49, Philipp Zabel wrote: > On Wed, 2017-04-19 at 14:00 +0200, Peter Rosin wrote: > [...] +int mux_control_select(struct mux_control *mux, int state) >>> >>> If we let two of these race, ... >> >> The window for this "race" is positively huge. If there are several >> mux

[PATCH] docs: process/4.Coding.rst: Re-flow a couple of paragraphs

2017-04-19 Thread Andrew Clayton
In Documentation/process/4.Coding.rst there were a couple of paragraphs that spilled over the 80 character line length. This brings them back in line with the rest of the document. Signed-off-by: Andrew Clayton --- Documentation/process/4.Coding.rst | 14

Re: [PATCH v6 2/8] doc: Add documentation for Coresight CPU debug

2017-04-19 Thread Mathieu Poirier
On 6 April 2017 at 07:30, Leo Yan wrote: > Update kernel-parameters.txt to add new parameter: > coresight_cpu_debug.enable is a knob to enable debugging at boot time. > > Add detailed documentation, which contains the implementation, Mike > Leach excellent summary for "clock

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

2017-04-19 Thread Mathieu Poirier
On 19 April 2017 at 09:30, Leo Yan wrote: > On Wed, Apr 19, 2017 at 08:52:12AM -0600, Mathieu Poirier wrote: > > [...] > >> >> > +static bool debug_enable; >> >> > +module_param_named(enable, debug_enable, bool, 0600); >> >> > +MODULE_PARM_DESC(enable, "Knob to enable debug

Re: [PATCH v13 02/10] dt-bindings: document devicetree bindings for mux-controllers and gpio-mux

2017-04-19 Thread Philipp Zabel
On Wed, 2017-04-19 at 13:23 +0200, Peter Rosin wrote: > On 2017-04-19 13:05, Philipp Zabel wrote: > > On Wed, 2017-04-19 at 12:41 +0200, Peter Rosin wrote: > >> On 2017-04-19 11:17, Philipp Zabel wrote: > >>> On Tue, 2017-04-18 at 15:36 +0200, Peter Rosin wrote: > If I got things wrong when I

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

2017-04-19 Thread Leo Yan
On Wed, Apr 19, 2017 at 08:52:12AM -0600, Mathieu Poirier wrote: [...] > >> > +static bool debug_enable; > >> > +module_param_named(enable, debug_enable, bool, 0600); > >> > +MODULE_PARM_DESC(enable, "Knob to enable debug functionality " > >> > +"(default is 0, which means is

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

2017-04-19 Thread Leo Yan
On Wed, Apr 19, 2017 at 03:32:39PM +0100, Suzuki K Poulose wrote: [...] > >>>+static int debug_probe(struct amba_device *adev, const struct amba_id *id) > >>>+{ > >>>+ void __iomem *base; > >>>+ struct device *dev = >dev; > >>>+ struct debug_drvdata *drvdata; > >>>+ struct resource *res =

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

2017-04-19 Thread Suzuki K Poulose
On 19/04/17 15:28, Leo Yan wrote: Hi Suzuki, On Wed, Apr 19, 2017 at 02:23:04PM +0100, Suzuki K Poulose wrote: Hi Leo, This version looks good to me. I have two minor comments below. Thanks for reviewing. Will take the suggestions. Just check a bit for last comment. [...] +static int

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

2017-04-19 Thread Leo Yan
Hi Suzuki, On Wed, Apr 19, 2017 at 02:23:04PM +0100, Suzuki K Poulose wrote: > Hi Leo, > > This version looks good to me. I have two minor comments below. Thanks for reviewing. Will take the suggestions. Just check a bit for last comment. [...] > >+static int debug_probe(struct amba_device

Re: [PATCH v5 01/32] x86: Documentation for AMD Secure Memory Encryption (SME)

2017-04-19 Thread Tom Lendacky
On 4/19/2017 4:02 AM, Borislav Petkov wrote: Always have a verb in the Subject to form a "do this" or "do that" sentence to better explain what the patch does: "Subject: [PATCH v5 01/32] x86: Add documentation for AMD Secure Memory Encryption (SME)" Will do. Btw, I tried to update all the

Re: [PATCH v13 03/10] mux: minimal mux subsystem and gpio-based mux controller

2017-04-19 Thread Philipp Zabel
On Wed, 2017-04-19 at 14:00 +0200, Peter Rosin wrote: [...] > >> +int mux_control_select(struct mux_control *mux, int state) > > > > If we let two of these race, ... > > The window for this "race" is positively huge. If there are several > mux consumers of a single mux controller, it is

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

2017-04-19 Thread Suzuki K Poulose
On 06/04/17 14:30, Leo Yan wrote: Coresight includes debug module and usually the module connects with CPU debug logic. ARMv8 architecture reference manual (ARM DDI 0487A.k) has description for related info in "Part H: External Debug". Chapter H7 "The Sample-based Profiling Extension"

Re: [PATCH v13 02/10] dt-bindings: document devicetree bindings for mux-controllers and gpio-mux

2017-04-19 Thread Peter Rosin
On 2017-04-19 13:05, Philipp Zabel wrote: > On Wed, 2017-04-19 at 12:41 +0200, Peter Rosin wrote: >> On 2017-04-19 11:17, Philipp Zabel wrote: >>> On Tue, 2017-04-18 at 15:36 +0200, Peter Rosin wrote: If I got things wrong when I skimmed whatever I came across, and if the mmio register

Re: [PATCH v13 02/10] dt-bindings: document devicetree bindings for mux-controllers and gpio-mux

2017-04-19 Thread Philipp Zabel
On Wed, 2017-04-19 at 12:41 +0200, Peter Rosin wrote: > On 2017-04-19 11:17, Philipp Zabel wrote: > > On Tue, 2017-04-18 at 15:36 +0200, Peter Rosin wrote: > >> If I got things wrong when I skimmed whatever I came across, and if the > >> mmio register is the only mux control option in the stars,

Re: [PATCH v13 02/10] dt-bindings: document devicetree bindings for mux-controllers and gpio-mux

2017-04-19 Thread Peter Rosin
On 2017-04-19 11:17, Philipp Zabel wrote: > On Tue, 2017-04-18 at 15:36 +0200, Peter Rosin wrote: >> If I got things wrong when I skimmed whatever I came across, and if the >> mmio register is the only mux control option in the stars, it becomes >> less obvious... It's of course still possible to

Re: [PATCH v5 01/32] x86: Documentation for AMD Secure Memory Encryption (SME)

2017-04-19 Thread David Howells
Borislav Petkov wrote: > "Subject: [PATCH v5 01/32] x86: Add documentation for AMD Secure Memory > Encryption (SME)" Or: x86: Document AMD Secure Memory Encryption (SME) support David -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body

Re: [PATCH v13 02/10] dt-bindings: document devicetree bindings for mux-controllers and gpio-mux

2017-04-19 Thread Philipp Zabel
On Tue, 2017-04-18 at 15:36 +0200, Peter Rosin wrote: > On 2017-04-18 12:06, Philipp Zabel wrote: > > On Thu, 2017-04-13 at 18:43 +0200, Peter Rosin wrote: > >> Allow specifying that a single multiplexer controller can be used to > >> control several parallel multiplexers, thus enabling sharing of

Re: [PATCH v13 03/10] mux: minimal mux subsystem and gpio-based mux controller

2017-04-19 Thread Philipp Zabel
On Thu, 2017-04-13 at 18:43 +0200, Peter Rosin wrote: > Add a new minimalistic subsystem that handles multiplexer controllers. > When multiplexers are used in various places in the kernel, and the > same multiplexer controller can be used for several independent things, > there should be one place