Re: [PATCH v5 0/7] Add kselftest_harness.h

2017-05-30 Thread Shuah Khan
On 05/26/2017 01:09 PM, Kees Cook wrote: > On Fri, May 26, 2017 at 11:43 AM, Mickaël Salaün wrote: >> Hi, >> >> This patch series make the seccomp/test_harness.h more generally available >> [1] >> and update the kselftest documentation in the Sphinx format. It also improve >>

Re: [PATCH v5 26/32] x86, drm, fbdev: Do not specify encrypted memory for video mappings

2017-05-30 Thread Tom Lendacky
On 5/16/2017 12:35 PM, Borislav Petkov wrote: On Tue, Apr 18, 2017 at 04:20:56PM -0500, Tom Lendacky wrote: Since video memory needs to be accessed decrypted, be sure that the memory encryption mask is not set for the video ranges. Signed-off-by: Tom Lendacky ---

Re: [PATCH v4 next 1/3] modules:capabilities: allow __request_module() to take a capability argument

2017-05-30 Thread Kees Cook
On Wed, May 24, 2017 at 7:16 AM, Djalal Harouni wrote: > On Tue, May 23, 2017 at 9:19 PM, Kees Cook wrote: >> On Tue, May 23, 2017 at 3:29 AM, Djalal Harouni wrote: >> Even in the existing code, there is a sense about CAP_NET_ADMIN and >>

Re: [PATCH v5 17/32] x86/mm: Add support to access boot related data in the clear

2017-05-30 Thread Tom Lendacky
On 5/26/2017 11:35 AM, Borislav Petkov wrote: On Fri, May 26, 2017 at 11:22:36AM -0500, Tom Lendacky wrote: In addition to the same issue as efi.memmap.phys_map, efi_phys has the __initdata attribute so it will be released/freed which will cause problems in checks performed afterwards. Sounds

Re: [PATCH v5 28/32] x86/mm, kexec: Allow kexec to be used with SME

2017-05-30 Thread Tom Lendacky
On 5/25/2017 11:17 PM, Xunlei Pang wrote: On 04/19/2017 at 05:21 AM, Tom Lendacky wrote: Provide support so that kexec can be used to boot a kernel when SME is enabled. Support is needed to allocate pages for kexec without encryption. This is needed in order to be able to reboot in the kernel

Re: [PATCH v2 0/3] perf: xgene: Add support for SoC PMU version 3

2017-05-30 Thread Hoan Tran
Hi All, Ping again Thanks Hoan On Fri, May 5, 2017 at 8:48 AM, Hoan Tran wrote: > Ping! > > Thanks > Hoan > > On Thu, Apr 13, 2017 at 10:50 AM, Hoan Tran wrote: >> Hi All, >> >> Do you have any comments on this patch set? >> >> Thanks >> Hoan >> >> On Mon, Apr

Re: [PATCH v5 17/32] x86/mm: Add support to access boot related data in the clear

2017-05-30 Thread Tom Lendacky
On 5/21/2017 2:16 AM, Borislav Petkov wrote: On Fri, May 19, 2017 at 03:50:32PM -0500, Tom Lendacky wrote: The "worker" function would be doing the loop through the setup data, but since the setup data is mapped inside the loop I can't do the __init calling the non-init function and still hope

Re: [PATCH v5 29/32] x86/mm: Add support to encrypt the kernel in-place

2017-05-30 Thread Tom Lendacky
On 5/26/2017 11:25 AM, Borislav Petkov wrote: On Thu, May 25, 2017 at 05:24:27PM -0500, Tom Lendacky wrote: I guess I could do that, but this will probably only end up clearing a single PGD entry anyway since it's highly doubtful the address range would cross a 512GB boundary. Or you can

Re: [PATCH v5 32/32] x86/mm: Add support to make use of Secure Memory Encryption

2017-05-30 Thread Tom Lendacky
On 5/19/2017 3:16 PM, Josh Poimboeuf wrote: On Fri, May 19, 2017 at 01:30:05PM +0200, Borislav Petkov wrote: it is called so early. I can get past it by adding: CFLAGS_mem_encrypt.o := $(nostackp) in the arch/x86/mm/Makefile, but that obviously eliminates the support for the whole file.

Re: [PATCH v5 32/32] x86/mm: Add support to make use of Secure Memory Encryption

2017-05-30 Thread Tom Lendacky
On 5/19/2017 6:30 AM, Borislav Petkov wrote: On Fri, Apr 21, 2017 at 01:56:13PM -0500, Tom Lendacky wrote: On 4/18/2017 4:22 PM, Tom Lendacky wrote: Add support to check if SME has been enabled and if memory encryption should be activated (checking of command line option based on the

Re: [PATCH v5 32/32] x86/mm: Add support to make use of Secure Memory Encryption

2017-05-30 Thread Tom Lendacky
On 5/30/2017 9:55 AM, Borislav Petkov wrote: > On Tue, May 30, 2017 at 09:38:36AM -0500, Tom Lendacky wrote: >> In this case we're running identity mapped and the "on" constant ends up >> as kernel address (0x81...) which results in a segfault. > > Would > > static const char

Re: [PATCH v5 32/32] x86/mm: Add support to make use of Secure Memory Encryption

2017-05-30 Thread Borislav Petkov
On Tue, May 30, 2017 at 09:38:36AM -0500, Tom Lendacky wrote: > In this case we're running identity mapped and the "on" constant ends up > as kernel address (0x81...) which results in a segfault. Would static const char *__on_str = "on"; ... if (!strncmp(buffer,

Re: [PATCH v5 32/32] x86/mm: Add support to make use of Secure Memory Encryption

2017-05-30 Thread Tom Lendacky
On 5/19/2017 6:27 AM, Borislav Petkov wrote: On Tue, Apr 18, 2017 at 04:22:23PM -0500, Tom Lendacky wrote: Add support to check if SME has been enabled and if memory encryption should be activated (checking of command line option based on the configuration of the default state). If memory

Re: [PATCH 1/2] Documentation/sphinx: kerneldoc: add "unused-functions"

2017-05-30 Thread Johannes Berg
On Tue, 2017-04-04 at 10:26 +0300, Jani Nikula wrote: > > > Interesting, TBH I never even considered this. How would I even run > > it that way? Presumably "make htmldocs" doesn't do this? > > Try 'make SPHINXOPTS=-j8 htmldocs'. Yep, makes sense. > > Sphinx documentation

Re: [PATCH v13 9/9] arm64: dts: qcom: msm8916: Add debug unit

2017-05-30 Thread Leo Yan
Hi Andy, David, [ + Nico ] On Fri, May 26, 2017 at 12:04:13AM +0800, Leo Yan wrote: > Add debug unit on Qualcomm msm8916 based platforms, including the > DragonBoard 410c board. Could you take a look for this patch? After get your ACK I think Mathieu could help pick up this patch through

Re: [PATCH v13 8/9] arm64: dts: hi6220: register debug module

2017-05-30 Thread Leo Yan
Hi Wei, On Thu, May 25, 2017 at 11:57:15PM +0800, Leo Yan wrote: > Bind debug module driver for Hi6220. Could you ACK this patch? From Mathieu's previous suggestion, after your confirmation he could pick up this patch. If you want me to send a separate patch to you directly, also is okay.

Re: [PATCH v2 1/2] drivers: pwm: core: implement pwm dead-times

2017-05-30 Thread m18063
Hi Andy, On 28.05.2017 01:28, Andy Shevchenko wrote: > On Tue, May 9, 2017 at 11:19 AM, Claudiu Beznea > wrote: >> Extends PWM framework to support PWM dead-times. >> The notions introduced are rising edge dead-time >> and falling edge dead-time. These are useful

Re: [PATCH 1/2] drivers: pwm: core: implement pwm mode

2017-05-30 Thread m18063
Hi Andy, On 28.05.2017 01:11, Andy Shevchenko wrote: > On Tue, May 9, 2017 at 3:15 PM, Claudiu Beznea > wrote: >> Extends PWM framework to support PWM modes. The currently >> implemented PWM modes were called PWM complementary mode >> and PWM push-pull mode. For

[PATCH v6 3/3] watchdog: introduce CONFIG_WATCHDOG_OPEN_TIMEOUT

2017-05-30 Thread Rasmus Villemoes
This allows setting a default value for the watchdog.open_timeout commandline parameter via Kconfig. Some BSPs allow remote updating of the kernel image and root file system, but updating the bootloader requires physical access. Hence, if one has a firmware update that requires relaxing the

[PATCH v6 0/3] watchdog: allow setting deadline for opening /dev/watchdogN

2017-05-30 Thread Rasmus Villemoes
If a watchdog driver tells the framework that the device is running, the framework takes care of feeding the watchdog until userspace opens the device. If the userspace application which is supposed to do that never comes up properly, the watchdog is fed indefinitely by the kernel. This can be

[PATCH v6 2/3] watchdog: introduce watchdog.open_timeout commandline parameter

2017-05-30 Thread Rasmus Villemoes
The watchdog framework takes care of feeding a hardware watchdog until userspace opens /dev/watchdogN. If that never happens for some reason (buggy init script, corrupt root filesystem or whatnot) but the kernel itself is fine, the machine stays up indefinitely. This patch allows setting an upper

Re: [PATCH v13 0/9] coresight: enable debug module

2017-05-30 Thread Leo Yan
On Mon, May 29, 2017 at 10:41:17AM -0600, Mathieu Poirier wrote: > On 25 May 2017 at 09:57, Leo Yan wrote: > > ARMv8 architecture reference manual (ARM DDI 0487A.k) Chapter H7 "The > > Sample-based Profiling Extension" has description for sampling > > registers, we can utilize

Re: [PATCH v5 2/3] watchdog: introduce watchdog.open_timeout commandline parameter

2017-05-30 Thread Rasmus Villemoes
On 2017-05-25 02:56, Guenter Roeck wrote: > On 05/22/2017 07:06 AM, Rasmus Villemoes wrote: >> diff --git a/Documentation/watchdog/watchdog-parameters.txt >> b/Documentation/watchdog/watchdog-parameters.txt >> index 914518a..4801ec6 100644 >> --- a/Documentation/watchdog/watchdog-parameters.txt >>