Hi Pavel,
At 10/09/2017 08:25 PM, Pavel Tatashin wrote:
Hi Dou,
Have you tested tsc=unstable with your DR setup? Is it working as
expected? I mean instead of previous "notsc"?
Not yet, I have applied for the machine, I'll start testing once I have
access to it. And I am looking at this part o
2017-10-06 5:58 GMT+09:00 Doug Anderson :
> Hi,
>
> On Thu, Oct 5, 2017 at 12:26 AM, Masahiro Yamada
> wrote:
>> As far as I tested, I always see only one space after ":=" in v2.
>>
>> I did not consider this deeply,
>> but something is working nicely behind the scene.
>
> Try adding this to the e
On Thu, 5 Oct 2017, Roman Gushchin wrote:
> Traditionally, the OOM killer is operating on a process level.
> Under oom conditions, it finds a process with the highest oom score
> and kills it.
>
> This behavior doesn't suit well the system with many running
> containers:
>
> 1) There is no fairn
On Mon, Oct 09, 2017 at 09:12:33PM +, Jani Nikula wrote:
> On Mon, 09 Oct 2017, Tom Saeger wrote:
> > On Mon, Oct 09, 2017 at 03:26:15PM +, Jani Nikula wrote:
> >
> > I just did something similar, but in python (parallel even). I like
> > your version for its elegant simplicity.
>
> Than
On Mon, 09 Oct 2017, Tom Saeger wrote:
> On Mon, Oct 09, 2017 at 03:26:15PM +, Jani Nikula wrote:
>> Add a simple script and build target to do a treewide grep for
>> references to files under Documentation, and report the non-existing
>> file in stderr. It tries to take into account punctuati
On Thu, 5 Oct 2017, Roman Gushchin wrote:
> Implement mem_cgroup_scan_tasks() functionality for the root
> memory cgroup to use this function for looking for a OOM victim
> task in the root memory cgroup by the cgroup-ware OOM killer.
>
> The root memory cgroup is treated as a leaf cgroup, so onl
On Mon, Oct 09, 2017 at 07:19:22AM -0300, Mauro Carvalho Chehab wrote:
> There are several undocumented v4l2-subdev functions that are
> part of kAPI. Document them.
>
> Signed-off-by: Mauro Carvalho Chehab
> ---
> include/media/v4l2-subdev.h | 70
> +
On Fri, Sep 08, 2017 at 05:15:12PM -0700, Eric Biggers wrote:
> From: Eric Biggers
>
> Perhaps long overdue, add a documentation file for filesystem-level
> encryption, a.k.a. fscrypt or fs/crypto/, to the Documentation
> directory. The new file is based loosely on the latest version of the
> "E
On Mon, Oct 09, 2017 at 07:19:23AM -0300, Mauro Carvalho Chehab wrote:
> ownner -> owner
>
> Signed-off-by: Mauro Carvalho Chehab
> ---
> include/media/v4l2-subdev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.
Hi Mauro,
On Mon, Oct 09, 2017 at 07:19:16AM -0300, Mauro Carvalho Chehab wrote:
> Right now, those are documented together with the subdev struct,
> instead of together with the definitions.
>
> Convert the definitions to an enum, use BIT() macros and document
> it at its right place.
>
> Signe
Hi Mauro,
On Mon, Oct 09, 2017 at 07:19:21AM -0300, Mauro Carvalho Chehab wrote:
> The __V4L2_SUBDEV_MK_GET_TRY() macro is used to define
> 3 functions that have the same arguments. The code of those
> functions is simple enough to just declare them, de-obfuscating
> the code.
>
> While here, rep
On Mon, Oct 09, 2017 at 03:26:15PM +, Jani Nikula wrote:
> Add a simple script and build target to do a treewide grep for
> references to files under Documentation, and report the non-existing
> file in stderr. It tries to take into account punctuation not part of
> the filename, and wildcards,
Add a simple script and build target to do a treewide grep for
references to files under Documentation, and report the non-existing
file in stderr. It tries to take into account punctuation not part of
the filename, and wildcards, but there are bound to be false positives
too. Mostly seems accurate
Acked-By: Mike Isely
On Mon, 9 Oct 2017, Mauro Carvalho Chehab wrote:
> Using enums makes easier to document, as it can use kernel-doc
> markups. It also allows cross-referencing, with increases the
> kAPI readability.
>
> Signed-off-by: Mauro Carvalho Chehab
> ---
> Documentation/media/kapi
On Mon, 9 Oct 2017 10:08:42 +0200
Maciej Purski wrote:
> On 10/08/2017 11:47 AM, Jonathan Cameron wrote:
> > On Wed, 04 Oct 2017 09:11:31 +0200
> > Maciej Purski wrote:
> >
> >> On 10/01/2017 12:29 PM, Jonathan Cameron wrote:
> >>> On Thu, 28 Sep 2017 14:50:12 +0200
> >>> Maciej Purski wro
Em Sun, 8 Oct 2017 12:07:29 +0200
Markus Heiser escreveu:
> > Am 07.10.2017 um 18:34 schrieb Jonathan Corbet :
> >
> > On Wed, 4 Oct 2017 08:48:38 -0300
> > Mauro Carvalho Chehab wrote:
> >
> >> Right now, it is not possible to document nested struct and nested unions.
> >> kernel-doc simpl
Em Mon, 9 Oct 2017 07:19:06 -0300
Mauro Carvalho Chehab escreveu:
> That's the second part of my V4L2 kAPI documentation improvements.
> It is meant to reduce the gap between the kAPI media headers
> and documentation, at least with regards to kernel-doc markups.
>
> We should likely write more
Hi Dou,
Have you tested tsc=unstable with your DR setup? Is it working as
expected? I mean instead of previous "notsc"?
Reviewed-by: Pavel Tatashin
Thank you,
Pavel
On Mon, Oct 9, 2017 at 5:03 AM, Dou Liyang wrote:
> Commit 8309f86cd41e ("x86/tsc: Provide 'tsc=unstable' boot parameter") adds
On Mon, Oct 09, 2017 at 07:19:09AM -0300, Mauro Carvalho Chehab wrote:
> Instead of using (1 << n) for bits, use the BIT() macro,
> as it makes them better documented.
I wouldn't say this makes a difference from documentation point of view.
Anyway,
Acked-by: Sakari Ailus
>
> Signed-off-by: Ma
Hi Mauro,
Thanks for the patch.
On Mon, Oct 09, 2017 at 07:19:08AM -0300, Mauro Carvalho Chehab wrote:
> There are two ancillary functions at v4l2-flash-led-class.h
> that aren't documented.
>
> Document them.
>
> Signed-off-by: Mauro Carvalho Chehab
> ---
> include/media/v4l2-flash-led-class
Hi Mauro,
On Mon, Oct 09, 2017 at 07:19:07AM -0300, Mauro Carvalho Chehab wrote:
> There are two macros at v4l2-dev.h that aren't documented.
>
> Document them, for completeness.
>
> Signed-off-by: Mauro Carvalho Chehab
> ---
> include/media/v4l2-dev.h | 18 +++---
> 1 file changed
On 09/10/17 12:19, Mauro Carvalho Chehab wrote:
> Convert #defines to enums and add kernel-doc markups for V4L2
> video_device flags.
>
> Signed-off-by: Mauro Carvalho Chehab
Acked-by: Hans Verkuil
Regards,
Hans
> ---
> include/media/v4l2-dev.h | 25 ++---
> 1 fi
On 09/10/17 12:19, Mauro Carvalho Chehab wrote:
> In the past, the same I2C address were used on multiple places.
> After I2C rebinding changes, this is no longer needed. So, we
> can just get rid of this header, placing the I2C address where
> they belong, e. g. either at bttv driver or at tvtuner
On 09/10/17 12:19, Mauro Carvalho Chehab wrote:
> The V4L_DIR_* direction flags document the direction for a
> V4L2 device node. Convert them to enum and document.
>
> Signed-off-by: Mauro Carvalho Chehab
Acked-by: Hans Verkuil
Regards,
Hans
> ---
> include/media/v4l2-dev.h | 22 +++
On 09/10/17 12:19, Mauro Carvalho Chehab wrote:
> Some of the previously used I2C addresses there aren't used
> anymore. So, get rid of them.
>
> Signed-off-by: Mauro Carvalho Chehab
Acked-by: Hans Verkuil
Regards,
Hans
> ---
> include/media/i2c-addr.h | 7 ---
> 1 file changed,
On 09/10/17 12:19, Mauro Carvalho Chehab wrote:
> Using enums makes easier to document, as it can use kernel-doc
> markups. It also allows cross-referencing, with increases the
> kAPI readability.
>
> Signed-off-by: Mauro Carvalho Chehab
Acked-by: Hans Verkuil
Regards,
Hans
> ---
>
On 09/10/17 12:19, Mauro Carvalho Chehab wrote:
> There is a mess with media bus flags: there are two sets of
> flags, one used by parallel and ITU-R BT.656 outputs,
> and another one for CSI2.
>
> Depending on the type, the same bit has different meanings.
>
> That's very confusing, and counter-
On 09/10/17 12:23, Mauro Carvalho Chehab wrote:
> Despite the struct says "color16", it was actually using 32 bits
> for each color. Fix it.
>
> Suggested-by: Hans Verkuil
> Signed-off-by: Mauro Carvalho Chehab
Acked-by: Hans Verkuil
Thanks!
Hans
> ---
>
> Should come after this pa
On 09/10/17 12:19, Mauro Carvalho Chehab wrote:
> The color structs right now are just "color" and "color16".
> That may lead into conflicts, and don't define precisely what
> they meant. As those are used by two drivers (vivid and vimc),
> this is even on a somewhat public header!
>
> So rename t
On 09/10/17 12:19, Mauro Carvalho Chehab wrote:
> The v4l2-tpg*.h headers are meant to be used only internally by
> vivid and vimc. There's no sense keeping them together with the
> V4L2 kAPI headers. Also, one header includes the other as they're
> meant to be used together. So, merge them.
>
> S
Despite the struct says "color16", it was actually using 32 bits
for each color. Fix it.
Suggested-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
---
Should come after this patch series:
V4L2 kAPI cleanups and documentation improvements part 2
include/media/tpg/v4l2-tpg.h | 2 +-
The V4L_DIR_* direction flags document the direction for a
V4L2 device node. Convert them to enum and document.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-dev.h | 22 --
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/include/media/v4l2-dev.h b
There are two ancillary functions at v4l2-flash-led-class.h
that aren't documented.
Document them.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-flash-led-class.h | 12
1 file changed, 12 insertions(+)
diff --git a/include/media/v4l2-flash-led-class.h
b/include/medi
The __V4L2_SUBDEV_MK_GET_TRY() macro is used to define
3 functions that have the same arguments. The code of those
functions is simple enough to just declare them, de-obfuscating
the code.
While here, replace BUG_ON() by WARN_ON() as there's no reason
why to panic the Kernel if this fails.
Signed
Right now, those are documented together with the subdev struct,
instead of together with the definitions.
Convert the definitions to an enum, use BIT() macros and document
it at its right place.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-subdev.h | 36 -
There are two macros at v4l2-dev.h that aren't documented.
Document them, for completeness.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-dev.h | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/include/media/v4l2-dev.h b/include/media/v4l2-dev
Use the existing macros to identify vb2_io_modes bits.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/videobuf2-core.h | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h
index 5f4df060affb..0308d
There are several VB2 core functions that aren't documented.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/videobuf2-core.h | 54 +-
1 file changed, 53 insertions(+), 1 deletion(-)
diff --git a/include/media/videobuf2-core.h b/include/media/video
In the past, the same I2C address were used on multiple places.
After I2C rebinding changes, this is no longer needed. So, we
can just get rid of this header, placing the I2C address where
they belong, e. g. either at bttv driver or at tvtuner.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/me
Instead of using (1 << n) for bits, use the BIT() macro,
as it makes them better documented.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-mediabus.h | 50 ++-
1 file changed, 26 insertions(+), 24 deletions(-)
diff --git a/include/media/v4l2
The v4l2-tpg*.h headers are meant to be used only internally by
vivid and vimc. There's no sense keeping them together with the
V4L2 kAPI headers. Also, one header includes the other as they're
meant to be used together. So, merge them.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/comm
There are several issues on the current markups:
- lack of cross-references;
- wrong cross-references;
- lack of a period of the end of several phrases;
- Some descriptions can be enhanced.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/videobuf2-core.h | 376 ++--
The color structs right now are just "color" and "color16".
That may lead into conflicts, and don't define precisely what
they meant. As those are used by two drivers (vivid and vimc),
this is even on a somewhat public header!
So rename them to:
color -> tpg_rbg_color8
color16 ->
There is a mess with media bus flags: there are two sets of
flags, one used by parallel and ITU-R BT.656 outputs,
and another one for CSI2.
Depending on the type, the same bit has different meanings.
That's very confusing, and counter-intuitive. So, split them
into two sets of flags, inside an en
Convert #defines to enums and add kernel-doc markups for V4L2
video_device flags.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-dev.h | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/include/media/v4l2-dev.h b/include/media/v4l2-dev.h
i
That's the second part of my V4L2 kAPI documentation improvements.
It is meant to reduce the gap between the kAPI media headers
and documentation, at least with regards to kernel-doc markups.
We should likely write more things at the ReST files under Documentation/
to better describe some of those
When we split VB2 into an independent streaming module and
a V4L2 one, some vb2-core functions started to have a wrong
description: they're meant to be used only by the API-specific
parts of VB2, like vb2-v4l2, as the functions that V4L2 drivers
should use are all under videobuf2-v4l2.h.
Correct t
Convert V4L2_SUBDEV_IO_PIN_* to enums, use BIT() and document
via kernel-doc.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-subdev.h | 33 +
1 file changed, 21 insertions(+), 12 deletions(-)
diff --git a/include/media/v4l2-subdev.h b/include/media/v
ownner -> owner
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-subdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
index e215732eed45..345da052618c 100644
--- a/include/media/v4l2-subdev.h
+++ b/inclu
There are several undocumented v4l2-subdev functions that are
part of kAPI. Document them.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-subdev.h | 70 +
1 file changed, 65 insertions(+), 5 deletions(-)
diff --git a/include/media/v4l2-su
As kernel-doc doesn't support documenting #define values,
and using enum makes easier to identify where the values
are used, convert V4L2_MBUS_FRAME_DESC_FL_* to enum, and
use BIT() macro.
While here, fix the description at v4l2_mbus_frame_desc_entry,
in order to match what's described for
V4L2_MB
When generating Sphinx output, create cross-references for the
callbacks for each ioctl.
While here, fix a few wrong names for ioctls.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-subdev.h | 65 -
1 file changed, 34 insertions(+), 31 de
Using enums makes easier to document, as it can use kernel-doc
markups. It also allows cross-referencing, with increases the
kAPI readability.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/kapi/v4l2-dev.rst | 17 ++---
drivers/media/pci/cx88/cx88-blackbird.c | 3 +-
dri
Some of the previously used I2C addresses there aren't used
anymore. So, get rid of them.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/i2c-addr.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/include/media/i2c-addr.h b/include/media/i2c-addr.h
index 5d0f56054d26..fba0457b74
Add cross-references where needed and add periods at the end of
each kernel-doc paragraph, in order to make it coherent with other
VB2 descriptions.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/videobuf2-memops.h | 8 +--
include/media/videobuf2-v4l2.h | 112 +--
The description there is completely broken and it mentions
an ioctl that doesn't exist.
Fix it.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-subdev.h | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/include/media/v4l2-subdev.h b/include/me
Commit 8309f86cd41e ("x86/tsc: Provide 'tsc=unstable' boot parameter") adds
a new parameter 'tsc=unstable', but doesn't add some description to guide
users.
Append the description of 'tsc=unstable' at the end of 'tsc=' section.
Signed-off-by: Dou Liyang
---
Documentation/admin-guide/kernel-para
Hi All,
Do you have any comments on this patch set?
Thanks,
Shaokun
On 2017/9/21 18:40, Zhangshaokun wrote:
> Hi Mark/Will,
>
> Appreciate any comments from you.
>
> Thanks,
> Shaokun
>
> On 2017/8/22 16:07, Shaokun Zhang wrote:
>> This patchset adds support for HiSilicon SoC uncore PMUs driv
On 10/08/2017 11:47 AM, Jonathan Cameron wrote:
On Wed, 04 Oct 2017 09:11:31 +0200
Maciej Purski wrote:
On 10/01/2017 12:29 PM, Jonathan Cameron wrote:
On Thu, 28 Sep 2017 14:50:12 +0200
Maciej Purski wrote:
Max expected current is used for calculating calibration register value,
Curr
59 matches
Mail list logo
