Re: [PATCH] linux-next: SLIMbus: doc: Fix a warning "Title underline too short"

2018-02-25 Thread Randy Dunlap
On 02/19/2018 06:32 AM, Matthew Wilcox wrote: > On Mon, Feb 19, 2018 at 10:55:50PM +0900, Masanari Iida wrote: >> Driver and Controller APIs: >> --- >> +--- >> .. kernel-doc:: include/linux/slimbus.h > > Is this the right fix? Shouldn't we rather

Re: [PATCH v12 22/22] selftests/vm: Fix deadlock in protection_keys.c

2018-02-25 Thread Balbir Singh
On Wed, 21 Feb 2018 17:55:41 -0800 Ram Pai wrote: > From: Thiago Jung Bauermann > > The sig_chld() handler calls dprintf2() taking care of setting > dprint_in_signal so that sigsafe_printf() won't call printf(). > Unfortunately, this precaution is is negated by dprintf_level(), which > has a ca

[PATCH 1/3] mm/nommu: remove description of alloc_vm_area

2018-02-25 Thread Mike Rapoport
The alloc_mm_area in nommu is a stub, but it's description states it allocates kernel address space. Remove the description to make the code and the documentation agree. Signed-off-by: Mike Rapoport --- mm/nommu.c | 12 1 file changed, 12 deletions(-) diff --git a/mm/nommu.c b/mm/n

[PATCH 3/3] mm: kernel-doc: add missing parameter descriptions

2018-02-25 Thread Mike Rapoport
Signed-off-by: Mike Rapoport --- mm/cma.c| 5 + mm/compaction.c | 1 + mm/kmemleak.c | 10 ++ mm/memory_hotplug.c | 6 ++ mm/oom_kill.c | 2 ++ mm/pagewalk.c | 3 +++ mm/rmap.c | 1 + mm/zsmalloc.c | 2 ++ 8 files changed, 3

[PATCH 2/3] mm/swap: remove @cold parameter description for release_pages

2018-02-25 Thread Mike Rapoport
The 'cold' parameter was removed from release_pages function by the commit c6f92f9fbe7db ("mm: remove cold parameter for release_pages"). Update the description to match the code. Signed-off-by: Mike Rapoport --- mm/swap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/swap.c b/mm/swap.c

[PATCH 0/3] mm: docs: more trivial updates

2018-02-25 Thread Mike Rapoport
Hi, Here's another set of (mostly) trivial updates for kernel-doc descriptions in the mm code. Mike Rapoport (3): mm/nommu: remove description of alloc_vm_area mm/swap: remove @cold parameter description for release_pages mm: kernel-doc: add missing parameter descriptions mm/cma.c

Re: [PATCH v3] usb: core: Add "quirks" parameter for usbcore

2018-02-25 Thread Kai-Heng Feng
On Sun, Feb 25, 2018 at 11:18 PM, Matthew Wilcox wrote: > On Sun, Feb 25, 2018 at 08:38:33PM +0800, Kai-Heng Feng wrote: >> v2: Use in-kernel tolower() function. > > ... why are you using tolower at all? > > You've got 13 quirks already; you may need to use upper case as well > before too long. M

Re: [PATCH v3] usb: core: Add "quirks" parameter for usbcore

2018-02-25 Thread Matthew Wilcox
On Sun, Feb 25, 2018 at 08:38:33PM +0800, Kai-Heng Feng wrote: > v2: Use in-kernel tolower() function. ... why are you using tolower at all? You've got 13 quirks already; you may need to use upper case as well before too long. > + quirk = vmalloc(sizeof(struct quirk_entry)); vmalloc

[PATCH v3] usb: core: Add "quirks" parameter for usbcore

2018-02-25 Thread Kai-Heng Feng
Trying quirks in usbcore needs to rebuild the driver or the entire kernel if it's builtin. It can save a lot of time if usbcore has similar ability like "usbhid.quirks=" and "usb-storage.quirks=". Rename the original quirk detection function to "static" as we introduce this new "dynamic" function.