Re: [PATCH v3 1/4] dt-bindings: soc: qcom: Add device tree binding for GENI SE

2018-03-05 Thread Karthik Ramasubramanian
On 3/5/2018 4:58 PM, Rob Herring wrote: On Tue, Feb 27, 2018 at 06:38:06PM -0700, Karthikeyan Ramasubramanian wrote: Add device tree binding support for the QCOM GENI SE driver. Signed-off-by: Karthikeyan Ramasubramanian Signed-off-by: Sagar Dharia Signed-off-by: Girish Mahadevan --- ...

Re: [PATCH v3 4/4] tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP

2018-03-05 Thread Karthik Ramasubramanian
On 3/2/2018 3:11 PM, Stephen Boyd wrote: Quoting Karthikeyan Ramasubramanian (2018-02-27 17:38:09) diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index 3682fd3..c6b1500 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -1104,6 +1104,17 @@ config

Re: [PATCH v3 1/4] dt-bindings: soc: qcom: Add device tree binding for GENI SE

2018-03-05 Thread Rob Herring
On Tue, Feb 27, 2018 at 06:38:06PM -0700, Karthikeyan Ramasubramanian wrote: > Add device tree binding support for the QCOM GENI SE driver. > > Signed-off-by: Karthikeyan Ramasubramanian > Signed-off-by: Sagar Dharia > Signed-off-by: Girish Mahadevan > --- > .../devicetree/bindings/soc/qcom/qc

Re: [PATCH v12 10/11] sparc64: Add support for ADI (Application Data Integrity)

2018-03-05 Thread Khalid Aziz
On 03/05/2018 02:31 PM, Dave Hansen wrote: On 03/05/2018 01:14 PM, Khalid Aziz wrote: Are you suggesting that vma returned by find_vma() could be split or merged underneath me if I do not hold mmap_sem and thus make the flag check invalid? If so, that is a good point. This part does make me th

Re: [PATCH v12 10/11] sparc64: Add support for ADI (Application Data Integrity)

2018-03-05 Thread Dave Hansen
On 03/05/2018 01:37 PM, Khalid Aziz wrote: >> How big can this storage get, btw?  Superficially it seems like it might >> be able to be gigantic for a large, sparse VMA. >> > Tags are stored only for the pages being swapped out, not for the pages > in entire vma. Each tag storage page can hold tags

Re: [PATCH v12 10/11] sparc64: Add support for ADI (Application Data Integrity)

2018-03-05 Thread Khalid Aziz
On 03/05/2018 02:26 PM, Dave Hansen wrote: On 02/21/2018 09:15 AM, Khalid Aziz wrote: +tag_storage_desc_t *alloc_tag_store(struct mm_struct *mm, + struct vm_area_struct *vma, + unsigned long addr) ... + tags = kzalloc(si

Re: [PATCH v12 10/11] sparc64: Add support for ADI (Application Data Integrity)

2018-03-05 Thread Dave Hansen
On 03/05/2018 01:14 PM, Khalid Aziz wrote: > Are you suggesting that vma returned by find_vma() could be split or > merged underneath me if I do not hold mmap_sem and thus make the flag > check invalid? If so, that is a good point. This part does make me think that this code hasn't been tested ver

Re: [PATCH v12 10/11] sparc64: Add support for ADI (Application Data Integrity)

2018-03-05 Thread Dave Hansen
On 03/05/2018 01:14 PM, Khalid Aziz wrote: > On 03/05/2018 12:22 PM, Dave Hansen wrote: >> On 02/21/2018 09:15 AM, Khalid Aziz wrote: >>> +#define arch_validate_prot(prot, addr) sparc_validate_prot(prot, addr) >>> +static inline int sparc_validate_prot(unsigned long prot, unsigned >>> long addr) >>

Re: [PATCH v12 10/11] sparc64: Add support for ADI (Application Data Integrity)

2018-03-05 Thread Dave Hansen
On 02/21/2018 09:15 AM, Khalid Aziz wrote: > +tag_storage_desc_t *alloc_tag_store(struct mm_struct *mm, > + struct vm_area_struct *vma, > + unsigned long addr) ... > + tags = kzalloc(size, GFP_NOWAIT|__GFP_NOWARN); > + if (tags

Re: [PATCH 2/2] docs: add Co-Developed-by docs

2018-03-05 Thread Tobin C. Harding
On Mon, Mar 05, 2018 at 04:11:35AM -0800, Matthew Wilcox wrote: > On Mon, Mar 05, 2018 at 02:58:21PM +1100, Tobin C. Harding wrote: > > -12) When to use Acked-by: and Cc: > > -- > > +12) When to use Acked-by: and Cc:, and Co-Developed-by: > > +---

Re: [PATCH v12 10/11] sparc64: Add support for ADI (Application Data Integrity)

2018-03-05 Thread Khalid Aziz
On 03/05/2018 12:22 PM, Dave Hansen wrote: On 02/21/2018 09:15 AM, Khalid Aziz wrote: +#define arch_validate_prot(prot, addr) sparc_validate_prot(prot, addr) +static inline int sparc_validate_prot(unsigned long prot, unsigned long addr) +{ + if (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC

Re: [PATCH 1/2] checkpatch: add check for tag Co-Developed-by

2018-03-05 Thread Joe Perches
On Mon, 2018-03-05 at 14:58 +1100, Tobin C. Harding wrote: > From: Joe Perches I still think this "Co-Developed-by" stuff is unnecessary. > Recently signature tag Co-Developed-by was added to the > kernel (Documentation/process/5.Posting.rst). checkpatch.pl doesn't know > about it yet. All prior

Re: [PATCH v12 10/11] sparc64: Add support for ADI (Application Data Integrity)

2018-03-05 Thread Dave Hansen
On 02/21/2018 09:15 AM, Khalid Aziz wrote: > +#define arch_validate_prot(prot, addr) sparc_validate_prot(prot, addr) > +static inline int sparc_validate_prot(unsigned long prot, unsigned long addr) > +{ > + if (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC | PROT_SEM | PROT_ADI)) > +

Re: [PATCH 1/2] kbuild: remove command line interface LDFLAGS_MODULE from makefiles.txt

2018-03-05 Thread Masahiro Yamada
2018-02-28 19:14 GMT+09:00 Masahiro Yamada : > Documentation/kbuild/makefiles.txt lists variables used in Makefile > whereas Documentation/kbuild/kbuild.txt describes user assignable > parameters given via environments or the command line. > > LDFLAGS_MODULE is a command line interface, so it shoul

Re: [PATCH 2/2] docs: add Co-Developed-by docs

2018-03-05 Thread Matthew Wilcox
On Mon, Mar 05, 2018 at 02:58:21PM +1100, Tobin C. Harding wrote: > -12) When to use Acked-by: and Cc: > -- > +12) When to use Acked-by: and Cc:, and Co-Developed-by: > +--- +12) When to use Acked-by:, Cc:, and Co-

[PATCH] crypto: doc - clarify hash callbacks state machine

2018-03-05 Thread Horia Geantă
Even though it doesn't make too much sense, it is perfectly legal to: - call .init() and then (as many times) .update() - subseqently _not_ call any of .final(), .finup() or .export() Update documentation since this is an important issue to consider from resource management perspective. Link: htt