Re: [v3, 3/4] i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller

2018-03-08 Thread Karthik Ramasubramanian
On 3/7/2018 2:16 PM, Doug Anderson wrote: Hi, On Tue, Feb 27, 2018 at 5:38 PM, Karthikeyan Ramasubramanian wrote: This bus driver supports the GENI based i2c hardware controller in the Qualcomm SOCs. The Qualcomm Generic Interface (GENI) is a programmable module supporting a wide range of se

Re: [v3, 3/4] i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller

2018-03-08 Thread Doug Anderson
Hi, On Thu, Mar 8, 2018 at 5:06 PM, Sagar Dharia wrote: > Hi Doug > > > On 3/8/2018 2:12 PM, Doug Anderson wrote: >> >> Hi, >> >> On Wed, Mar 7, 2018 at 9:19 PM, Doug Anderson >> wrote: > > DMA is hard and i2c transfers > 32 bytes are rare. Do we really gain > a lot by transferring

Re: [PATCH v3 4/4] tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP

2018-03-08 Thread Karthik Ramasubramanian
On 3/8/2018 3:32 PM, Stephen Boyd wrote: Quoting Karthik Ramasubramanian (2018-03-07 22:06:29) On 3/6/2018 2:45 PM, Stephen Boyd wrote: Quoting Karthik Ramasubramanian (2018-03-05 16:51:23) On 3/2/2018 3:11 PM, Stephen Boyd wrote: Ok. I've seen similar designs in some mmc drivers. For ex

Re: [v3, 3/4] i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller

2018-03-08 Thread Sagar Dharia
Hi Doug, On 3/7/2018 10:19 PM, Doug Anderson wrote: Hi, On Wed, Mar 7, 2018 at 6:42 PM, Sagar Dharia wrote: Hi Doug, Thank you for reviewing the patch. I will take a stab at a few comments below. We will address most of the other comments in next version of I2C patch. + +static const struc

Re: [v3, 3/4] i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller

2018-03-08 Thread Sagar Dharia
Hi Doug On 3/8/2018 2:12 PM, Doug Anderson wrote: Hi, On Wed, Mar 7, 2018 at 9:19 PM, Doug Anderson wrote: DMA is hard and i2c transfers > 32 bytes are rare. Do we really gain a lot by transferring i2c commands over DMA compared to a FIFO? Enough to justify the code complexity and the set of

[PATCH 4/8] Documentation: gpio: Move driver documentation to driver-api

2018-03-08 Thread Jonathan Neuschäfer
Move gpio/driver.txt to driver-api/gpio/driver.rst and make sure it builds cleanly as ReST. Signed-off-by: Jonathan Neuschäfer --- .../driver.txt => driver-api/gpio/driver.rst} | 80 +++--- Documentation/driver-api/gpio/index.rst| 1 + Documentation/gpio/00-INDE

[PATCH 7/8] Documentation: gpio: Move GPIO mapping documentation to driver-api

2018-03-08 Thread Jonathan Neuschäfer
Move gpio/board.txt to driver-api/gpio/board.rst and make sure it builds cleanly as ReST. Signed-off-by: Jonathan Neuschäfer --- .../{gpio/board.txt => driver-api/gpio/board.rst} | 39 -- Documentation/driver-api/gpio/index.rst| 1 + Documentation/gpio/00-INDEX

[PATCH 6/8] Documentation: gpio: Move gpiod_* consumer documentation to driver-api

2018-03-08 Thread Jonathan Neuschäfer
Move gpio/consumer.txt to driver-api/gpio/consumer.rst and make sure it builds cleanly as ReST. Signed-off-by: Jonathan Neuschäfer --- .../consumer.txt => driver-api/gpio/consumer.rst} | 85 +++--- Documentation/driver-api/gpio/index.rst| 1 + Documentation/gpio/00-

[PATCH 2/8] Documentation: driver-api: Move gpio.rst to gpio/index.rst

2018-03-08 Thread Jonathan Neuschäfer
To make space for more files in the GPIO section, create a Documentation/driver-api/gpio/ directory. Signed-off-by: Jonathan Neuschäfer --- Documentation/driver-api/{gpio.rst => gpio/index.rst} | 0 Documentation/driver-api/index.rst| 2 +- 2 files changed, 1 insertion(+), 1

[PATCH 8/8] Documentation: gpio: Move drivers-on-gpio.txt to driver-api

2018-03-08 Thread Jonathan Neuschäfer
Move gpio/drivers-on-gpio.txt to driver-api/gpio/drivers-on-gpio.rst and make sure it builds cleanly as ReST. Signed-off-by: Jonathan Neuschäfer --- This patch applies cleanly on top of 93db446a424c ("mtd: nand: move raw NAND related code to the raw/ subdir") --- .../drivers-on-gpio.txt => driv

[PATCH 5/8] Documentation: gpio: Move legacy documentation to driver-api

2018-03-08 Thread Jonathan Neuschäfer
Move gpio/gpio-legacy.txt to driver-api/gpio/legacy.rst and make sure it builds cleanly as ReST. Also move the legacy API reference from index.rst to legacy.rst. Signed-off-by: Jonathan Neuschäfer --- Documentation/driver-api/gpio/index.rst| 10 +--- .../gpio-legacy.txt => driver-ap

[PATCH 1/8] MAINTAINERS: GPIO: Add Documentation/driver-api/gpio/

2018-03-08 Thread Jonathan Neuschäfer
Steer patches to Documentation/driver-api/gpio/ into the right direction. Signed-off-by: Jonathan Neuschäfer --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d6a89d31e4a4..313c0907020c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6029,6 +6029,

[PATCH 0/8] Move most GPIO documentation to driver-api/gpio/ and ReST

2018-03-08 Thread Jonathan Neuschäfer
The aim of this patchset is to move the GPIO subsystem's documentation under Documentation/driver-api/gpio/ such that it is picked up by Sphinx and compiled into HTML. I moved everything except for sysfs.txt, because this file describes the legacy sysfs ABI, and doesn't seem to serve much (non-hist

[PATCH 3/8] Documentation: gpio: Move introduction to driver-api

2018-03-08 Thread Jonathan Neuschäfer
Move gpio/intro.txt to driver-api/gpio/intro.rst and make sure it builds cleanly as ReST. Signed-off-by: Jonathan Neuschäfer --- Documentation/driver-api/gpio/index.rst| 7 +++ Documentation/{gpio/gpio.txt => driver-api/gpio/intro.rst} | 9 +++-- Documentation/gpio/00

Re: [PATCH v3 4/4] tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP

2018-03-08 Thread Stephen Boyd
Quoting Karthik Ramasubramanian (2018-03-07 22:06:29) > > > On 3/6/2018 2:45 PM, Stephen Boyd wrote: > > Quoting Karthik Ramasubramanian (2018-03-05 16:51:23) > >> On 3/2/2018 3:11 PM, Stephen Boyd wrote: > > > > Ok. I've seen similar designs in some mmc drivers. For example, you can > > look at

Re: [v3, 3/4] i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller

2018-03-08 Thread Doug Anderson
Hi, On Wed, Mar 7, 2018 at 9:19 PM, Doug Anderson wrote: >>> DMA is hard and i2c transfers > 32 bytes are rare. Do we really gain >>> a lot by transferring i2c commands over DMA compared to a FIFO? >>> Enough to justify the code complexity and the set of bugs that will >>> show up? I'm sure it

Re: [PATCH v3 2/4] soc: qcom: Add GENI based QUP Wrapper driver

2018-03-08 Thread Karthik Ramasubramanian
On 3/8/2018 6:24 AM, Robin Murphy wrote: On 08/03/18 06:46, Karthik Ramasubramanian wrote: On 3/6/2018 2:56 PM, Stephen Boyd wrote: Quoting Karthik Ramasubramanian (2018-03-02 16:58:23) +   return iova; +} +EXPORT_SYMBOL(geni_se_tx_dma_prep); + +/** + * geni_se_rx_dma_prep() - Prepare

Re: [PATCH] [v2] docs: clarify security-bugs disclosure policy

2018-03-08 Thread Jonathan Corbet
On Wed, 7 Mar 2018 13:53:06 -0800 Linus Torvalds wrote: > I'm guessing this will go through Jon? Sounds like a fine guess to me; will apply shortly. Thanks, jon -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More ma

Re: [PATCH] [v2] docs: clarify security-bugs disclosure policy

2018-03-08 Thread Greg KH
On Wed, Mar 07, 2018 at 01:46:24PM -0800, Dave Hansen wrote: > > From: Dave Hansen > > I think we need to soften the language a bit. It might scare folks > off, especially the: > >We prefer to fully disclose the bug as soon as possible. > > which is not really the case. Linus says: >

Re: [PATCH 05/10] hwmon: generic-pwm-tachometer: Add generic PWM based tachometer

2018-03-08 Thread Laxman Dewangan
On Thursday 08 March 2018 08:01 PM, Guenter Roeck wrote: On 03/07/2018 10:06 PM, Laxman Dewangan wrote: The RPM is measured speed via PWM signal capture which is output from fan. So should we have the fan[1..n]_output_rpm? No. I hear you clearly that you for some reason dislike fan[1..

Re: [PATCH v3 2/4] soc: qcom: Add GENI based QUP Wrapper driver

2018-03-08 Thread Christoph Hellwig
On Thu, Mar 08, 2018 at 01:24:45PM +, Robin Murphy wrote: > Implementing dma_map_ops inside a driver for real hardware is almost always > the wrong thing to do. Agreed. dma_map_ops should be a platform decision based on the bus. Even our dma_virt_ops basically just works around bad driver l

Re: [PATCH 05/10] hwmon: generic-pwm-tachometer: Add generic PWM based tachometer

2018-03-08 Thread Guenter Roeck
On 03/07/2018 11:57 PM, Mikko Perttunen wrote: On 07.03.2018 16:20, Guenter Roeck wrote: On 03/07/2018 01:47 AM, Rajkumar Rampelli wrote: On Wednesday 28 February 2018 07:59 PM, Guenter Roeck wrote: On 02/27/2018 11:03 PM, Mikko Perttunen wrote: On 02/28/2018 08:12 AM, Rajkumar Rampelli w

Re: [PATCH 05/10] hwmon: generic-pwm-tachometer: Add generic PWM based tachometer

2018-03-08 Thread Guenter Roeck
On 03/07/2018 10:06 PM, Laxman Dewangan wrote: On Wednesday 07 March 2018 07:50 PM, Guenter Roeck wrote: On 03/07/2018 01:47 AM, Rajkumar Rampelli wrote: While I am not opposed to ABI changes, the merits of those would need to be discussed on the mailing list. But replacing "fan1_input" wi

Re: [PATCH v3 2/4] soc: qcom: Add GENI based QUP Wrapper driver

2018-03-08 Thread Robin Murphy
On 08/03/18 06:46, Karthik Ramasubramanian wrote: On 3/6/2018 2:56 PM, Stephen Boyd wrote: Quoting Karthik Ramasubramanian (2018-03-02 16:58:23) +   return iova; +} +EXPORT_SYMBOL(geni_se_tx_dma_prep); + +/** + * geni_se_rx_dma_prep() - Prepare the Serial Engine for RX DMA transfer + *

Re: [PATCH V2 5/7] thermal/drivers/cpu_cooling: Add idle cooling device documentation

2018-03-08 Thread Daniel Thompson
On Thu, Mar 08, 2018 at 09:59:49AM +0100, Pavel Machek wrote: > Hi! > > > >> +Under certain circumstances, the SoC reaches a temperature exceeding > > >> +the allocated power budget or the maximum temperature limit. The > > > > > > I don't understand. Power budget is in W, temperature is in > > >

Re: [PATCH V2 5/7] thermal/drivers/cpu_cooling: Add idle cooling device documentation

2018-03-08 Thread Pavel Machek
Hi! > >> +Under certain circumstances, the SoC reaches a temperature exceeding > >> +the allocated power budget or the maximum temperature limit. The > > > > I don't understand. Power budget is in W, temperature is in > > kelvin. Temperature can't exceed power budget AFAICT. > > Yes, it is badly