[PATCH v3] docs: dt-bindings: add DTS Coding Style document

2023-11-25 Thread Krzysztof Kozlowski
Document preferred coding style for Devicetree sources (DTS and DTSI), to bring consistency among all (sub)architectures and ease in reviews. Cc: Andrew Davis cc: Andrew Lunn Cc: AngeloGioacchino Del Regno Cc: Arnd Bergmann Cc: Bjorn Andersson Cc: Chen-Yu Tsai Cc: Dmitry Baryshkov Cc: Geert

Re: [PATCH v3] docs: dt-bindings: add DTS Coding Style document

2023-11-25 Thread Jonathan Corbet
Krzysztof Kozlowski writes: > Document preferred coding style for Devicetree sources (DTS and DTSI), > to bring consistency among all (sub)architectures and ease in reviews. One little nit: > diff --git a/Documentation/devicetree/bindings/dts-coding-style.rst > b/Documentation/devicetree/bindi

Re: [PATCH v3] docs: dt-bindings: add DTS Coding Style document

2023-11-25 Thread Laurent Pinchart
Hi Krzysztof, Thank you for the patch. On Sat, Nov 25, 2023 at 07:44:22PM +0100, Krzysztof Kozlowski wrote: > Document preferred coding style for Devicetree sources (DTS and DTSI), > to bring consistency among all (sub)architectures and ease in reviews. > > Cc: Andrew Davis > cc: Andrew Lunn >

Re: [PATCH v3] docs: dt-bindings: add DTS Coding Style document

2023-11-25 Thread Andrew Lunn
> += > +Devicetree Sources (DTS) Coding Style > += > + > +When writing Devicetree Sources (DTS) please observe below guidelines. They > +should be considered complementary to any rules expressed already in > Devicetree > +Spe

Re: [PATCH v3] docs: dt-bindings: add DTS Coding Style document

2023-11-25 Thread Konrad Dybcio
[...] >> + >> +3. Unit addresses shall use lowercase hex, without leading zeros (padding). > > I'm curious, what's the reason for this ? I think it makes the sources > less readable. If the rule is "just" because that's how DT sources are > written today and it would be too complicated to change t

Re: [PATCH v3] docs: dt-bindings: add DTS Coding Style document

2023-11-25 Thread Konrad Dybcio
On 25.11.2023 19:44, Krzysztof Kozlowski wrote: > Document preferred coding style for Devicetree sources (DTS and DTSI), > to bring consistency among all (sub)architectures and ease in reviews. > > Cc: Andrew Davis > cc: Andrew Lunn > Cc: AngeloGioacchino Del Regno > Cc: Arnd Bergmann > Cc: Bj