On 2 February 2017 at 16:37, Logan Gunthorpe wrote:
>
>
> On 01/02/17 05:10 AM, Emil Velikov wrote:
>> You can keep it roughly as-is if you're ~reasonably certain one won't
>> change it in the future.
>
> I've made the change anyway. I think it's be
On 31 January 2017 at 23:13, Logan Gunthorpe wrote:
> Hi Emil,
>
> Thanks for the feedback.
>
> On 31/01/17 01:48 PM, Emil Velikov wrote:
>>> +struct switchtec_ioctl_fw_info {
>>> + __u32 flash_length;
>>> +
>>> + struct {
>>&
Hi Logan,
NOTE: Please take my comments with a healthy pinch of salt.
I'd imagine that core/more experienced developers have more thorough
feedback, so I'll mention a few things on the less common part -
robust/compat UABI.
Above all, please read through the in-tree documentation on the topic [1]
- Remove unnecessary snprintf and strlen usage in read callback.
>
> v5:
> - Made the crcs array in drm_crtc_crc_entry fixed-size
> - Lots of other smaller improvements suggested by Emil Velikov
>
> v7:
> - Move definition of drm_debugfs_crtc_crc_add to drm_internal
On 6 October 2016 at 12:33, Tomeu Vizoso wrote:
> On 10/06/2016 01:13 PM, Emil Velikov wrote:
>> On 6 October 2016 at 09:56, Tomeu Vizoso wrote:
>>> Adds files and directories to debugfs for controlling and reading frame
>>> CRCs, per CRTC:
>>>
>>>
- Remove unnecessary snprintf and strlen usage in read callback.
>
> v5:
> - Made the crcs array in drm_crtc_crc_entry fixed-size
> - Lots of other smaller improvements suggested by Emil Velikov
>
> v7:
> - Move definition of drm_debugfs_crtc_crc_add to drm_internal
On 8 September 2016 at 15:49, Tomeu Vizoso wrote:
> On 8 September 2016 at 15:24, Emil Velikov wrote:
>> Hi Tomeu,
>>
>> A couple of small nitpicks and a rather nasty looking bug, related to
>> your earlier question.
>>
>> On 7 September 2016 at 11:27,
suggestions Tomeu. I think
I've spotted a bug in 2/4, plus there's a couple of trivial nitpicks
in 2/4 and 3/4 - either of which can be fixed as a follow up (if I
haven't lost it of course).
With the bug trivially fixed the series is:
Reviewed-by: Emil Velikov
-Emil
--
To unsubs
Hi Tomeu,
A couple of small nitpicks and a rather nasty looking bug, related to
your earlier question.
On 7 September 2016 at 11:27, Tomeu Vizoso wrote:
> +static ssize_t crc_control_write(struct file *file, const char __user *ubuf,
> +size_t len, loff_t *offp)
>
Hi Tomeu,
On 5 August 2016 at 11:45, Tomeu Vizoso wrote:
> +#ifdef CONFIG_DEBUG_FS
> + spin_lock_init(&crtc->crc.lock);
> + init_waitqueue_head(&crtc->crc.wq);
> + crtc->crc.source = kstrdup("auto", GFP_KERNEL);
Pedantic: kstrdup() can never fail ?
> +#endif
> +
> if (
Hi Xinliang,
On 11 April 2016 at 09:55, Xinliang Liu wrote:
> +static int kirin_drm_connectors_register(struct drm_device *dev)
> +{
> + struct drm_connector *connector;
> + struct drm_connector *failed_connector;
> + int ret;
> +
> + mutex_lock(&dev->mode_config.mutex);
Hi Xinliang,
On 11 April 2016 at 09:55, Xinliang Liu wrote:
> Add maintainer and reviewer for hisilicon DRM driver.
>
> v8: None.
> v7: None.
> v6: None.
> v5: None.
> v4:
> - Add Chen Feng as Designated reviewer.
> v3: First version.
>
> Signed-off-by: Xinliang Liu
> ---
> MAINTAINERS | 10 ++
12 matches
Mail list logo
