Re: [PATCH] doc: botching-up-ioctls: Make it clearer why structs must be padded

2018-05-02 Thread Eric Anholt
Daniel Vetter writes: > This came up in discussions when reviewing drm patches. > > Cc: Eric Anholt > Cc: linux-doc@vger.kernel.org > Cc: Jonathan Corbet > Signed-off-by: Daniel Vetter > > -- > > Aside: I wonder whether we shouldn't move this to some oth

Re: [PATCH] drm/doc: atomic overview, with graph

2017-03-01 Thread Eric Anholt
te" is somewhat offset below. Makes > the graph look like garbage, and also way too wide for proper > rendering. Ideas appreciated. > > v2: Spelling and clarifications (Eric). > > Cc: Eric Anholt > Cc: Laurent Pinchart > Cc: Harry Wentland > Signed-off-by: Daniel

Re: [PATCH 6/6] drm/doc: atomic overview, with graph

2017-02-28 Thread Eric Anholt
s starting vc4's atomic code! With the two little spelling nits fixed, 3-5 are: Acked-by: Eric Anholt A few copyedits on this one below, but it sounds like you don't want to push quite yet while you sort out the rendering. > --- > Docu

Re: [PATCH 4/6] drm/doc: Consistent kerneldoc include order

2017-02-28 Thread Eric Anholt
Daniel Vetter writes: > First overview text (if there is any), then headers (since generally > you want to start out with the data structures), then all the other > stuff with functions. > > Most of this is pre-shpinx, since with the old docbook only the "sphinx" signature.asc Description: PGP

Re: [PATCH 5/6] drm/doc: diagram for mode objects and properties

2017-02-28 Thread Eric Anholt
Daniel Vetter writes: > Resulted in confusion a few times in the past. > > Cc: Laurent Pinchart > Cc: Manasi Navare > Signed-off-by: Daniel Vetter > --- > Documentation/gpu/drm-kms.rst | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/Documentation/gpu/drm-kms.r

Re: [PATCH 5/8] clk: bcm2835: add the dsi clocks

2016-03-19 Thread Eric Anholt
ker...@martin.sperl.org writes: > From: Martin Sperl > > Add the missing dsi clocks using the currently "best known" > parent-mux available for these clocks. Having been working on DSI support, there is definitely no point in DSI0 and DSI1 pixel clocks without their proper parents and this patch

Re: [PATCH 2/8] clk: bcm2835: add missing PLL clock divider

2016-03-19 Thread Eric Anholt
ker...@martin.sperl.org writes: > From: Martin Sperl > > Add the missing pll clock divider definitions. > > Signed-off-by: Martin Sperl > --- > drivers/clk/bcm/clk-bcm2835.c | 50 > +++ > include/dt-bindings/clock/bcm2835.h |8 ++ > 2 files chang

Re: [PATCH 2/8] clk: bcm2835: add missing PLL clock divider

2016-03-19 Thread Eric Anholt
Martin Sperl writes: >> On 17.03.2016, at 17:57, Eric Anholt wrote: >> >> >> These don't exist on the hardware as far as I've been able to find. "I >> found it in a header file somewhere" is not sufficient justification to >> expose it

Re: [PATCH 3/8] clk: bcm2835: add missing osc and per clocks

2016-03-19 Thread Eric Anholt
ker...@martin.sperl.org writes: > From: Martin Sperl > > Add definitions for the following clocks: > * AVE0 > * DFT > * GP0 > * GP1 > * GP2 > * PULSE > * SLIM > * SMI > * TEC > > Signed-off-by: Martin Sperl > --- > drivers/clk/bcm/clk-bcm2835.c | 71 > ++

Re: [PATCH 3/8] clk: bcm2835: add missing osc and per clocks

2016-03-18 Thread Eric Anholt
ker...@martin.sperl.org writes: > From: Martin Sperl > > Add definitions for the following clocks: > * AVE0 > * DFT > * GP0 > * GP1 > * GP2 > * PULSE > * SLIM > * SMI > * TEC > > Signed-off-by: Martin Sperl > --- > + [BCM2835_CLOCK_DFT] = REGISTER_PER_CLK( > + .name = "dft",