Re: [RFC 29/33] KVM: VMX: Save instruction length on EPT violation

2023-11-08 Thread Jim Mattson
On Wed, Nov 8, 2023 at 9:27 AM Alexander Graf wrote: > My point with the comment on this patch was "Don't break AMD (or ancient > VMX without instruction length decoding [Does that exist? I know SVM has > old CPUs that don't do it]) please". VM-exit instruction length is not defined for all VM-e

Re: [PATCH v6] kvm: better MWAIT emulation for guests

2017-04-12 Thread Jim Mattson
On Wed, Apr 12, 2017 at 7:54 AM, Alexander Graf wrote: > > > On 12.04.17 16:34, Jim Mattson wrote: >> >> Actually, we have rejected commit 87c00572ba05aa8c ("kvm: x86: emulate >> monitor and mwait instructions as nop"), so when we intercept >> MONITOR/M

Re: [PATCH v6] kvm: better MWAIT emulation for guests

2017-04-12 Thread Jim Mattson
1, 2017 at 11:23 AM, Alexander Graf wrote: > > >> Am 11.04.2017 um 19:10 schrieb Jim Mattson : >> >> This might be more useful if it could be dynamically toggled on and >> off, depending on system load. > > What would trapping mwait (currently) buy you? > >

Re: [PATCH v6] kvm: better MWAIT emulation for guests

2017-04-11 Thread Jim Mattson
This might be more useful if it could be dynamically toggled on and off, depending on system load. On Tue, Apr 11, 2017 at 4:45 AM, Alexander Graf wrote: > From: "Michael S. Tsirkin" > > Guests that are heavy on futexes end up IPI'ing each other a lot. That > can lead to significant slowdowns an

Re: [PATCH v5 untested] kvm: better MWAIT emulation for guests

2017-03-28 Thread Jim Mattson
On Tue, Mar 28, 2017 at 7:28 AM, Radim Krčmář wrote: > 2017-03-27 15:34+0200, Alexander Graf: >> On 15/03/2017 22:22, Michael S. Tsirkin wrote: >>> Guests running Mac OS 5, 6, and 7 (Leopard through Lion) have a problem: >>> unless explicitly provided with kernel command line argument >>> "idlehal

Re: [PATCH] kvm: better MWAIT emulation for guests

2017-03-10 Thread Jim Mattson
On Thu, Mar 9, 2017 at 2:29 PM, Michael S. Tsirkin wrote: > Some guests call mwait without checking the cpu flags. We currently "Some guests"? What guests other than Mac OS X are so ill-behaved? > emulate that as a NOP but on VMX we can do better: let guest stop the > CPU until timer or IPI. C