Re: [PATCH 4/4] serial: doc: .break_ctl() may sleep

2016-04-15 Thread Peter Hurley
On 04/15/2016 03:41 PM, Jonathan Corbet wrote: > On Fri, 15 Apr 2016 15:31:30 -0700 > Peter Hurley wrote: > >> The only caller of the uart driver's break_ctl() method is >> uart_break_ctl(), which is serial core's proxy tty driver break_ctl() >> metho

Re: [PATCH 4/4] serial: doc: .break_ctl() may sleep

2016-04-15 Thread Peter Hurley
proxy tty driver break_ctl() method. uart_break_ctl() claims the struct tty_port::mutex to prevent concurrent tiocmset(). Thus, the uart driver's break_ctl() method won't be called in atomic context. Regards, Peter Hurley -- To unsubscribe from this list: send the line "unsub

Re: [PATCH 5/9] serial: doc: Document .set_ldisc()

2016-03-19 Thread Peter Hurley
On 03/14/2016 08:16 AM, Geert Uytterhoeven wrote: Reviewed-by: Peter Hurley > Signed-off-by: Geert Uytterhoeven > --- > Documentation/serial/driver | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/serial/driver b/Documentation/serial/driver > i

Re: [PATCH 3/9] serial: doc: Document .throttle()

2016-03-19 Thread Peter Hurley
On 03/14/2016 08:16 AM, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven > --- > Documentation/serial/driver | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/serial/driver b/Documentation/serial/driver > index 61d520dea4c6e13a..50f3d94ed50b341e 100644 >

Re: [PATCH 1/9] serial: doc: Un-document non-existing uart_write_console()

2016-03-19 Thread Peter Hurley
Hi Geert, On 03/14/2016 08:16 AM, Geert Uytterhoeven wrote: > uart_write_console() never existed, not even when the "new > uart_write_console function" was documented. Right. Should be uart_console_write() > Fixes: 67ab7f596b6adbae ("[SERIAL] Update serial driver documentation") > Signed-off-by:

Re: [PATCH 6/9] serial: doc: .break_ctl() is called with port->mutex() held

2016-03-19 Thread Peter Hurley
On 03/14/2016 08:16 AM, Geert Uytterhoeven wrote: > Note that mutex_lock() should not be called with interrupts disabled. > > Signed-off-by: Geert Uytterhoeven > --- > Documentation/serial/driver | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/Documentation/serial/dri

Re: [PATCH 2/9] serial: doc: Un-document obsolete tmpbuf_sem

2016-03-19 Thread Peter Hurley
On 03/14/2016 08:16 AM, Geert Uytterhoeven wrote: > uart_info.tmpbuf and uart_info.tmpbuf_sem were removed in v2.6.10, in > full-history-linux commit a797ad7e3ae9cad4 ("[SERIAL] Clean up > serial_core.c write functions."). Reviewed-by: Peter Hurley -- To unsubscribe from

Re: [PATCH v3 5/7] ACPI: serial: implement earlycon on ACPI DBG2 port

2016-03-04 Thread Peter Hurley
On 03/04/2016 05:03 AM, Aleksey Makarov wrote: > Actually it was Mark Salter who asked to introduce such macros. > > https://lkml.kernel.org/g/1441730339.5459.8.ca...@redhat.com I wasn't copied on that series, sorry. > I think reusing the OF functions is a good decision. But you're not reusin

Re: [PATCH v3 5/7] ACPI: serial: implement earlycon on ACPI DBG2 port

2016-03-04 Thread Peter Hurley
On 03/04/2016 05:03 AM, Aleksey Makarov wrote: > > > On 03/03/2016 08:48 PM, Peter Hurley wrote: >> On 03/01/2016 08:57 AM, Aleksey Makarov wrote: >>> >>> >>> On 03/01/2016 06:53 PM, Peter Hurley wrote: >>>> On 02/29/2016 04:42 AM, Aleks

Re: [PATCH v3 5/7] ACPI: serial: implement earlycon on ACPI DBG2 port

2016-03-03 Thread Peter Hurley
On 03/03/2016 09:48 AM, Peter Hurley wrote: > On 03/01/2016 08:57 AM, Aleksey Makarov wrote: >> >> >> On 03/01/2016 06:53 PM, Peter Hurley wrote: >>> On 02/29/2016 04:42 AM, Aleksey Makarov wrote: >>>> Add ACPI_DBG2_EARLYCON_DECLARE() macros that de

Re: [PATCH v3 5/7] ACPI: serial: implement earlycon on ACPI DBG2 port

2016-03-03 Thread Peter Hurley
On 03/01/2016 08:57 AM, Aleksey Makarov wrote: > > > On 03/01/2016 06:53 PM, Peter Hurley wrote: >> On 02/29/2016 04:42 AM, Aleksey Makarov wrote: >>> Add ACPI_DBG2_EARLYCON_DECLARE() macros that declares >>> an earlycon on the serial port specified in the

Re: [PATCH v3 5/7] ACPI: serial: implement earlycon on ACPI DBG2 port

2016-03-01 Thread Peter Hurley
On 02/29/2016 04:42 AM, Aleksey Makarov wrote: > Add ACPI_DBG2_EARLYCON_DECLARE() macros that declares > an earlycon on the serial port specified in the DBG2 ACPI table. > > Pass the string "earlycon=acpi_dbg2" to the kernel to activate it. > > Callbacks for EARLYCON_DECLARE() and OF_EARLYCON_DEC

Re: [PATCH] tty: serial: meson: Add earlycon support

2016-02-07 Thread Peter Hurley
eson, meson_early_console_setup); > +OF_EARLYCON_DECLARE(meson, "amlogic,meson-uart", > + meson_early_console_setup); > + With today's linux-next (or Greg's tty-next tree), it is no longer necessary to declare separate earlycon's when you want both

Re: [PATCH] tty: serial: meson: Implement earlycon support

2016-02-07 Thread Peter Hurley
), it is no longer necessary to declare separate earlycon's when you want both; OF_EARLYCON_DECLARE() declares both a devicetree-enabled earlycon and automatically provides for a command line earlycon of the same name. Regards, Peter Hurley > + > #define MESON_SERIAL_CONSOLE (&meso