benefit of providing a unique identifier. On 64-bit machines
> -the first 32 bits are zeroed. If you *really* want the address see %px
> -below.
> +the first 32 bits are zeroed. The kernel will print ``(ptrval)`` until it
> +gathers enough entropy. If you *really* want the address s
On Mon, Mar 05, 2018 at 04:11:35AM -0800, Matthew Wilcox wrote:
> On Mon, Mar 05, 2018 at 02:58:21PM +1100, Tobin C. Harding wrote:
> > -12) When to use Acked-by: and Cc:
> > --
> > +12) When to use Acked-by: and
worked to allow for the
new tag.
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Reviewed-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Signed-off-by: Tobin C. Harding <m...@tobin.cc>
---
scripts/checkpatch.pl | 58 +++
When Co-Developed-by tag was added, docs were only added to
Documention/process/5.Posting.rst and were not added to
Documention/process/submitting-patches.rst
Add documentation to Documention/process/submitting-patches.rst
Signed-off-by: Tobin C. Harding <m...@tobin.cc>
---
Th
are a)
duplicative and b) out of sync
Also, there has been comment over the use of the second capitalized
character 'D'.
This patch set attempts to either resolve this issue or bury it for
good.
May the bike shedding begin :)
Joe Perches (1):
checkpatch: add check for tag Co-Developed-by
Tobin C. Harding (1
Added Greg to CC
On Sun, Feb 11, 2018 at 04:41:10PM -0800, Randy Dunlap wrote:
> On 02/11/18 16:37, Tobin C. Harding wrote:
> > On Sat, Feb 10, 2018 at 01:55:15PM +0100, Dominik Brodowski wrote:
> >> Up to now, all commit messages have used the "d" in lower case.
&g
On Sat, Feb 10, 2018 at 01:55:15PM +0100, Dominik Brodowski wrote:
> Up to now, all commit messages have used the "d" in lower case.
Those commit messages are wrong :(
> Signed-off-by: Dominik Brodowski
>
> diff --git a/Documentation/process/5.Posting.rst
>
On Wed, Feb 07, 2018 at 10:26:23AM -0700, Jonathan Corbet wrote:
> Move STATE_INLINE and STATE_DOCBLOCK code out of process_file(), which now
> actually fits on a single screen. Delete an unused variable and add a
> couple of comments while I'm at it.
>
> Signed-off-by: Jonathan Corbet
On Wed, Feb 07, 2018 at 10:26:16AM -0700, Jonathan Corbet wrote:
> So once upon a time I set out to fix the problem reported by Tobin wherein
> a literal block within a kerneldoc comment would be corrupted in
> processing. On the way, though, I got annoyed at the way I have to learn
> how
On Thu, Jan 11, 2018 at 09:25:31AM +1100, Tobin C. Harding wrote:
> On Wed, Jan 10, 2018 at 02:59:58PM -0700, Jonathan Corbet wrote:
> > On Wed, 10 Jan 2018 15:04:53 +1100
> > "Tobin C. Harding" <m...@tobin.cc> wrote:
> >
> > > Posting as RFC in the
On Wed, Jan 10, 2018 at 02:59:58PM -0700, Jonathan Corbet wrote:
> On Wed, 10 Jan 2018 15:04:53 +1100
> "Tobin C. Harding" <m...@tobin.cc> wrote:
>
> > Posting as RFC in the hope that someone knows how to massage sphinx
> > correctly to fix this patch.
&
On Wed, Jan 10, 2018 at 08:37:02AM -0800, Paul E. McKenney wrote:
> On Wed, Jan 10, 2018 at 03:04:53PM +1100, Tobin C. Harding wrote:
> > Posting as RFC in the hope that someone knows how to massage sphinx
> > correctly to fix this patch.
>
> I would welcome that. ;-)
>
'::' to pre-fix code snippet. Clears build warnings but does not
render correctly.
Signed-off-by: Tobin C. Harding <m...@tobin.cc>
---
To view current broken rendering see
https://www.kernel.org/doc/html/latest/core-api/kernel-api.html?highlight=rcu_pointer_handoff#c.rcu_pointer_h
On Tue, Jan 09, 2018 at 10:58:23AM -0700, Jonathan Corbet wrote:
> On Sat, 6 Jan 2018 12:30:37 +1100
> "Tobin C. Harding" <m...@tobin.cc> wrote:
>
> > Currently msg_zerocopy is not included in any toctree. Sphinx emits a
> > build warning to t
to the networking/ toctree.
Signed-off-by: Tobin C. Harding <m...@tobin.cc>
---
Documentation/networking/index.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/networking/index.rst
b/Documentation/networking/index.rst
index 66e620866245..19e8a927d79b 100644
--- a/Documen
On Thu, Dec 21, 2017 at 12:21:41PM -0700, Jonathan Corbet wrote:
> On Wed, 20 Dec 2017 08:17:14 +1100
> "Tobin C. Harding" <m...@tobin.cc> wrote:
>
> > This set converts printk-formats.txt -> core-api/printk-formats.rst
> >
> > We also update the
On Thu, Dec 21, 2017 at 11:26:22AM -0800, Randy Dunlap wrote:
> On 12/21/2017 11:21 AM, Jonathan Corbet wrote:
> > On Wed, 20 Dec 2017 08:17:14 +1100
> > "Tobin C. Harding" <m...@tobin.cc> wrote:
> >
> >> This set converts printk-formats.txt -> cor
On Wed, Dec 20, 2017 at 08:56:03AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Dec 20, 2017 at 11:25:41AM +1100, Tobin C. Harding wrote:
> > Hi,
> >
> > Recently we started a maintainer book (merged into Jonathan's docs-next
> > branch).
> >
> > Would an
Hi,
Recently we started a maintainer book (merged into Jonathan's docs-next
branch).
Would any current maintainers please be willing to explain how they go
about generating the automated emails one often receives when a patch
[set] is applied.
This may also be related to tree/branch management
(to commas).
- Remove extraneous double backticks (suggested by Jonathan Corbet).
- Simplify documentation for kobject.
Signed-off-by: Tobin C. Harding <m...@tobin.cc>
---
Documentation/00-INDEX | 2 -
Documentation/core-api/index.rst
printing kernel addresses.
Signed-off-by: Tobin C. Harding <m...@tobin.cc>
---
Documentation/security/self-protection.rst | 15 +++
1 file changed, 15 insertions(+)
diff --git a/Documentation/security/self-protection.rst
b/Documentation/security/self-protection.rst
index 60c8bd
Recently the behaviour of printk specifier %pK was changed. The
documentation does not currently mirror this.
Update documentation for sysctl kptr_restrict.
Signed-off-by: Tobin C. Harding <m...@tobin.cc>
---
Documentation/sysctl/kernel.txt | 3 ++-
1 file changed, 2 insertions(+), 1 de
ame (in section 'Thanks').
- Remove a few more double back ticks.
- Apply theory 'make as few changes as possible to complete the
conversion'
Tobin C. Harding (3):
doc: convert printk-formats.txt to rst
doc: update kptr_restrict documentation
doc: add documentation on printing k
On Mon, Dec 18, 2017 at 03:50:06PM -0800, Randy Dunlap wrote:
> On 12/18/2017 02:29 PM, Tobin C. Harding wrote:
> > Recently the behaviour of printk specifier %pK was changed. The
> > documentation does not currently mirror this.
> >
> > Update documentation for sy
Recently the behaviour of printk specifier %pK was changed. The
documentation does not currently mirror this.
Update documentation for sysctl kpt_restrict.
Signed-off-by: Tobin C. Harding <m...@tobin.cc>
---
Documentation/sysctl/kernel.txt | 3 ++-
1 file changed, 2 insertions(+), 1 de
(to commas).
- Remove extraneous double backticks (suggested by Jonathan Corbet).
- Simplify documentation for kobject.
Signed-off-by: Tobin C. Harding <m...@tobin.cc>
---
Documentation/00-INDEX | 2 -
Documentation/core-api/index.rst
printing kernel addresses.
Signed-off-by: Tobin C. Harding <m...@tobin.cc>
---
Documentation/security/self-protection.rst | 15 +++
1 file changed, 15 insertions(+)
diff --git a/Documentation/security/self-protection.rst
b/Documentation/security/self-protection.rst
index 60c8bd
Apply theory 'make as few changes as possible to complete the
conversion'
Tobin C. Harding (3):
doc: convert printk-formats.txt to rst
doc: update kpt_restrict documentation
doc: add documentation on printing kernel addresses
Documentation/00-INDEX | 2 -
D
On Sun, Dec 17, 2017 at 02:34:25PM -0800, Joe Perches wrote:
> On Mon, 2017-12-18 at 09:30 +1100, Tobin C. Harding wrote:
> > This set converts printk-formats.txt -> core-api/printk-formats.rst
> >
> > We also update the documentation around printing kernel addresses.
(to commas).
- Simplify documentation for kobject.
Signed-off-by: Tobin C. Harding <m...@tobin.cc>
---
Documentation/00-INDEX | 2 -
Documentation/core-api/index.rst | 1 +
.../printk-formats.rst}
Recently the behaviour of printk specifier %pK was changed. The
documentation does not currently mirror this.
Update documentation for sysctl kpt_restrict.
Signed-off-by: Tobin C. Harding <m...@tobin.cc>
---
Documentation/sysctl/kernel.txt | 3 ++-
1 file changed, 2 insertions(+), 1 de
printing kernel addresses.
Signed-off-by: Tobin C. Harding <m...@tobin.cc>
---
Documentation/security/self-protection.rst | 15 +++
1 file changed, 15 insertions(+)
diff --git a/Documentation/security/self-protection.rst
b/Documentation/security/self-protection.rst
index 60c8bd
ons.
thanks,
Tobin.
v2:
- Remove conversion/inclusion of kernel-docs from lib/vsprintf.c
- Add '<>' around file name (in section 'Thanks').
- Remove a few more double back ticks.
- Remove unnecessary [style] edits.
Tobin C. Harding (3):
doc: convert printk-formats.txt to rst
do
[Adding Laura]
On Fri, Dec 08, 2017 at 06:18:45PM -0800, Joe Perches wrote:
> On Sat, 2017-12-09 at 12:27 +1100, Tobin C. Harding wrote:
> > On Fri, Dec 08, 2017 at 01:22:37PM -0800, Joe Perches wrote:
>
> > > Outside of the documentation, what could be useful is for
> &
On Fri, Dec 08, 2017 at 01:22:37PM -0800, Joe Perches wrote:
> On Fri, 2017-12-08 at 13:06 -0800, Kees Cook wrote:
> > Well ... my sense is that lib/vsprintf.c should remain the canonical
> > documentation.
>
> I agree.
>
> > Anyone working on the code has the docs all together in
> > one file.
On Thu, Dec 07, 2017 at 04:19:56PM -0800, Kees Cook wrote:
> On Thu, Dec 7, 2017 at 3:44 PM, Tobin C. Harding <m...@tobin.cc> wrote:
> > Cheers Kees. FTR, changes to implement are:
> >
> > - Fix the capitalization of 'kernel'.
>
> I don't really have an op
On Thu, Dec 07, 2017 at 04:01:46PM -0700, Jonathan Corbet wrote:
> On Thu, 7 Dec 2017 14:50:42 -0800
> Kees Cook wrote:
>
> > > +These guides contain general information useful when writing kernel code.
> > > +
> > > +.. toctree::
> > > + :maxdepth: 1
> > > +
> > > +
On Thu, Dec 07, 2017 at 02:50:42PM -0800, Kees Cook wrote:
> On Tue, Dec 5, 2017 at 5:45 PM, Tobin C. Harding <m...@tobin.cc> wrote:
> > Documentation/printk-formats.txt is a candidate for conversion to
> > ReStructuredText format. Some effort has already been made to do thi
On Fri, Dec 08, 2017 at 09:27:54AM +1100, Tobin C. Harding wrote:
[snip]
New comments have come in from Kees Cook in thread for previous
version. Please drop this set so Kees's suggestions can be implemented.
thanks,
Tobin.
--
To unsubscribe from this list: send the line "unsubscribe linu
Recently the behaviour of printk specifier %pK was changed. The
documentation does not currently mirror this.
Update documentation for sysctl kpt_restrict.
Reported-by: Alexander Popov <alex.po...@linux.com>
Signed-off-by: Tobin C. Harding <m...@tobin.cc>
---
Documentation/sysctl/ke
(to commas).
- Simplify documentation for kobject.
- Convert lib/vsnprintf.c function docs to use kernel-docs and
include in Documentation/printk-formats.rst
Signed-off-by: Tobin C. Harding <m...@tobin.cc>
---
Documentation/00-INDEX | 2 -
Documentation/co
printing kernel addresses.
Signed-off-by: Tobin C. Harding <m...@tobin.cc>
Acked-by: Kees Cook <keesc...@chromium.org>
---
Documentation/security/self-protection.rst | 15 +++
1 file changed, 15 insertions(+)
diff --git a/Documentation/security/self-protection.rst
b/D
ply on top of Jon's docs-next tree (at time of writing at
rc-1) because of commit made to lib/vsprintf.c)
thanks,
Tobin.
Tobin C. Harding (3):
doc: convert printk-formats.txt to rst
doc: update kpt_restrict documentation
doc: add documentation on printing kernel addresses
Documentatio
On Thu, Dec 07, 2017 at 02:30:53PM -0700, Jonathan Corbet wrote:
> On Fri, 8 Dec 2017 08:21:09 +1100
> "Tobin C. Harding" <m...@tobin.cc> wrote:
>
> > Unless I'm a proper wombat that entry is not in the mainline MAINTAINERS
> > file.
>
> Um...from c
On Thu, Dec 07, 2017 at 08:44:37AM +0100, Markus Heiser wrote:
>
> > Am 07.12.2017 um 06:49 schrieb Tobin C. Harding <m...@tobin.cc>:
> >
> > Documentation/printk-formats.txt is a candidate for conversion to
> > ReStructuredText format. Some effort has already be
On Thu, Dec 07, 2017 at 01:52:56PM -0700, Jonathan Corbet wrote:
> On Fri, 8 Dec 2017 07:44:34 +1100
> "Tobin C. Harding" <m...@tobin.cc> wrote:
>
> > Where is Jon's tree hosted please, I don't see it on kernel.org
>
> From the MAINTAINERS file:
>
>
On Thu, Dec 07, 2017 at 01:52:56PM -0700, Jonathan Corbet wrote:
> On Fri, 8 Dec 2017 07:44:34 +1100
> "Tobin C. Harding" <m...@tobin.cc> wrote:
>
> > Where is Jon's tree hosted please, I don't see it on kernel.org
>
> From the MAINTAINERS file:
>
>
On Thu, Dec 07, 2017 at 01:52:56PM -0700, Jonathan Corbet wrote:
> On Fri, 8 Dec 2017 07:44:34 +1100
> "Tobin C. Harding" <m...@tobin.cc> wrote:
>
> > Where is Jon's tree hosted please, I don't see it on kernel.org
>
> From the MAINTAINERS file:
>
>
On Thu, Dec 07, 2017 at 08:44:37AM +0100, Markus Heiser wrote:
>
> > Am 07.12.2017 um 06:49 schrieb Tobin C. Harding <m...@tobin.cc>:
> >
> > Documentation/printk-formats.txt is a candidate for conversion to
> > ReStructuredText format. Some effort has already be
Please drop this patch, needs amendment (commented inline).
On Thu, Dec 07, 2017 at 11:26:38AM +1100, Tobin C. Harding wrote:
> Hashing addresses printed with printk specifier %p was implemented
> recently. During development a number of issues were raised regarding
> leaking kernel
On Wed, Dec 06, 2017 at 04:39:58PM -0800, Randy Dunlap wrote:
> On 12/06/2017 01:16 PM, Tobin C. Harding wrote:
> > On Wed, Dec 06, 2017 at 10:18:49AM -0800, Randy Dunlap wrote:
> >
> > Thanks for your comments Randy.
> >
>
> >>> Documentation/
On Wed, Dec 06, 2017 at 04:43:40PM -0800, Kees Cook wrote:
> On Wed, Dec 6, 2017 at 4:26 PM, Tobin C. Harding <m...@tobin.cc> wrote:
> > Hashing addresses printed with printk specifier %p was implemented
> > recently. During development a number of issues were raised regardi
-by: Tobin C. Harding <m...@tobin.cc>
---
Is there a proffered method for subscripts in sphinx kernel docs? Here
we use '[*]'
thanks,
Tobin.
Documentation/security/self-protection.rst | 14 ++
1 file changed, 14 insertions(+)
diff --git a/Documentation/security/self-protection.
On Wed, Dec 06, 2017 at 10:18:49AM -0800, Randy Dunlap wrote:
> On 12/05/2017 05:45 PM, Tobin C. Harding wrote:
> > Documentation/printk-formats.txt is a candidate for conversion to
> > ReStructuredText format. Some effort has already been made to do this
> > conversion ev
On Wed, Dec 06, 2017 at 11:23:25AM -0700, Jonathan Corbet wrote:
> On Wed, 6 Dec 2017 12:45:29 +1100
> "Tobin C. Harding" <m...@tobin.cc> wrote:
>
> > Documentation/printk-formats.txt is a candidate for conversion to
> > ReStructuredText format. So
On Wed, Dec 06, 2017 at 10:18:49AM -0800, Randy Dunlap wrote:
Thanks for your comments Randy.
> On 12/05/2017 05:45 PM, Tobin C. Harding wrote:
> > Documentation/printk-formats.txt is a candidate for conversion to
> > ReStructuredText format. Some effort has already
documentation for kobject.
- Convert lib/vsnprintf.c function docs to use kernel-docs and
include in Documentation/printk-formats.rst
Signed-off-by: Tobin C. Harding <m...@tobin.cc>
---
The last two need special reviewing please. In particular the conversion
of kernel-docs in vsnprintf.c a
On Mon, Dec 04, 2017 at 01:51:42PM -0800, Kees Cook wrote:
> On Mon, Dec 4, 2017 at 1:44 PM, Tobin C. Harding <m...@tobin.cc> wrote:
> > On Mon, Dec 04, 2017 at 01:28:45PM -0800, Kees Cook wrote:
> >> On Mon, Dec 4, 2017 at 1:22 PM, Tobin C. Harding <m...@tobin.cc> w
On Mon, Dec 04, 2017 at 01:28:45PM -0800, Kees Cook wrote:
> On Mon, Dec 4, 2017 at 1:22 PM, Tobin C. Harding <m...@tobin.cc> wrote:
> > Advice about what to use as a unique identifier is no longer valid since
> > patch series was merged to hash pointers printe
Advice about what to use as a unique identifier is no longer valid since
patch series was merged to hash pointers printed with %p. We can use
this as a unique identifier now.
Signed-off-by: Tobin C. Harding <m...@tobin.cc>
---
Documentation/security/self-protection.rst | 4 ++--
1 file c
e
chapters and the original email thread is referenced in
'pull-requests.rst'.
Signed-off-by: Tobin C. Harding <m...@tobin.cc>
Reviewed-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Reviewed-by: Mauro Carvalho Chehab <mche...@s-opensource.com>
---
v4:
- Add tweaks from Mauro.
- A
On Thu, Nov 30, 2017 at 09:06:21AM -0200, Mauro Carvalho Chehab wrote:
> Em Thu, 30 Nov 2017 21:47:44 +1100
> "Tobin C. Harding" <m...@tobin.cc> escreveu:
>
> > On Thu, Nov 30, 2017 at 07:01:19AM -0200, Mauro Carvalho Chehab wrote:
> > > Em Thu, 30 Nov 201
On Thu, Nov 30, 2017 at 07:01:19AM -0200, Mauro Carvalho Chehab wrote:
> Em Thu, 30 Nov 2017 12:55:07 +1100
> "Tobin C. Harding" <m...@tobin.cc> escreveu:
>
> > There is currently very little documentation in the kernel on maintainer
> > level tasks.
e
chapters and the original email thread is referenced in
'pull-requests.rst'.
Signed-off-by: Tobin C. Harding <m...@tobin.cc>
Reviewed-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
---
v3:
- Modified details for branch and tag naming, suggested by Mauro
Carvalho Chehab.
- Added exam
On Tue, Nov 28, 2017 at 11:03:56AM -0700, Jonathan Corbet wrote:
> On Fri, 24 Nov 2017 10:30:56 +1100
> "Tobin C. Harding" <m...@tobin.cc> wrote:
>
> > What's the status of the move from .txt to .rst files within the
> > kernel?
> >
> > The p
On Mon, Nov 27, 2017 at 07:01:23PM -0200, Mauro Carvalho Chehab wrote:
> Em Tue, 28 Nov 2017 07:53:03 +1100
> "Tobin C. Harding" <m...@tobin.cc> escreveu:
>
> > On Mon, Nov 27, 2017 at 04:57:30PM -0200, Mauro Carvalho Chehab wrote:
> > > Em Sat, 25 Nov 201
On Mon, Nov 27, 2017 at 04:57:30PM -0200, Mauro Carvalho Chehab wrote:
> Em Sat, 25 Nov 2017 08:44:19 +1100
> "Tobin C. Harding" <m...@tobin.cc> escreveu:
>
> > There is currently very little documentation in the kernel on maintainer
> > level tasks.
On Sat, Nov 25, 2017 at 08:56:23AM +0100, Greg Kroah-Hartman wrote:
> On Sat, Nov 25, 2017 at 08:44:19AM +1100, Tobin C. Harding wrote:
> > There is currently very little documentation in the kernel on maintainer
> > level tasks. In particular there are no documents on creating pu
e
chapters and the original email thread is referenced in
'pull-requests.rst'.
Signed-off-by: Tobin C. Harding <m...@tobin.cc>
---
v2:
- Change title of book, suggested by Dan Williams.
thanks,
Tobin.
Documentation/index.rst| 1 +
Documentation/maintainer/conf.py
On Fri, Nov 24, 2017 at 11:02:49AM -0800, Dan Williams wrote:
> On Tue, Nov 21, 2017 at 2:39 PM, Tobin C. Harding <m...@tobin.cc> wrote:
> > There is currently very little documentation in the kernel on maintainer
> > level tasks. In particular there are no documents on creat
Hi,
What's the status of the move from .txt to .rst files within the
kernel?
The point of the question; are patches converting .txt files in
Documentation/ to .rst files welcome?
thanks,
Tobin.
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to
e
chapters and the original email thread is referenced in
'pull-requests.rst'.
Signed-off-by: Tobin C. Harding <m...@tobin.cc>
---
Linus and Greg are CC'd because they are quoted heavily in the document.
Greg,
This is my second attempt at this but still it reads as if I am saying things
that actu
On Wed, Nov 15, 2017 at 04:09:32PM +0200, Jani Nikula wrote:
> On Wed, 15 Nov 2017, "Tobin C. Harding" <m...@tobin.cc> wrote:
> > On Tue, Nov 14, 2017 at 04:48:16PM -0700, Jonathan Corbet wrote:
> >
> > Awesome comments Jon, I knew there would be more to wr
On Tue, Nov 14, 2017 at 04:48:16PM -0700, Jonathan Corbet wrote:
Awesome comments Jon, I knew there would be more to writing docs than
first met the eye.
> On Wed, 15 Nov 2017 09:54:21 +1100
> "Tobin C. Harding" <m...@tobin.cc> wrote:
>
> > There is currently no
what I do, and it seems to work well, so maybe we should turn
it into the start of the documentation for how to do it.
Create document from email thread on LKML (referenced in document).
Signed-off-by: Tobin C. Harding <m...@tobin.cc>
---
Is it rude to send this during the merge window?
On Tue, Nov 14, 2017 at 12:05:00PM +0100, Greg Kroah-Hartman wrote:
> Adding lkml and linux-doc mailing lists...
>
> On Tue, Nov 14, 2017 at 10:11:55AM +1100, Tobin C. Harding wrote:
> > Hi Greg,
> >
> > This is totally asking a favour, feel free to ignore. How do yo
Added Linus to To: header.
On Tue, Nov 14, 2017 at 12:05:00PM +0100, Greg Kroah-Hartman wrote:
> Adding lkml and linux-doc mailing lists...
>
> On Tue, Nov 14, 2017 at 10:11:55AM +1100, Tobin C. Harding wrote:
> > Hi Greg,
> >
> > This is totally asking a favour, feel
77 matches
Mail list logo