Re: [PATCH] Documentation/memory-barriers: fix wrong comment in example

2016-02-22 Thread SeongJae Park
On Tue, Feb 23, 2016 at 1:33 AM, Paul E. McKenney wrote: > On Mon, Feb 22, 2016 at 11:16:39AM +, David Howells wrote: >> SeongJae Park wrote: >> >> > From f7b5677790771599f418f1d95536935be971ae86 Mon Sep 17 00:00:00 2001 >> > From: SeongJae Park >> > Date: Mon, 22 Feb 2016 19:26:18 +0900 >>

Re: [PATCH] Documentation/memory-barriers: fix wrong comment in example

2016-02-22 Thread Paul E. McKenney
On Mon, Feb 22, 2016 at 11:16:39AM +, David Howells wrote: > SeongJae Park wrote: > > > From f7b5677790771599f418f1d95536935be971ae86 Mon Sep 17 00:00:00 2001 > > From: SeongJae Park > > Date: Mon, 22 Feb 2016 19:26:18 +0900 > > Subject: [PATCH] Documentation/memory-barriers: polish compiler

Re: [PATCH] Documentation/memory-barriers: fix wrong comment in example

2016-02-22 Thread David Howells
SeongJae Park wrote: > From f7b5677790771599f418f1d95536935be971ae86 Mon Sep 17 00:00:00 2001 > From: SeongJae Park > Date: Mon, 22 Feb 2016 19:26:18 +0900 > Subject: [PATCH] Documentation/memory-barriers: polish compiler store omit > example > > Comments of examples about compiler store omit

Re: [PATCH] Documentation/memory-barriers: fix wrong comment in example

2016-02-22 Thread SeongJae Park
On Mon, 22 Feb 2016, David Howells wrote: SeongJae Park wrote: a = 0; /* Code that does not store to variable a. */ + does_not_change_a(); a = 0; Since it's not actually code that's meant to be executed, you could make it: a = 0; ... code that does not store to vari

Re: [PATCH] Documentation/memory-barriers: fix wrong comment in example

2016-02-22 Thread David Howells
SeongJae Park wrote: > a = 0; > /* Code that does not store to variable a. */ > + does_not_change_a(); > a = 0; Since it's not actually code that's meant to be executed, you could make it: a = 0; ... code that does not store to variable a ... a = 0; David -- To un

Re: [PATCH] Documentation/memory-barriers: fix wrong comment in example

2016-02-21 Thread Paul E. McKenney
On Sun, Feb 21, 2016 at 07:50:19AM +0900, SeongJae Park wrote: > On Sun, Feb 21, 2016 at 4:57 AM, Paul E. McKenney > wrote: > > On Sat, Feb 20, 2016 at 03:01:08PM +0900, SeongJae Park wrote: > >> There is wrong comment in example for compiler store omit behavior. It > >> shows example of the prob

Re: [PATCH] Documentation/memory-barriers: fix wrong comment in example

2016-02-21 Thread SeongJae Park
On Sun, Feb 21, 2016 at 2:25 PM, Paul E. McKenney wrote: > On Sun, Feb 21, 2016 at 07:50:19AM +0900, SeongJae Park wrote: >> On Sun, Feb 21, 2016 at 4:57 AM, Paul E. McKenney >> wrote: >> > On Sat, Feb 20, 2016 at 03:01:08PM +0900, SeongJae Park wrote: >> >> There is wrong comment in example for

Re: [PATCH] Documentation/memory-barriers: fix wrong comment in example

2016-02-20 Thread SeongJae Park
On Sun, Feb 21, 2016 at 4:57 AM, Paul E. McKenney wrote: > On Sat, Feb 20, 2016 at 03:01:08PM +0900, SeongJae Park wrote: >> There is wrong comment in example for compiler store omit behavior. It >> shows example of the problem and than problem solved version code. >> However, the comment in the

Re: [PATCH] Documentation/memory-barriers: fix wrong comment in example

2016-02-20 Thread Paul E. McKenney
On Sat, Feb 20, 2016 at 03:01:08PM +0900, SeongJae Park wrote: > There is wrong comment in example for compiler store omit behavior. It > shows example of the problem and than problem solved version code. > However, the comment in the solved version is still same with not solved > version. Fix th

[PATCH] Documentation/memory-barriers: fix wrong comment in example

2016-02-19 Thread SeongJae Park
There is wrong comment in example for compiler store omit behavior. It shows example of the problem and than problem solved version code. However, the comment in the solved version is still same with not solved version. Fix the wrong statement with this commit. Signed-off-by: SeongJae Park ---