Re: [PATCH] Improve mutex documentation

2018-03-16 Thread Peter Zijlstra
On Thu, Mar 15, 2018 at 04:58:12AM -0700, Matthew Wilcox wrote: > On Wed, Mar 14, 2018 at 01:56:31PM -0700, Andrew Morton wrote: > > My memory is weak and our documentation is awful. What does > > mutex_lock_killable() actually do and how does it differ from > > mutex_lock_interruptible()? > >

Re: [PATCH] Improve mutex documentation

2018-03-15 Thread Kirill Tkhai
On 15.03.2018 16:18, Matthew Wilcox wrote: > On Thu, Mar 15, 2018 at 03:12:30PM +0300, Kirill Tkhai wrote: >>> +/** >>> + * mutex_lock_killable() - Acquire the mutex, interruptible by fatal >>> signals. >> >> Shouldn't we clarify that fatal signals are SIGKILL only? > > It's more complicated

Re: [PATCH] Improve mutex documentation

2018-03-15 Thread Matthew Wilcox
On Thu, Mar 15, 2018 at 03:12:30PM +0300, Kirill Tkhai wrote: > > +/** > > + * mutex_lock_killable() - Acquire the mutex, interruptible by fatal > > signals. > > Shouldn't we clarify that fatal signals are SIGKILL only? It's more complicated than it might seem (... welcome to signal handling!)

Re: [PATCH] Improve mutex documentation

2018-03-15 Thread Kirill Tkhai
Hi, Matthew, On 15.03.2018 14:58, Matthew Wilcox wrote: > On Wed, Mar 14, 2018 at 01:56:31PM -0700, Andrew Morton wrote: >> My memory is weak and our documentation is awful. What does >> mutex_lock_killable() actually do and how does it differ from >> mutex_lock_interruptible()? > > From:

[PATCH] Improve mutex documentation

2018-03-15 Thread Matthew Wilcox
On Wed, Mar 14, 2018 at 01:56:31PM -0700, Andrew Morton wrote: > My memory is weak and our documentation is awful. What does > mutex_lock_killable() actually do and how does it differ from > mutex_lock_interruptible()? From: Matthew Wilcox Add kernel-doc for