[PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

2017-09-05 Thread Andrew Jeffery
Some functions exposed by pmbus core conflated errors that occurred when setting the page to access with errors that occurred when accessing registers in a page. In some cases, this caused legitimate errors to be hidden under the guise of the register not being supported. Signed-off-by: Andrew Jef

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

2017-09-05 Thread Guenter Roeck
On Tue, Sep 05, 2017 at 05:01:32PM +1000, Andrew Jeffery wrote: > Some functions exposed by pmbus core conflated errors that occurred when > setting the page to access with errors that occurred when accessing > registers in a page. In some cases, this caused legitimate errors to be > hidden under t

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

2017-09-05 Thread Andrew Jeffery
On Tue, 2017-09-05 at 10:00 -0700, Guenter Roeck wrote: > On Tue, Sep 05, 2017 at 05:01:32PM +1000, Andrew Jeffery wrote: > > Some functions exposed by pmbus core conflated errors that occurred when > > setting the page to access with errors that occurred when accessing > > registers in a page. In

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

2017-09-06 Thread Guenter Roeck
On Wed, Sep 06, 2017 at 10:23:37AM +1000, Andrew Jeffery wrote: > On Tue, 2017-09-05 at 10:00 -0700, Guenter Roeck wrote: > > On Tue, Sep 05, 2017 at 05:01:32PM +1000, Andrew Jeffery wrote: > > > Some functions exposed by pmbus core conflated errors that occurred when > > > setting the page to acce

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

2017-09-06 Thread Andrew Jeffery
On Wed, 2017-09-06 at 15:51 -0700, Guenter Roeck wrote: > On Wed, Sep 06, 2017 at 10:23:37AM +1000, Andrew Jeffery wrote: > > On Tue, 2017-09-05 at 10:00 -0700, Guenter Roeck wrote: > > > On Tue, Sep 05, 2017 at 05:01:32PM +1000, Andrew Jeffery wrote: > > > > Some functions exposed by pmbus core co

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

2017-09-06 Thread Guenter Roeck
On 09/06/2017 04:32 PM, Andrew Jeffery wrote: On Wed, 2017-09-06 at 15:51 -0700, Guenter Roeck wrote: On Wed, Sep 06, 2017 at 10:23:37AM +1000, Andrew Jeffery wrote: On Tue, 2017-09-05 at 10:00 -0700, Guenter Roeck wrote: On Tue, Sep 05, 2017 at 05:01:32PM +1000, Andrew Jeffery wrote: Some fu

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

2017-09-07 Thread Guenter Roeck
On 09/06/2017 04:32 PM, Andrew Jeffery wrote: Guess I need to dig up my eval board and see if I can reproduce the problem. Seems you are saying that the problem is always seen when issuing a sequence of "clear faults" commands on multiple pages ? Yeah. We're also seeing bad behaviour under

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

2017-09-07 Thread Andrew Jeffery
On Thu, 2017-09-07 at 06:40 -0700, Guenter Roeck wrote: > On 09/06/2017 04:32 PM, Andrew Jeffery wrote: > > > >    > > > Guess I need to dig up my eval board and see if I can reproduce the > > > problem. > > > Seems you are saying that the problem is always seen when issuing a > > > sequence > >

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

2017-09-07 Thread Guenter Roeck
On 09/07/2017 08:22 AM, Andrew Jeffery wrote: On Thu, 2017-09-07 at 06:40 -0700, Guenter Roeck wrote: On 09/06/2017 04:32 PM, Andrew Jeffery wrote: Guess I need to dig up my eval board and see if I can reproduce the problem. Seems you are saying that the problem is always seen when issuing

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

2017-09-07 Thread Andrew Jeffery
On Thu, 2017-09-07 at 17:27 -0700, Guenter Roeck wrote: > On 09/07/2017 08:22 AM, Andrew Jeffery wrote: > > On Thu, 2017-09-07 at 06:40 -0700, Guenter Roeck wrote: > > > On 09/06/2017 04:32 PM, Andrew Jeffery wrote: > > > > > > > >     > > > > > Guess I need to dig up my eval board and see if I ca

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

2017-09-07 Thread Guenter Roeck
On 09/07/2017 06:02 PM, Andrew Jeffery wrote: On Thu, 2017-09-07 at 17:27 -0700, Guenter Roeck wrote: On 09/07/2017 08:22 AM, Andrew Jeffery wrote: On Thu, 2017-09-07 at 06:40 -0700, Guenter Roeck wrote: On 09/06/2017 04:32 PM, Andrew Jeffery wrote: Guess I need to dig up my eval board a

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

2017-09-07 Thread Andrew Jeffery
On Thu, 2017-09-07 at 18:26 -0700, Guenter Roeck wrote: > On 09/07/2017 06:02 PM, Andrew Jeffery wrote: > > On Thu, 2017-09-07 at 17:27 -0700, Guenter Roeck wrote: > > > On 09/07/2017 08:22 AM, Andrew Jeffery wrote: > > > > On Thu, 2017-09-07 at 06:40 -0700, Guenter Roeck wrote: > > > > > On 09/06/

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

2017-09-07 Thread Guenter Roeck
On 09/07/2017 07:06 PM, Andrew Jeffery wrote: On Thu, 2017-09-07 at 18:26 -0700, Guenter Roeck wrote: On 09/07/2017 06:02 PM, Andrew Jeffery wrote: On Thu, 2017-09-07 at 17:27 -0700, Guenter Roeck wrote: On 09/07/2017 08:22 AM, Andrew Jeffery wrote: On Thu, 2017-09-07 at 06:40 -0700, Guenter

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

2017-09-07 Thread Andrew Jeffery
On Thu, 2017-09-07 at 19:17 -0700, Guenter Roeck wrote: > On 09/07/2017 07:06 PM, Andrew Jeffery wrote: > > On Thu, 2017-09-07 at 18:26 -0700, Guenter Roeck wrote: > > > On 09/07/2017 06:02 PM, Andrew Jeffery wrote: > > > > On Thu, 2017-09-07 at 17:27 -0700, Guenter Roeck wrote: > > > > > On 09/07/

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

2017-09-07 Thread Andrew Jeffery
On Fri, 2017-09-08 at 12:51 +1000, Andrew Jeffery wrote: > > I can't test with devicetree. x86 system. > >  > > 2,100+ iterations with your driver, no failures. > > Great. I really appreciate your testing here, so thanks for your > efforts. I owe you a few drinks if we ever happen to meet. Actual

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

2017-09-07 Thread Guenter Roeck
On 09/07/2017 08:40 PM, Andrew Jeffery wrote: On Fri, 2017-09-08 at 12:51 +1000, Andrew Jeffery wrote: I can't test with devicetree. x86 system. 2,100+ iterations with your driver, no failures. Great. I really appreciate your testing here, so thanks for your efforts. I owe you a few drinks

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

2017-09-07 Thread Andrew Jeffery
On Thu, 2017-09-07 at 21:43 -0700, Guenter Roeck wrote: > On 09/07/2017 08:40 PM, Andrew Jeffery wrote: > > On Fri, 2017-09-08 at 12:51 +1000, Andrew Jeffery wrote: > > > > I can't test with devicetree. x86 system. > > > >    > > > > 2,100+ iterations with your driver, no failures. > > > > > > Gre

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

2017-09-07 Thread Guenter Roeck
On 09/07/2017 08:40 PM, Andrew Jeffery wrote: On Fri, 2017-09-08 at 12:51 +1000, Andrew Jeffery wrote: I can't test with devicetree. x86 system. 2,100+ iterations with your driver, no failures. Great. I really appreciate your testing here, so thanks for your efforts. I owe you a few drinks

Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors

2017-09-07 Thread Andrew Jeffery
On Thu, 2017-09-07 at 22:14 -0700, Guenter Roeck wrote: > On 09/07/2017 08:40 PM, Andrew Jeffery wrote: > > On Fri, 2017-09-08 at 12:51 +1000, Andrew Jeffery wrote: > > > > I can't test with devicetree. x86 system. > > > >    > > > > 2,100+ iterations with your driver, no failures. > > > > > > Gre