Re: [PATCH v2 03/17] media: v4l2-common: get rid of struct v4l2_discrete_probe

2017-10-13 Thread Hans Verkuil
On 09/27/17 23:46, Mauro Carvalho Chehab wrote: > This struct is there just two store two arguments of > v4l2_find_nearest_format(). The other two arguments are passed > as parameter. > > IMHO, there isn't much sense on doing that, and that will just > add one more struct to document ;) > > So,

Re: [PATCH v2 03/17] media: v4l2-common: get rid of struct v4l2_discrete_probe

2017-10-13 Thread Laurent Pinchart
Hi Mauro, Thank you for the patch. On Thursday, 28 September 2017 00:46:46 EEST Mauro Carvalho Chehab wrote: > This struct is there just two store two arguments of > v4l2_find_nearest_format(). The other two arguments are passed > as parameter. > > IMHO, there isn't much sense on doing that,

[PATCH v2 03/17] media: v4l2-common: get rid of struct v4l2_discrete_probe

2017-09-27 Thread Mauro Carvalho Chehab
This struct is there just two store two arguments of v4l2_find_nearest_format(). The other two arguments are passed as parameter. IMHO, there isn't much sense on doing that, and that will just add one more struct to document ;) So, let's get rid of the struct, passing the parameters directly.