[PATCH v2 08/17] media: v4l2-ioctl.h: convert debug macros into enum and document

2017-09-27 Thread Mauro Carvalho Chehab
Currently, there's no way to document #define foo with kernel-doc. So, convert it to an enum, and document. Signed-off-by: Mauro Carvalho Chehab --- include/media/v4l2-ioctl.h | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/include/media/v

Re: [PATCH v2 08/17] media: v4l2-ioctl.h: convert debug macros into enum and document

2017-10-13 Thread Laurent Pinchart
Hi Mauro, Thank you for the patch. On Thursday, 28 September 2017 00:46:51 EEST Mauro Carvalho Chehab wrote: > Currently, there's no way to document #define foo > with kernel-doc. So, convert it to an enum, and document. The documentation seems fine to me (except for one comment below). However

Re: [PATCH v2 08/17] media: v4l2-ioctl.h: convert debug macros into enum and document

2017-10-13 Thread Hans Verkuil
On 09/27/17 23:46, Mauro Carvalho Chehab wrote: > Currently, there's no way to document #define foo > with kernel-doc. So, convert it to an enum, and document. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil Thanks, Hans > --- > include/media/v4l2-ioctl.h | 33 +

Re: [PATCH v2 08/17] media: v4l2-ioctl.h: convert debug macros into enum and document

2017-12-18 Thread Mauro Carvalho Chehab
Em Fri, 13 Oct 2017 15:38:11 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Thursday, 28 September 2017 00:46:51 EEST Mauro Carvalho Chehab wrote: > > Currently, there's no way to document #define foo > > with kernel-doc. So, convert it to an enum, and documen

Re: [PATCH v2 08/17] media: v4l2-ioctl.h: convert debug macros into enum and document

2017-12-18 Thread Laurent Pinchart
Hi Mauro, On Monday, 18 December 2017 17:13:26 EET Mauro Carvalho Chehab wrote: > Em Fri, 13 Oct 2017 15:38:11 +0300 Laurent Pinchart escreveu: > > On Thursday, 28 September 2017 00:46:51 EEST Mauro Carvalho Chehab wrote: > >> Currently, there's no way to document #define foo > >> with kernel-doc

Re: [PATCH v2 08/17] media: v4l2-ioctl.h: convert debug macros into enum and document

2017-12-18 Thread Mauro Carvalho Chehab
Em Mon, 18 Dec 2017 17:32:11 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > On Monday, 18 December 2017 17:13:26 EET Mauro Carvalho Chehab wrote: > > Em Fri, 13 Oct 2017 15:38:11 +0300 Laurent Pinchart escreveu: > > > On Thursday, 28 September 2017 00:46:51 EEST Mauro Carvalho Chehab wrote: