Re: [PATCH v4 01/44] dma-mapping: Use unsigned long for dma_attrs

2016-06-13 Thread Luis R. Rodriguez
On Mon, Jun 13, 2016 at 09:00:41AM -0700, Christoph Hellwig wrote: > On Fri, Jun 10, 2016 at 04:49:47PM +0200, Luis R. Rodriguez wrote: > > Do we not expect the number of argument to grow ? This "cleanup" would > > do away with such possibilities, and then require adding the API later, > > and

Re: [PATCH v4 01/44] dma-mapping: Use unsigned long for dma_attrs

2016-06-13 Thread Christoph Hellwig
On Fri, Jun 10, 2016 at 04:49:47PM +0200, Luis R. Rodriguez wrote: > Do we not expect the number of argument to grow ? This "cleanup" would > do away with such possibilities, and then require adding the API later, > and this requiring a full set of collateral evolutions again when this > is

Re: [PATCH v4 01/44] dma-mapping: Use unsigned long for dma_attrs

2016-06-10 Thread Luis R. Rodriguez
On Fri, Jun 10, 2016 at 10:44:19PM +0200, Krzysztof Kozlowski wrote: > On Fri, Jun 10, 2016 at 10:23:47PM +0200, Luis R. Rodriguez wrote: > > On Fri, Jun 10, 2016 at 10:16:00PM +0200, Krzysztof Kozlowski wrote: > > > The dma-attrs in current form were added around 2008 in 74bc7ceebfa1 > > > ("dma:

Re: [PATCH v4 01/44] dma-mapping: Use unsigned long for dma_attrs

2016-06-10 Thread Luis R. Rodriguez
On Fri, Jun 10, 2016 at 10:16:00PM +0200, Krzysztof Kozlowski wrote: > On Fri, Jun 10, 2016 at 04:49:47PM +0200, Luis R. Rodriguez wrote: > > On Fri, Jun 10, 2016 at 12:11:18PM +0200, Krzysztof Kozlowski wrote: > > > The dma-mapping core and the implementations do not change the > > > DMA

Re: [PATCH v4 01/44] dma-mapping: Use unsigned long for dma_attrs

2016-06-10 Thread Luis R. Rodriguez
On Fri, Jun 10, 2016 at 12:11:18PM +0200, Krzysztof Kozlowski wrote: > The dma-mapping core and the implementations do not change the > DMA attributes passed by pointer. Thus the pointer can point to const > data. However the attributes do not have to be a bitfield. Instead > unsigned long will