Re: [PATCH v6 2/4] drm: Add API for capturing frame CRCs

2016-09-08 Thread Emil Velikov
On 8 September 2016 at 15:49, Tomeu Vizoso wrote: > On 8 September 2016 at 15:24, Emil Velikov wrote: >> Hi Tomeu, >> >> A couple of small nitpicks and a rather nasty looking bug, related to >> your earlier question. >> >> On 7 September 2016 at 11:27, Tomeu Vizoso >> wrote: >> >>> +static ssiz

Re: [PATCH v6 2/4] drm: Add API for capturing frame CRCs

2016-09-08 Thread Tomeu Vizoso
On 8 September 2016 at 15:24, Emil Velikov wrote: > Hi Tomeu, > > A couple of small nitpicks and a rather nasty looking bug, related to > your earlier question. > > On 7 September 2016 at 11:27, Tomeu Vizoso wrote: > >> +static ssize_t crc_control_write(struct file *file, const char __user *ubuf,

Re: [PATCH v6 2/4] drm: Add API for capturing frame CRCs

2016-09-08 Thread Emil Velikov
Hi Tomeu, A couple of small nitpicks and a rather nasty looking bug, related to your earlier question. On 7 September 2016 at 11:27, Tomeu Vizoso wrote: > +static ssize_t crc_control_write(struct file *file, const char __user *ubuf, > +size_t len, loff_t *offp) >

[PATCH v6 2/4] drm: Add API for capturing frame CRCs

2016-09-07 Thread Tomeu Vizoso
Adds files and directories to debugfs for controlling and reading frame CRCs, per CRTC: dri/0/crtc-0/crc dri/0/crtc-0/crc/control dri/0/crtc-0/crc/data Drivers can implement the set_crc_source callback() in drm_crtc_funcs to start and stop generating frame CRCs and can add entries to the output b